Re: RE: RE: Compiling temname.C on MSVC

2005-05-05 Thread Angus Leeming
Andre Poenitz wrote: > On Tue, May 03, 2005 at 05:03:57PM +0100, Angus Leeming wrote: >> Does this work for you? (Everything is, of course, fine here.) > > Couldn't you simply > > #define POPEN ::popen > #define POPEN ::_popen > #define POPEN bark > > and use > > FILE * inf = POPEN(cmd.c_str()

Re: RE: RE: Compiling temname.C on MSVC

2005-05-05 Thread Andre Poenitz
On Tue, May 03, 2005 at 05:03:57PM +0100, Angus Leeming wrote: > Does this work for you? (Everything is, of course, fine here.) Couldn't you simply #define POPEN ::popen #define POPEN ::_popen #define POPEN bark and use FILE * inf = POPEN(cmd.c_str(), os::popen_read_mode()); instead

RE: RE: RE: Compiling temname.C on MSVC

2005-05-03 Thread Rob Bearman
> Does this work for you? (Everything is, of course, fine here.) > > If so, please post your local changes to config.h and I'll update > development/Win32 accordingly. (I'll remove win32_kludge.diff also.) > > -- > Angus > Here's the patch to config.h. Everything builds fine, and it's nice to

RE: RE: RE: Compiling temname.C on MSVC

2005-05-03 Thread Angus Leeming
Rob Bearman wrote: >> I propose to modify configure.ac as attached so that running >> autogen.sh produces the also attached changes to the generated >> src/config.h.in. You don't actually run autogen.sh at all of >> course, but I >> anticipate that you'd use these config.h.in changes as a >> templ

RE: RE: RE: Compiling temname.C on MSVC

2005-05-03 Thread Rob Bearman
> I propose to modify configure.ac as attached so that running > autogen.sh produces the also attached changes to the generated > src/config.h.in. You don't actually run autogen.sh at all of > course, but I > anticipate that you'd use these config.h.in changes as a > template with > which to

RE: RE: Compiling temname.C on MSVC

2005-05-03 Thread Angus Leeming
Rob Bearman wrote: >> And is this definition telling the truth? Ie, do you have the mktemp >> function as well as the _mktemp function? > > I should note that for filetools.C, I must prepend the underscore on > popen and pclose. That might not have been clear since I stated that the > existing kl

RE: RE: Compiling temname.C on MSVC

2005-05-03 Thread Rob Bearman
> And is this definition telling the truth? Ie, do you have the mktemp > function as well as the _mktemp function? I should note that for filetools.C, I must prepend the underscore on popen and pclose. That might not have been clear since I stated that the existing kludge isn't necessary. Thanks

RE: RE: Compiling temname.C on MSVC

2005-05-03 Thread Rob Bearman
> And is this definition telling the truth? Ie, do you have the mktemp > function as well as the _mktemp function? Yes.

RE: Compiling temname.C on MSVC

2005-05-03 Thread Angus Leeming
Rob Bearman wrote: >> Rob, >> >> same idea but this time for tempname.C. It appears from the >> docs that we just need a few underscores. Does the attached >> patch enable you to compile? > Almost. Trivially, the "#if[n]def (_WIN32)" should be "#if[n]def _WIN32" > or the other variety that acce

RE: Compiling temname.C on MSVC

2005-05-03 Thread Rob Bearman
> Rob, > > same idea but this time for tempname.C. It appears from the > docs that we > just need a few underscores. Does the attached patch enable > you to compile? > > mktemp: > http://msdn.microsoft.com/library/default.asp?url=/library/en- > us/vclib/html/_crt__mktemp.2c_._wmktemp.asp > Equ