Re: [PATCH] reduce drastically number of calls to LyXText::getFont

2005-06-25 Thread Jean-Marc Lasgouttes
> "Bennett" == Bennett Helm <[EMAIL PROTECTED]> writes: Bennett> I'll be away from my test machine for a while, so it'll be a Bennett> couple weeks before I can give a definite answer. I looked Bennett> quickly at it after you committed the patch, and I didn't Bennett> notice any difference.

Re: [PATCH] reduce drastically number of calls to LyXText::getFont

2005-06-24 Thread Bennett Helm
On Jun 24, 2005, at 11:03 AM, Jean-Marc Lasgouttes wrote: "Bennett" == Bennett Helm <[EMAIL PROTECTED]> writes: The two patches are now applied. Bennett, you said at the time that the fontcache patch make things worse. If this is still true, I can keep the fontcache for qt/mac. Bennett> It

Re: [PATCH] reduce drastically number of calls to LyXText::getFont

2005-06-24 Thread Jean-Marc Lasgouttes
> "Bennett" == Bennett Helm <[EMAIL PROTECTED]> writes: >> The two patches are now applied. Bennett, you said at the time >> that the fontcache patch make things worse. If this is still true, >> I can keep the fontcache for qt/mac. Bennett> It does feel slower. These are the results I'm now

Re: [PATCH] reduce drastically number of calls to LyXText::getFont

2005-06-16 Thread Jean-Marc Lasgouttes
> "Juergen" == Juergen Spitzmueller <[EMAIL PROTECTED]> writes: Juergen> I'm not sure if this is related, but valgrind also reports Juergen> some leaks which look like they are related to font handling Juergen> (I do not really understand its output, so I might be wrong). Juergen> Attached is

RE: [PATCH] reduce drastically number of calls to LyXText::getFont

2005-06-14 Thread Rob Bearman
> >> "Bennett" == Bennett Helm <[EMAIL PROTECTED]> writes: > > > > Bennett> From what I can tell, it comes down to this. Rob is using > > Bennett> Mac OS X 10.4 (=Darwin 8.0.0), whereas I use > 10.3.9 (= Darwin > > Bennett> 7.9.0). > > > > Do you use the same Qt version? Is it compiled in the

Re: [PATCH] reduce drastically number of calls to LyXText::getFont

2005-06-14 Thread Jean-Marc Lasgouttes
> "Bennett" == Bennett Helm <[EMAIL PROTECTED]> writes: >> Rob, could you try to run LyX under Tiger's Shark.app? The time in >> lengthcombox.C does not seem to make sense to me. Bennett> I did that, and the 65% is for Rob's version. Here's a bit Bennett> more detail: | | | | | | | | | | |

Re: [PATCH] reduce drastically number of calls to LyXText::getFont

2005-06-14 Thread Bennett Helm
On Jun 14, 2005, at 8:50 AM, Jean-Marc Lasgouttes wrote: "Bennett" == Bennett Helm <[EMAIL PROTECTED]> writes: Bennett> From what I can tell, it comes down to this. Rob is using Bennett> Mac OS X 10.4 (=Darwin 8.0.0), whereas I use 10.3.9 (= Darwin Bennett> 7.9.0). Do you use the same Qt ver

Re: [PATCH] reduce drastically number of calls to LyXText::getFont

2005-06-14 Thread Jean-Marc Lasgouttes
> "Bennett" == Bennett Helm <[EMAIL PROTECTED]> writes: Bennett> Rob kindly provided me with his config.log and the lyx Bennett> application he compiled to see what the differences were. I was about to suggest that. Bennett> His version does run much faster on my machine than mine Bennett> d

Re: [PATCH] reduce drastically number of calls to LyXText::getFont

2005-06-13 Thread Bennett Helm
On Jun 10, 2005, at 5:24 PM, Rob Bearman wrote: I've been building with exactly the configuration specified in the README.MacOSX file. I thought at one time I needed --disable-concept-checks, but it turns out I've been mistakenly leaving off the 's' at the end for some time (which I guess mean

Re: [PATCH] reduce drastically number of calls to LyXText::getFont

2005-06-10 Thread Rob Bearman
On 6/10/05 12:32 PM, "Bennett Helm" <[EMAIL PROTECTED]> wrote: > I have a 512MB iMac G4 (1.25GHz); it's surely not my hardware that's > the issue. > > Perhaps it's the configuration. Here's what I've got (compiled with > gcc-3.3): > > ./configure --with-frontend=qt --without-x > --prefix=/Applica

Re: [PATCH] reduce drastically number of calls to LyXText::getFont

2005-06-10 Thread Bennett Helm
On Jun 10, 2005, at 1:55 PM, Rob Bearman wrote: I've been building 1.4 on the Mac (against qt-mac-free-3.3.4) for comparison purposes but I haven't seen any glaring perf problems. Forgive me if I'm confusing the issue by not having followed this thread carefully, but I've run the latest build

Re: [PATCH] reduce drastically number of calls to LyXText::getFont

2005-06-10 Thread Rob Bearman
On 6/10/05 9:36 AM, "Bennett Helm" <[EMAIL PROTECTED]> wrote: > But, frankly, the difference in speed introduced with the fontcache > patch is trivial compared to the slowness of lyx-140 overall: it really > is unusable on the Mac, and something else must account for the > slowness. > > I'd love

Re: [PATCH] reduce drastically number of calls to LyXText::getFont

2005-06-10 Thread Juergen Spitzmueller
Bennett Helm wrote: > But, frankly, the difference in speed introduced with the fontcache > patch is trivial compared to the slowness of lyx-140 overall: it really > is unusable on the Mac, and something else must account for the > slowness. I'm not sure if this is related, but valgrind also repor

Re: [PATCH] reduce drastically number of calls to LyXText::getFont

2005-06-10 Thread Bennett Helm
On Jun 10, 2005, at 10:56 AM, Jean-Marc Lasgouttes wrote: "Jean-Marc" == Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: Jean-Marc> The following patch reduces the number of calls to getFont Jean-Marc> by the two following means: Jean-Marc> For your enjoyment, I also attach the patch that re

Re: [PATCH] reduce drastically number of calls to LyXText::getFont

2005-06-10 Thread Jean-Marc Lasgouttes
> "Angus" == Angus Leeming <[EMAIL PROTECTED]> writes: Angus> Personally, I'm not going to try compiling LyX/Win 1.4.x until Angus> 1.3.6 is released. Maybe you can lean on Rob Bearman... We'll see if someone complains. Actually, what would be useful is someone running a profiler on LyX/Win.

Re: [PATCH] reduce drastically number of calls to LyXText::getFont

2005-06-10 Thread Angus Leeming
Jean-Marc Lasgouttes wrote: Jean-Marc> The following patch reduces the number of calls to getFont Jean-Marc> by the two following means: Jean-Marc> For your enjoyment, I also attach the patch that removes Jean-Marc> font metrics caching for qt, which I think is also Jean-Marc> relevant. The two

Re: [PATCH] reduce drastically number of calls to LyXText::getFont

2005-06-10 Thread Jean-Marc Lasgouttes
> "Jean-Marc" == Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: Jean-Marc> The following patch reduces the number of calls to getFont Jean-Marc> by the two following means: Jean-Marc> For your enjoyment, I also attach the patch that removes Jean-Marc> font metrics caching for qt, which I th

Re: [PATCH] reduce drastically number of calls to LyXText::getFont

2005-06-10 Thread Lars Gullik Bjønnes
Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: | To conclude, can I apply the following patches, or do you want to do | some testing first? No, go ahead. -- Lgb

Re: [PATCH] reduce drastically number of calls to LyXText::getFont

2005-06-10 Thread Lars Gullik Bjønnes
Angus Leeming <[EMAIL PROTECTED]> writes: | Jean-Marc Lasgouttes wrote: >> Jean-Marc> You mean that code like if (FOO_NOT_AVAILABLE) { // use >> Jean-Marc> function bar() instead x = bar(); } else { x= foo(); >> Jean-Marc> } >> Jean-Marc> will compile when foo() does not exist on the system? I a

Re: [PATCH] reduce drastically number of calls to LyXText::getFont

2005-06-09 Thread Angus Leeming
Jean-Marc Lasgouttes wrote: Jean-Marc> You mean that code like if (FOO_NOT_AVAILABLE) { // use Jean-Marc> function bar() instead x = bar(); } else { x= foo(); Jean-Marc> } Jean-Marc> will compile when foo() does not exist on the system? I am Jean-Marc> surprised. I see now that the GNU coding

Re: [PATCH] reduce drastically number of calls to LyXText::getFont

2005-06-09 Thread Jean-Marc Lasgouttes
> "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: Lars> No, that is not what I mean. What is mean is that the compiler Lars> will prune the whole if (false) block from the generated code. Indeed. And the fact that it will parse the (false) block nevertheless is nice. But guess it f

Re: [PATCH] reduce drastically number of calls to LyXText::getFont

2005-06-09 Thread Lars Gullik Bjønnes
Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: >> "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: > | Lars> the you should just leave it as is (+=). a push back buys | Lars> nothing. > | I did that. > | |Actually, I do not like it because both branches of the if() | |will be compil

Re: [PATCH] reduce drastically number of calls to LyXText::getFont

2005-06-09 Thread Jean-Marc Lasgouttes
> "Jean-Marc" == Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: Jean-Marc> You mean that code like if (FOO_NOT_AVAILABLE) { // use Jean-Marc> function bar() instead x = bar(); } else { x= foo(); Jean-Marc> } Jean-Marc> will compile when foo() does not exist on the system? I am Jean-Marc> s

Re: [PATCH] reduce drastically number of calls to LyXText::getFont

2005-06-09 Thread Jean-Marc Lasgouttes
> "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: Lars> the you should just leave it as is (+=). a push back buys Lars> nothing. I did that. |Actually, I do not like it because both branches of the if() |will be compiled and in many cases it will not work |(unavailable function). M

Re: [PATCH] reduce drastically number of calls to LyXText::getFont

2005-06-09 Thread Lars Gullik Bjønnes
Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: >> "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: > | Lars> I won't with -1 or +1 either :-), you need to check first span | Lars> either way. > | start is initialized to 0, which is the start of the first span. > | I changed -1 to +1

Re: [PATCH] reduce drastically number of calls to LyXText::getFont

2005-06-09 Thread Jean-Marc Lasgouttes
> "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: Lars> I won't with -1 or +1 either :-), you need to check first span Lars> either way. start is initialized to 0, which is the start of the first span. I changed -1 to +1 in the patch. | No idea. I left it as it was. I can assert o

Re: [PATCH] reduce drastically number of calls to LyXText::getFont

2005-06-08 Thread Lars Gullik Bjønnes
Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: >> "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: > | Lars> Is the logic in this loop correct? Wont the start positon always | Lars> just be one smaller than the end pos? > | I believe it is correct. It is the logic of the fonttable t

Re: [PATCH] reduce drastically number of calls to LyXText::getFont

2005-06-08 Thread Jean-Marc Lasgouttes
> "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: Lars> Is the logic in this loop correct? Wont the start positon always Lars> just be one smaller than the end pos? I believe it is correct. It is the logic of the fonttable that is really twisted. Note however that I did not have an

Re: [PATCH] reduce drastically number of calls to LyXText::getFont

2005-06-08 Thread Lars Gullik Bjønnes
Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: | Index: src/paragraph.C | === | RCS file: /usr/local/lyx/cvsroot/lyx-devel/src/paragraph.C,v | retrieving revision 1.405 | diff -u -p -r1.405 paragraph.C | --- src/paragraph.C 5 May