Re: Question on InsetText::setAutoBreakRows

2006-05-24 Thread Martin Vermeer
On Wed, May 24, 2006 at 07:45:25PM +0200, Michael Gerz wrote: > Martin, > > given the fact that you are not allowed to revert logical deletions within > the inset (otherwise you run into an inconsistent state), I am tempted to > remove linebreaks without CT marking. I.e. setAutoBreakRow does not

Re: Question on InsetText::setAutoBreakRows

2006-05-24 Thread Michael Gerz
Martin, given the fact that you are not allowed to revert logical deletions within the inset (otherwise you run into an inconsistent state), I am tempted to remove linebreaks without CT marking. I.e. setAutoBreakRow does not consider the buffer's change tracking mode. Does this make sense to y

Re: Question on InsetText::setAutoBreakRows

2006-05-24 Thread Martin Vermeer
On Wed, May 24, 2006 at 08:19:33PM +0300, Martin Vermeer wrote: > On Wed, May 24, 2006 at 06:26:18PM +0200, Michael Gerz wrote: ... > In non-ct mode, you irreversibly lose the newlines. It would be nice to > mark them "blue" under ct. s/blue/red/ - martin pgp4c4CqndxJe.pgp Description: PGP s

Re: Question on InsetText::setAutoBreakRows

2006-05-24 Thread Georg Baum
Michael Gerz wrote: > Does it make sense that setAutoBreakRows marks linebreaks as (logically) > deleted if they are disallowed? Is the user allowed to revert the deletion > later? No, he is not. Actually I did not think about that case. > This may lead to inconsistent states. Yes. It should on

Re: Question on InsetText::setAutoBreakRows

2006-05-24 Thread Michael Gerz
I am asking because setAutoBreakRows calls Paragraph::erase() which requires a trackChanges flags in the new CT code. I guess that the buffer parameter (ct on/off) has to be passed to setAutoBreakRows but I would like to know your opinion first. Yes, it has to be passed. LyXText::autoBreakRows_

Re: Question on InsetText::setAutoBreakRows

2006-05-24 Thread Martin Vermeer
On Wed, May 24, 2006 at 06:26:18PM +0200, Michael Gerz wrote: > Hello, > > could somebody please tell me the purpose of method > InsetText::setAutoBreakRows? > > I am asking because setAutoBreakRows calls Paragraph::erase() which requires > a trackChanges flags in the new CT code. I guess that

Re: Question on InsetText::setAutoBreakRows

2006-05-24 Thread Georg Baum
Michael Gerz wrote: > Hello, > > could somebody please tell me the purpose of method > InsetText::setAutoBreakRows? It sets the corresponding flag of LyXText, but I guess you knew that. > I am asking because setAutoBreakRows calls Paragraph::erase() which > requires a trackChanges flags in the

Question on InsetText::setAutoBreakRows

2006-05-24 Thread Michael Gerz
Hello, could somebody please tell me the purpose of method InsetText::setAutoBreakRows? I am asking because setAutoBreakRows calls Paragraph::erase() which requires a trackChanges flags in the new CT code. I guess that the buffer parameter (ct on/off) has to be passed to setAutoBreakRows but I