Re: [Patch] fix crashes with_buffer switch and exit (Re: Qt4: Crash in toolbar (Action code))

2006-08-23 Thread Lars Gullik Bjønnes
Georg Baum <[EMAIL PROTECTED]> writes: | > I'll try to read the TortoiseSVN doc to do that. | | Great. With plain svn yo'll have to use a trick unfortunately (set | | diff-cmd = /home/me/bin/svndiff Nah. I have this in my ~/.subversion/config: diff-cmd = diff And when I want to set specific o

Re: [Patch] fix crashes with_buffer switch and exit (Re: Qt4: Crash in toolbar (Action code))

2006-08-23 Thread Abdelrazak Younes
Georg Baum wrote: Abdelrazak Younes wrote: I would agree that the call to connectBuffer() could be saved if this buffer was already connected. But this is not the case, only one Buffer is connected at a time to the LyXView. While it could be possible to connect multiple buffers this is not done

Re: [Patch] fix crashes with_buffer switch and exit (Re: Qt4: Crash in toolbar (Action code))

2006-08-23 Thread Georg Baum
Abdelrazak Younes wrote: > I would agree that the call to connectBuffer() could be saved if this > buffer was already connected. But this is not the case, only one Buffer > is connected at a time to the LyXView. While it could be possible to > connect multiple buffers this is not done right now as

Re: [Patch] fix crashes with_buffer switch and exit (Re: Qt4: Crash in toolbar (Action code))

2006-08-23 Thread Abdelrazak Younes
Georg Baum wrote: Abdelrazak Younes wrote: Georg Baum wrote: Abdelrazak Younes wrote: Georg Baum wrote: This looks wrong (the rest looks OK). Do you know that b != work_area_->bufferView().buffer() is possible even after a work_area_->bufferView().setBuffer(b)? This was indeed the case bef

Re: [Patch] fix crashes with_buffer switch and exit (Re: Qt4: Crash in toolbar (Action code))

2006-08-23 Thread Georg Baum
Abdelrazak Younes wrote: > Georg Baum wrote: >> Abdelrazak Younes wrote: >> >>> Georg Baum wrote: This looks wrong (the rest looks OK). Do you know that b != work_area_->bufferView().buffer() is possible even after a work_area_->bufferView().setBuffer(b)? >>> This was indeed the ca

Re: [Patch] fix crashes with_buffer switch and exit (Re: Qt4: Crash in toolbar (Action code))

2006-08-23 Thread Angus Leeming
Abdelrazak Younes wrote: BTW, it would be nice if you could do your diffs with function names (-p argument of diff). I'll try to read the TortoiseSVN doc to do that. If I remember rightly, you can't change the arguments to the diff command used by svn but you can specify a *different* diff

Re: [Patch] fix crashes with_buffer switch and exit (Re: Qt4: Crash in toolbar (Action code))

2006-08-23 Thread Abdelrazak Younes
Georg Baum wrote: Abdelrazak Younes wrote: Georg Baum wrote: Abdelrazak Younes wrote: Index: frontends/LyXView.C === --- frontends/LyXView.C(revision 14813) +++ frontends/LyXView.C(working copy) @@ -139,22 +139,1

Re: [Patch] fix crashes with_buffer switch and exit (Re: Qt4: Crash in toolbar (Action code))

2006-08-23 Thread Georg Baum
Abdelrazak Younes wrote: > Georg Baum wrote: >> Abdelrazak Younes wrote: >> >>> Index: frontends/LyXView.C >>> === >>> --- frontends/LyXView.C(revision 14813) >>> +++ frontends/LyXView.C(working copy) >>> @@ -139,22 +

Re: [Patch] fix crashes with_buffer switch and exit (Re: Qt4: Crash in toolbar (Action code))

2006-08-23 Thread Abdelrazak Younes
Abdelrazak Younes wrote: Jean-Marc Lasgouttes wrote: [This is with or without my previous menu patch] - run LyX - Help>Introduction - Help>Tutorial - View>Intro.lyx - exit ===> crash! This patch fixes this crash and a few others. Will commit soon unless someone has an objection. Committed

Re: [Patch] fix crashes with_buffer switch and exit (Re: Qt4: Crash in toolbar (Action code))

2006-08-22 Thread Abdelrazak Younes
Georg Baum wrote: Abdelrazak Younes wrote: Index: frontends/LyXView.C === --- frontends/LyXView.C(revision 14813) +++ frontends/LyXView.C(working copy) @@ -139,22 +139,19 @@ work_area_->bufferView().setBu

Re: [Patch] fix crashes with_buffer switch and exit (Re: Qt4: Crash in toolbar (Action code))

2006-08-22 Thread Abdelrazak Younes
Angus Leeming wrote: Abdelrazak Younes wrote: Jean-Marc Lasgouttes wrote: [This is with or without my previous menu patch] - run LyX - Help>Introduction - Help>Tutorial - View>Intro.lyx - exit ===> crash! This patch fixes this crash and a few others. Will commit soon unless someone has an

Re: [Patch] fix crashes with_buffer switch and exit (Re: Qt4: Crash in toolbar (Action code))

2006-08-22 Thread Georg Baum
Abdelrazak Younes wrote: > Index: frontends/LyXView.C > === > --- frontends/LyXView.C(revision 14813) > +++ frontends/LyXView.C(working copy) > @@ -139,22 +139,19 @@ > > work_area_->bufferView().setBuffer(b)

Re: [Patch] fix crashes with_buffer switch and exit (Re: Qt4: Crash in toolbar (Action code))

2006-08-22 Thread Angus Leeming
Abdelrazak Younes wrote: Jean-Marc Lasgouttes wrote: [This is with or without my previous menu patch] - run LyX - Help>Introduction - Help>Tutorial - View>Intro.lyx - exit ===> crash! This patch fixes this crash and a few others. Will commit soon unless someone has an objection. No object

Re: [Patch] fix crashes with_buffer switch and exit (Re: Qt4: Crash in toolbar (Action code))

2006-08-22 Thread Abdelrazak Younes
Abdelrazak Younes wrote: Jean-Marc Lasgouttes wrote: [This is with or without my previous menu patch] - run LyX - Help>Introduction - Help>Tutorial - View>Intro.lyx - exit ===> crash! This patch fixes this crash and a few others. Will commit soon unless someone has an objection. Hum, up

[Patch] fix crashes with_buffer switch and exit (Re: Qt4: Crash in toolbar (Action code))

2006-08-22 Thread Abdelrazak Younes
Jean-Marc Lasgouttes wrote: [This is with or without my previous menu patch] - run LyX - Help>Introduction - Help>Tutorial - View>Intro.lyx - exit ===> crash! This patch fixes this crash and a few others. Will commit soon unless someone has an objection. Abdel. Log: * lyxfunc.C: - LyXFu

Re: Qt4: Crash in toolbar (Action code)

2006-08-22 Thread Abdelrazak Younes
Abdelrazak Younes wrote: Jean-Marc Lasgouttes wrote: [This is with or without my previous menu patch] - run LyX - Help>Introduction - Help>Tutorial - View>Intro.lyx - exit ===> crash! I don't see that... Are you sure your patch is not applied? Correction. I see that also, sorry. I missed t

Re: Qt4: Crash in toolbar (Action code)

2006-08-21 Thread Abdelrazak Younes
Jean-Marc Lasgouttes wrote: [This is with or without my previous menu patch] - run LyX - Help>Introduction - Help>Tutorial - View>Intro.lyx - exit ===> crash! I don't see that... Are you sure your patch is not applied? Abdel.

Qt4: Crash in toolbar (Action code)

2006-08-21 Thread Jean-Marc Lasgouttes
[This is with or without my previous menu patch] - run LyX - Help>Introduction - Help>Tutorial - View>Intro.lyx - exit ===> crash! Program received signal SIGSEGV, Segmentation fault. [Switching to Thread -1221143904 (LWP 17220)] 0x081b3127 in LyXFunc::getStatus (this=0x898a808, [EMAIL PROTECTE