Am Dienstag, 7. November 2006 17:16 schrieb Michael Gerz:
> I don't really see the benefit of replacing 30 #include statements by 70
> XML include tags but if you like it that way, I will do so.
We always try to include as little stuff as possible in headers, so we
should do that in this case, t
Michael Gerz wrote:
Georg Baum wrote:
Michael Gerz wrote:
Hi,
this patch makes Qt strings translateable again (at least when using
scons).
Can I commit?
No. Adding qt_helpers.h to all includes is wrong. The attached patch
contains an example how to do it correctly (and how it was do
Georg Baum wrote:
Michael Gerz wrote:
Hi,
this patch makes Qt strings translateable again (at least when using
scons).
Can I commit?
No. Adding qt_helpers.h to all includes is wrong. The attached patch
contains an example how to do it correctly (and how it was done in qt3) and
fixe
José Matos wrote:
> On Tuesday 07 November 2006 8:34 am, Georg Baum wrote:
>> -QString const qt_(char const * str)
>> +QString const qt_(char const * str int dummy)
>> {
>
> Isn't there a comma missing between str and int in the line above?
Yes. I did not notice because the patch was incomplete
On Tuesday 07 November 2006 8:34 am, Georg Baum wrote:
> -QString const qt_(char const * str)
> +QString const qt_(char const * str int dummy)
> {
Isn't there a comma missing between str and int in the line above?
--
José Abílio
Michael Gerz wrote:
> Hi,
>
> this patch makes Qt strings translateable again (at least when using
> scons).
>
> Can I commit?
No. Adding qt_helpers.h to all includes is wrong. The attached patch
contains an example how to do it correctly (and how it was done in qt3) and
fixes the autotools par
Hi,
this patch makes Qt strings translateable again (at least when using scons).
Can I commit?
Michael
Index: src/frontends/qt4/QERTDialog.h
===
--- src/frontends/qt4/QERTDialog.h (Revision 15770)
+++ src/frontends/qt4/QERTDialog.h
