On Sun, Mar 05, 2023 at 10:03:15PM +0100, Jean-Marc Lasgouttes wrote:
Le 03/03/2023 à 19:56, Enrico Forestieri a écrit :
Any reason for not doing it?
Go for it.
I have a doubt about this one. Are you sure that we do not care about fw?
#if QT_VERSION < 0x06
const int fw = style(
Le 03/03/2023 à 19:56, Enrico Forestieri a écrit :
Any reason for not doing it?
Go for it.
I have a doubt about this one. Are you sure that we do not care about fw?
#if QT_VERSION < 0x06
const int fw = style()->pixelMetric(QStyle::PM_MenuPanelWidth, 0, this);
layout_->set
On Fri, Mar 03, 2023 at 01:49:26PM +0100, Jean-Marc Lasgouttes wrote:
Other special Qt6 code I would like to remove is:
1/ this one seems to exist in Qt5
#if QT_VERSION < 0x06
QRect rec =
QApplication::desktop()->screenGeometry();
#else
QRect
Le 02/03/2023 à 15:57, Jean-Marc Lasgouttes a écrit :
This patch removes all traces of QRegExp. It will obviously need
testing, but this is already the code used with Qt6.
Riki, is this OK to apply?
No complaints -> I did it. I can revert if needed.
Other special Qt6 code I would like to rem
On Thu, Mar 02, 2023 at 08:59:22PM -0500, Richard Kimberly Heck wrote:
> On 3/2/23 17:28, Jean-Marc Lasgouttes wrote:
> >Le 02/03/2023 ?? 23:10, Stephan Witt a écrit :
> >>Am 02.03.2023 um 22:44 schrieb Richard Kimberly Heck
> >>:
> >>>
> >>>On 3/2/23 12:29, Stephan Witt wrote:
>
> ATM, Qt
Le 02/03/2023 à 23:32, Jean-Marc Lasgouttes a écrit :
Le 02/03/2023 à 17:41, Jean-Marc Lasgouttes a écrit :
Luckily it seems that GuiKeySymbol is the only code that uses
QTextCodec.
Luckily enough, the code in there is inside #if 0 ... #endif :)
This is gone now.
JMarc
--
lyx-devel mailin
Am Thu, 2 Mar 2023 21:31:44 +0100
schrieb Enrico Forestieri :
> On Thu, Mar 02, 2023 at 03:57:38PM +0100, Jean-Marc Lasgouttes wrote:
> >Le 20/02/2023 à 17:47, Jean-Marc Lasgouttes a écrit :
> >
> >>What I do not know is whether we can get rid of QtCore5Compat
> >>library. Is it useful for anyt
On 3/2/23 17:28, Jean-Marc Lasgouttes wrote:
Le 02/03/2023 à 23:10, Stephan Witt a écrit :
Am 02.03.2023 um 22:44 schrieb Richard Kimberly Heck
:
On 3/2/23 12:29, Stephan Witt wrote:
ATM, Qt6 is unusable on Mac because of bug 12641. :(
Does this just mean you can't build with Qt6? Or is th
Le 02/03/2023 à 17:41, Jean-Marc Lasgouttes a écrit :
Luckily it seems that GuiKeySymbol is the only code that uses QTextCodec.
Luckily enough, the code in there is inside #if 0 ... #endif :)
JMarc
--
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-dev
Le 02/03/2023 à 23:10, Stephan Witt a écrit :
Am 02.03.2023 um 22:44 schrieb Richard Kimberly Heck :
On 3/2/23 12:29, Stephan Witt wrote:
ATM, Qt6 is unusable on Mac because of bug 12641. :(
Does this just mean you can't build with Qt6? Or is this a blocker for release?
No, this means I c
Am 02.03.2023 um 22:44 schrieb Richard Kimberly Heck :
>
> On 3/2/23 12:29, Stephan Witt wrote:
>>
>> ATM, Qt6 is unusable on Mac because of bug 12641. :(
>
> Does this just mean you can't build with Qt6? Or is this a blocker for
> release?
No, this means I can build both with Qt5 or Qt6.
But
On 3/2/23 12:29, Stephan Witt wrote:
ATM, Qt6 is unusable on Mac because of bug 12641. :(
Does this just mean you can't build with Qt6? Or is this a blocker for
release?
Riki
--
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel
On Thu, Mar 02, 2023 at 03:57:38PM +0100, Jean-Marc Lasgouttes wrote:
Le 20/02/2023 à 17:47, Jean-Marc Lasgouttes a écrit :
What I do not know is whether we can get rid of QtCore5Compat
library. Is it useful for anything beyond QRegExp?
Enrico, Stephan Kornel, do you know something about need
Am 02.03.2023 um 15:57 schrieb Jean-Marc Lasgouttes :
>
> Le 20/02/2023 à 17:47, Jean-Marc Lasgouttes a écrit :
>> Le 13/02/2023 à 21:29, Richard Kimberly Heck a écrit :
> Indeed! So we should get rid of QRegexp now.
Riki, would that be OK? What I have in mind is that whatever bug w
Le 02/03/2023 à 17:17, Scott Kostyshak a écrit :
With CMake build I get
/usr2/src/lyx/lyx-git/src/frontends/qt/GuiKeySymbol.cpp:28:10: fatal error:
QTextCodec:
No such file or directory 28 | #include
| ^~~~
compilation terminated.
if I remove the QtCore5Compat parts.
On Wed, Feb 22, 2023 at 11:34:49AM +0100, Kornel Benko wrote:
> Am Mon, 20 Feb 2023 17:47:29 +0100
> schrieb Jean-Marc Lasgouttes :
>
> > Le 13/02/2023 à 21:29, Richard Kimberly Heck a écrit :
> > >>> Indeed! So we should get rid of QRegexp now.
> > >>
> > >> Riki, would that be OK? What I have
Le 20/02/2023 à 17:47, Jean-Marc Lasgouttes a écrit :
Le 13/02/2023 à 21:29, Richard Kimberly Heck a écrit :
Indeed! So we should get rid of QRegexp now.
Riki, would that be OK? What I have in mind is that whatever bug with
this newer code will be found earlier if more users are running it.
Am Mon, 20 Feb 2023 17:47:29 +0100
schrieb Jean-Marc Lasgouttes :
> Le 13/02/2023 à 21:29, Richard Kimberly Heck a écrit :
> >>> Indeed! So we should get rid of QRegexp now.
> >>
> >> Riki, would that be OK? What I have in mind is that whatever bug with
> >> this newer code will be found earlie
Le 13/02/2023 à 21:29, Richard Kimberly Heck a écrit :
Indeed! So we should get rid of QRegexp now.
Riki, would that be OK? What I have in mind is that whatever bug with
this newer code will be found earlier if more users are running it.
Yes, fine with me.
I have been waiting to talk about
On 2/13/23 16:17, Scott Kostyshak wrote:
On Mon, Feb 13, 2023 at 10:03:00PM +0100, Jean-Marc Lasgouttes wrote:
Le 13/02/2023 à 21:29, Richard Kimberly Heck a écrit :
I have been waiting to talk about next steps until we have some idea
what to do about the shortcut problem on OSX. That seems a l
On Mon, Feb 13, 2023 at 10:03:00PM +0100, Jean-Marc Lasgouttes wrote:
> Le 13/02/2023 à 21:29, Richard Kimberly Heck a écrit :
> > > Riki, would that be OK? What I have in mind is that whatever bug
> > > with this newer code will be found earlier if more users are running
> > > it.
> >
> > Yes, fi
Le 13/02/2023 à 21:29, Richard Kimberly Heck a écrit :
Riki, would that be OK? What I have in mind is that whatever bug with
this newer code will be found earlier if more users are running it.
Yes, fine with me.
OK, thanks.
I have been waiting to talk about next steps until we have some idea
On 2/13/23 08:51, Jean-Marc Lasgouttes wrote:
Le 13/02/2023 à 14:47, Jean-Marc Lasgouttes a écrit :
No problem. I changed already long time ago to use
QRegularExpression only in lyxfind.cpp.
Indeed! So we should get rid of QRegexp now.
Riki, would that be OK? What I have in mind is that what
Le 13/02/2023 à 14:47, Jean-Marc Lasgouttes a écrit :
No problem. I changed already long time ago to use QRegularExpression
only in lyxfind.cpp.
Indeed! So we should get rid of QRegexp now.
Riki, would that be OK? What I have in mind is that whatever bug with
this newer code will be found ea
Le 13/02/2023 à 13:07, Kornel Benko a écrit :
Am Mon, 13 Feb 2023 12:16:23 +0100
schrieb Jean-Marc Lasgouttes :
Le 13/02/2023 à 12:11, Jean-Marc Lasgouttes a écrit :
This compiles fine, but I'd rather wait for Kornel, who is our local
QRegExp expert.
From what I have seen with a quick sear
Am Mon, 13 Feb 2023 12:16:23 +0100
schrieb Jean-Marc Lasgouttes :
> Le 13/02/2023 à 12:11, Jean-Marc Lasgouttes a écrit :
> > This compiles fine, but I'd rather wait for Kornel, who is our local
> > QRegExp expert.
>
> From what I have seen with a quick search, some changes are needed to
> m
Le 13/02/2023 à 12:11, Jean-Marc Lasgouttes a écrit :
This compiles fine, but I'd rather wait for Kornel, who is our local
QRegExp expert.
From what I have seen with a quick search, some changes are needed to
make it compile, but mostly it is search and replace.
I did not find warnings about
Le 13/02/2023 à 11:58, Jean-Marc Lasgouttes a écrit :
Le 12/02/2023 à 22:04, Scott Kostyshak a écrit :
On Sun, Feb 12, 2023 at 09:35:19PM +0100, Jean-Marc Lasgouttes wrote:
Le 12/02/2023 à 21:08, Scott Kostyshak a écrit :
Master branch
I see. Indeed it seems there's still instances of it. I
Le 12/02/2023 à 22:04, Scott Kostyshak a écrit :
On Sun, Feb 12, 2023 at 09:35:19PM +0100, Jean-Marc Lasgouttes wrote:
Le 12/02/2023 à 21:08, Scott Kostyshak a écrit :
Master branch
I see. Indeed it seems there's still instances of it. I wonder if in
earlier Qt 6 versions it was a warning so
On Sun, Feb 12, 2023 at 09:35:19PM +0100, Jean-Marc Lasgouttes wrote:
> Le 12/02/2023 à 21:08, Scott Kostyshak a écrit :
> > > Master branch
> >
> > I see. Indeed it seems there's still instances of it. I wonder if in
> > earlier Qt 6 versions it was a warning so that is why it used to work?
>
>
Le 12/02/2023 à 21:08, Scott Kostyshak a écrit :
Master branch
I see. Indeed it seems there's still instances of it. I wonder if in
earlier Qt 6 versions it was a warning so that is why it used to work?
Is there a reason why we could not get rid of QRegExp now that Qt4 is gone?
JMarc
--
lyx
On Sun, Feb 12, 2023 at 08:54:48PM +0100, Lorenzo Bertini wrote:
> Il 12/02/23 20:53, Scott Kostyshak ha scritto:
> > On Sun, Feb 12, 2023 at 08:46:31PM +0100, Lorenzo Bertini wrote:
> > > Dear list,
> > >
> > > trying to compile with --enable-qt6 gives the following error:
> > >
> > > > qstring_
Il 12/02/23 20:53, Scott Kostyshak ha scritto:
On Sun, Feb 12, 2023 at 08:46:31PM +0100, Lorenzo Bertini wrote:
Dear list,
trying to compile with --enable-qt6 gives the following error:
qstring_helpers.cpp:21:10: fatal error: QRegExp: File o directory non esistente
21 | #include
|
On Sun, Feb 12, 2023 at 08:46:31PM +0100, Lorenzo Bertini wrote:
> Dear list,
>
> trying to compile with --enable-qt6 gives the following error:
>
> > qstring_helpers.cpp:21:10: fatal error: QRegExp: File o directory non
> > esistente
> >21 | #include
> > | ^
>
> In
Dear list,
trying to compile with --enable-qt6 gives the following error:
qstring_helpers.cpp:21:10: fatal error: QRegExp: File o directory non esistente
21 | #include
| ^
In the page https://doc.qt.io/qt-6/qregexp.html it says:
This class is deprecated in Qt 6. P
35 matches
Mail list logo
