Re: Patch for 3381

2007-03-30 Thread younes . a
Quoting Richard Heck <[EMAIL PROTECTED]>: > > So is the suggestion that I should make the check with #if? If so, can > someone remind me how to do this? I.e, what the QT_VERSION syntax is? http://doc.trolltech.com/4.1/qtglobal.html#QT_VERSION #if QT_VERSION == 0x040203 ... #endif

Re: Patch for 3381

2007-03-30 Thread Richard Heck
So is the suggestion that I should make the check with #if? If so, can someone remind me how to do this? I.e, what the QT_VERSION syntax is? Richard [EMAIL PROTECTED] wrote: > Quoting Jean-Marc Lasgouttes <[EMAIL PROTECTED]>: > > >>> "younes" == younes a <[EMAIL PROTECTED]> writes: >>

Re: Patch for 3381

2007-03-30 Thread younes . a
Quoting Jean-Marc Lasgouttes <[EMAIL PROTECTED]>: > > "younes" == younes a <[EMAIL PROTECTED]> writes: > > >> There are many places where we assume that we know it. I would not > >> care about that unless there appears to be a real need. Currently > >> we distribute qt with LyX in windows and

Re: Patch for 3381

2007-03-29 Thread Jean-Marc Lasgouttes
> "younes" == younes a <[EMAIL PROTECTED]> writes: >> There are many places where we assume that we know it. I would not >> care about that unless there appears to be a real need. Currently >> we distribute qt with LyX in windows and OS X, and linux uses the >> system Qt, which is not suppose

Re: Patch for 3381

2007-03-29 Thread younes . a
Quoting Jean-Marc Lasgouttes <[EMAIL PROTECTED]>: > > "Richard" == Richard Heck <[EMAIL PROTECTED]> writes: > > > Or maybe better: Is there any way to check if we're running > > under 4.2.3, > > > I think you can use this : #if QT_VERSION == 0x040203 ... #endif > > Richar

Re: Patch for 3381

2007-03-29 Thread Jean-Marc Lasgouttes
> "Richard" == Richard Heck <[EMAIL PROTECTED]> writes: > Or maybe better: Is there any way to check if we're running > under 4.2.3, > I think you can use this : #if QT_VERSION == 0x040203 ... #endif Richard> But I think it needs to be a run-time check... >> Why a run-

Re: Patch for 3381

2007-03-29 Thread Richard Heck
Or maybe better: Is there any way to check if we're running under 4.2.3, >>> I think you can use this : #if QT_VERSION == 0x040203 ... #endif >>> > Richard> But I think it needs to be a run-time check... > > Why a run-time check? > Because if we're compiling a bin

Re: Patch for 3381

2007-03-29 Thread Jean-Marc Lasgouttes
> "Richard" == Richard Heck <[EMAIL PROTECTED]> writes: Richard> Abdelrazak Younes wrote: >> Richard Heck wrote: >>> Or maybe better: Is there any way to check if we're running under >>> 4.2.3, >> I think you can use this : #if QT_VERSION == 0x040203 ... #endif Richard> But I think it needs to

Re: Patch for 3381

2007-03-29 Thread Andre Poenitz
On Thu, Mar 29, 2007 at 03:59:36PM -0400, Richard Heck wrote: > > The attached patch resolves bug 3381. I am not so much suggesting it at > this point as just asking about it. It needs to be tested on a variety > of systems, in particular with different versions of QT4, before any > further action

Re: Patch for 3381

2007-03-29 Thread Abdelrazak Younes
Richard Heck wrote: Abdelrazak Younes wrote: Richard Heck wrote: Or maybe better: Is there any way to check if we're running under 4.2.3, I think you can use this : #if QT_VERSION == 0x040203 ... #endif But I think it needs to be a run-time check... In : const char * qVersion ()

Re: Patch for 3381

2007-03-29 Thread Richard Heck
Abdelrazak Younes wrote: > Richard Heck wrote: >> Or maybe better: Is there any way to check if we're running under 4.2.3, > I think you can use this : > #if QT_VERSION == 0x040203 > ... > #endif But I think it needs to be a run-time check... rh -- ===

Re: Patch for 3381

2007-03-29 Thread Abdelrazak Younes
Richard Heck wrote: The attached patch resolves bug 3381. I am not so much suggesting it at this point as just asking about it. It needs to be tested on a variety of systems, in particular with different versions of QT4, before any further action can be taken. I've posted a message to Trolltech t

Patch for 3381

2007-03-29 Thread Richard Heck
The attached patch resolves bug 3381. I am not so much suggesting it at this point as just asking about it. It needs to be tested on a variety of systems, in particular with different versions of QT4, before any further action can be taken. I've posted a message to Trolltech telling them about thi