Re: Patch for 3144

2007-03-27 Thread Abdelrazak Younes
Abdelrazak Younes wrote: Bo Peng wrote: Also, I reopened the bug for the reason described in bugzilla. OK but maybe this is a bug of checkInsetHit() instead? Yes, I think the correct solution is to rewrite checkInsetHit() so that it descend recursively and give the innermost inset. Then,

Re: Patch for 3144

2007-03-27 Thread Abdelrazak Younes
Bo Peng wrote: Hum, then it is probably better to put it inside moveToPosition(), isn't it? Yes, although moveToPosition is used to update bookmarks Do you really need to move the cursor to save a bookmark? when a buffer is closed, so no change of font is needed in that case. (It does not m

Re: Patch for 3144

2007-03-27 Thread Bo Peng
Hum, then it is probably better to put it inside moveToPosition(), isn't it? Yes, although moveToPosition is used to update bookmarks when a buffer is closed, so no change of font is needed in that case. (It does not matter though.) Also, I reopened the bug for the reason described in bugzilla.

Re: Patch for 3144

2007-03-27 Thread Abdelrazak Younes
Bo Peng wrote: Ahah Bo, this one's your fault (partially) ;-) They are both mine. Anyway, moveToPosition is called also in the case of bookmark-goto, Should we set font after line 1736 of lyxfunc.C? Hum, then it is probably better to put it inside moveToPosition(), isn't it? Abdel.

Re: Patch for 3144

2007-03-27 Thread Bo Peng
Ahah Bo, this one's your fault (partially) ;-) They are both mine. Anyway, moveToPosition is called also in the case of bookmark-goto, Should we set font after line 1736 of lyxfunc.C? Bo

Re: Patch for 3144

2007-03-27 Thread Abdelrazak Younes
Richard Heck wrote: Abdelrazak Younes wrote: Richard Heck wrote: Abdelrazak Younes wrote: 3144 text style ignored in many cases Patch for 3144 attached. Ahah Bo, this one's your fault (partially) ;-) Good catch Richard, thanks a lot! Do you have SVN write access? I guess not...

Patch for 3144

2007-03-27 Thread Richard Heck
Abdelrazak Younes wrote: > Richard Heck wrote: >> Abdelrazak Younes wrote: >>> 3144 text style ignored in many cases Patch for 3144 attached. Richard -- == Richard G Heck, Jr Professor of Philosophy Bro