Re: Patch: text-mode table split-above-row functionality

2010-03-10 Thread Manoj Rajagopalan
On Wednesday 10 March 2010 08:10:37 am Vincent van Ravesteijn - TNW wrote: > I don't like the fact that an Inset is inserting new insets and > inserting paragraph breaks outside this table. To my feeling this > cur should be const for all cursorslices outside the inset. > >> > >>

Re: Patch: text-mode table split-above-row functionality

2010-03-10 Thread Jean-Marc Lasgouttes
Le 10/03/2010 14:10, Vincent van Ravesteijn - TNW a écrit : That's probably solved in Text3.cpp:dissolveInset(). Yes. Would it be a good idea to have a LFUN_INSET_SPLIT and LFUN_INSET_JOIN anyway (especially if we think about the TBM, yes.. Let's drop its name again). What would make it a

RE: Patch: text-mode table split-above-row functionality

2010-03-10 Thread Vincent van Ravesteijn - TNW
I don't like the fact that an Inset is inserting new insets and inserting paragraph breaks outside this table. To my feeling this cur should be const for all cursorslices outside the inset. >> >> Jmarc.. Do you have an opinion on this ? > >I do not like it either, but then I do not

Re: Patch: text-mode table split-above-row functionality

2010-03-10 Thread Jean-Marc Lasgouttes
Le 10/03/2010 13:54, Vincent van Ravesteijn - TNW a écrit : I don't like the fact that an Inset is inserting new insets and inserting paragraph breaks outside this table. To my feeling this cur should be const for all cursorslices outside the inset. Jmarc.. Do you have an opinion on this ? I

RE: Patch: text-mode table split-above-row functionality

2010-03-10 Thread Vincent van Ravesteijn - TNW
>> I don't like the fact that an Inset is inserting new insets and >> inserting paragraph breaks outside this table. To my feeling this cur >> should be const for all cursorslices outside the inset. >> >> Vincent > Jmarc.. Do you have an opinion on this ? Vincent

Re: Patch: text-mode table split-above-row functionality

2010-03-01 Thread Manoj Rajagopalan
On Monday 01 March 2010 11:57:43 am Vincent van Ravesteijn - TNW wrote: > >Hi lyx-devel, > > > > Attaching patch (created using svn diff within src/insets/) for > > review/comments. > > >Based on this I can submit a patch that includes split-below-row, > > split-before-column, > > >and split-a

RE: Patch: text-mode table split-above-row functionality

2010-03-01 Thread Vincent van Ravesteijn - TNW
>Hi lyx-devel, > > Attaching patch (created using svn diff within src/insets/) for review/comments. >Based on this I can submit a patch that includes split-below-row, split-before-column, >and split-after-column. > I don't like the fact that an Inset is inserting new insets and inserting paragr

Patch: text-mode table split-above-row functionality

2010-03-01 Thread Manoj Rajagopalan
Hi lyx-devel, Attaching patch (created using svn diff within src/insets/) for review/comments. Based on this I can submit a patch that includes split-below-row, split-before-column, and split-after-column. To test this feature, create and populate a table, enter any cell, and enter the fo