Jean-Marc Lasgouttes wrote:
> Le 07/04/2011 20:35, Stephan Witt a écrit :
>> Thanks. New patch attached.
>
> Looks much better to me (especially the comments).
ok, go on. pavel
Le 07/04/2011 20:35, Stephan Witt a écrit :
Thanks. New patch attached.
Looks much better to me (especially the comments).
JMarc
Le 08/04/2011 08:55, Jürgen Spitzmüller a écrit :
Jean-Marc Lasgouttes wrote:
I think hyphen and commas are in the class of characters that are part
of the word only when there is stuff on their right and on their left.
The case why this test was introduced is that stems like "-bar" and "foo-"
Am 08.04.2011 um 08:59 schrieb Jürgen Spitzmüller:
> Stephan Witt wrote:
>> +bool Paragraph::isHardHyphenOrQuote(pos_type pos) const
>
> Note that the ' character here is not a quote but an apostrophe (we do not
> want to pass single quotation marks to the spell checker, but we do pass
> apostr
Stephan Witt wrote:
> +bool Paragraph::isHardHyphenOrQuote(pos_type pos) const
Note that the ' character here is not a quote but an apostrophe (we do not
want to pass single quotation marks to the spell checker, but we do pass
apostrophes)
Jürgen
Jean-Marc Lasgouttes wrote:
> I think hyphen and commas are in the class of characters that are part
> of the word only when there is stuff on their right and on their left.
The case why this test was introduced is that stems like "-bar" and "foo-" are
to be passed with the hyphen to the spellc
Am 07.04.2011 um 14:03 schrieb Abdelrazak Younes:
> On 04/06/2011 05:19 PM, Stephan Witt wrote:
>> The last changes regarding isWordSeparator and hard hyphens have a
>> drawback...
>> Now the single dash enclosed by white space is treated as a single word and
>> the
>> spell check marks it red -
On 04/06/2011 05:19 PM, Stephan Witt wrote:
The last changes regarding isWordSeparator and hard hyphens have a drawback...
Now the single dash enclosed by white space is treated as a single word and the
spell check marks it red - I'd rate this as a regression.
The attached patch should fix that.
Le 07/04/2011 12:47, Stephan Witt a écrit :
In principle you're right.
But then the method "Paragraph::isWordSeparator(pos_type pos)" did it wrong
since ages then.
Definitely :) I even suspect we have an open bug about it.
I cannot imagine a patch that provides an implementation of the "moz
Am 07.04.2011 um 12:29 schrieb Jean-Marc Lasgouttes:
> Le 07/04/2011 11:11, Stephan Witt a écrit :
>> What exactly looks weird?
>> The test for hard hyphen altogether or the test for '-' or for space around
>> it
>> or some other implementation detail?
>
> The method that tests for the standalon
Le 07/04/2011 11:11, Stephan Witt a écrit :
What exactly looks weird?
The test for hard hyphen altogether or the test for '-' or for space around it
or some other implementation detail?
The method that tests for the standalone hyphen seems complicated to me
and hard-codes one particular case.
Le 06/04/11 17:19, Stephan Witt a écrit :
The last changes regarding isWordSeparator and hard hyphens have a drawback...
Now the single dash enclosed by white space is treated as a single word and the
spell check marks it red - I'd rate this as a regression.
The attached patch should fix that. O
Stephan Witt wrote:
> The last changes regarding isWordSeparator and hard hyphens have a drawback...
> Now the single dash enclosed by white space is treated as a single word and
> the
> spell check marks it red - I'd rate this as a regression.
>
> The attached patch should fix that. Ok to apply?
The last changes regarding isWordSeparator and hard hyphens have a drawback...
Now the single dash enclosed by white space is treated as a single word and the
spell check marks it red - I'd rate this as a regression.
The attached patch should fix that. Ok to apply?
Stephan
Index: src/Paragraph.h
14 matches
Mail list logo
