Re: No reload after VC->cancel

2008-11-24 Thread Jean-Marc Lasgouttes
Vincent van Ravesteijn <[EMAIL PROTECTED]> writes: > -void LyXVC::registrer() > +bool LyXVC::registrer() Is this strange name a typo, or is it because register is a reserved word? LyXVC::add might be an alternative... JMarc

Re: No reload after VC->cancel

2008-11-23 Thread Pavel Sanda
Vincent van Ravesteijn wrote: > Pavel, > > Is there a good reason to reload the buffer after the user presses cancel > in the VC->register dialog ? no, just reminder from old api. > Would the attached patch make sense ? yes, its step in a good direction. if we don't solve the reload crash meanw

Re: No reload after VC->cancel

2008-11-23 Thread Konrad Hofbauer
Vincent van Ravesteijn wrote: Is there a good reason to reload the buffer after the user presses cancel in the VC->register dialog ? I don't know, but -- probably unrelated -- if the document has unsaved changes, VC->register asks to save the document first. /Konrad

No reload after VC->cancel

2008-11-23 Thread Vincent van Ravesteijn
Pavel, Is there a good reason to reload the buffer after the user presses cancel in the VC->register dialog ? Would the attached patch make sense ? Vincent Index: src/LyXFunc.cpp === --- src/LyXFunc.cpp (revision 27632) +++ s