Re: [RFC][PATCH] native file dialogs

2018-03-21 Thread Jean-Marc Lasgouttes
Le 19/03/2018 à 17:29, Richard Kimberly Heck a écrit : Yes, I'd guess 2.3.2. It's a reasonably big change. Presumably packagers will have to decide how to handle it, too. Good, it is in 2.3.2-staging now. JMarc

Re: [RFC][PATCH] native file dialogs

2018-03-19 Thread Richard Kimberly Heck
On 03/19/2018 11:57 AM, Jean-Marc Lasgouttes wrote: > Le 19/03/2018 à 15:51, Jürgen Spitzmüller a écrit : >> Am Montag, den 19.03.2018, 15:03 +0100 schrieb Jean-Marc Lasgouttes: I would not be opposed to a backport. >>> >>> As it is with native dialogs for everyone by default? >> >> Yes. > > R

Re: [RFC][PATCH] native file dialogs

2018-03-19 Thread Jean-Marc Lasgouttes
Le 19/03/2018 à 15:51, Jürgen Spitzmüller a écrit : Am Montag, den 19.03.2018, 15:03 +0100 schrieb Jean-Marc Lasgouttes: I would not be opposed to a backport. As it is with native dialogs for everyone by default? Yes. Riki, what do you think about it? Is it 2.3.2 stuff? I guess it will ha

Re: [RFC][PATCH] native file dialogs

2018-03-19 Thread Jürgen Spitzmüller
Am Montag, den 19.03.2018, 15:03 +0100 schrieb Jean-Marc Lasgouttes: > > I would not be opposed to a backport. > > As it is with native dialogs for everyone by default? Yes. Jürgen > > JMarc signature.asc Description: This is a digitally signed message part

Re: [RFC][PATCH] native file dialogs

2018-03-19 Thread Jean-Marc Lasgouttes
Le 19/03/2018 à 14:40, Jürgen Spitzmüller a écrit : Am Montag, den 19.03.2018, 11:52 +0100 schrieb Jean-Marc Lasgouttes: It is in now. Works here. I am not sure what we want wrt 2.3.x. I would not be opposed to a backport. As it is with native dialogs for everyone by default? JMarc

Re: [RFC][PATCH] native file dialogs

2018-03-19 Thread Jürgen Spitzmüller
Am Montag, den 19.03.2018, 11:52 +0100 schrieb Jean-Marc Lasgouttes: > It is in now. Works here. > I am not sure what we want wrt 2.3.x. I would not be opposed to a backport. Jürgen > > JMarc signature.asc Description: This is a digitally signed message part

Re: [RFC][PATCH] native file dialogs

2018-03-19 Thread Jean-Marc Lasgouttes
Le 14/03/2018 à 12:06, Kornel Benko a écrit : Only if it affects previous lyx-versions IMHO. Since lyx ignores (with warning) unknown settings, it should not be needed. It is in now. I am not sure what we want wrt 2.3.x. JMarc

Re: [RFC][PATCH] native file dialogs

2018-03-14 Thread Kornel Benko
Am Mittwoch, 14. März 2018 11:36:24 CET schrieb Jean-Marc Lasgouttes : > Le 10/03/2018 à 11:17, Kornel Benko a écrit : > > I'd say, now is the right time to commit the proposed patch. Having > > different defaults for linux and Mac/Windows can be done in configure. > > Let's apply for master firs

Re: [RFC][PATCH] native file dialogs

2018-03-14 Thread Jean-Marc Lasgouttes
Le 10/03/2018 à 11:17, Kornel Benko a écrit : I'd say, now is the right time to commit the proposed patch. Having different defaults for linux and Mac/Windows can be done in configure. Let's apply for master first. A question: if I do not intend to add pref update code, do I have to update the

Re: [RFC][PATCH] native file dialogs

2018-03-10 Thread Kornel Benko
Am Donnerstag, 1. Februar 2018 08:22:30 CET schrieb Guenter Milde : > On 2018-01-31, Jürgen Spitzmüller wrote: > > Am Mittwoch, den 31.01.2018, 11:00 +0100 schrieb Jean-Marc Lasgouttes: > >> Le 31/01/2018 à 08:20, Jürgen Spitzmüller a écrit : > ... > > >> > The nice thing about the buttons is tha

Re: [RFC][PATCH] native file dialogs

2018-02-01 Thread Guenter Milde
On 2018-01-31, Jürgen Spitzmüller wrote: > Am Mittwoch, den 31.01.2018, 11:00 +0100 schrieb Jean-Marc Lasgouttes: >> Le 31/01/2018 à 08:20, Jürgen Spitzmüller a écrit : ... >> > The nice thing about the buttons is that they only occur when it >> > makes >> > sense. And remember we do not only hav

Re: [RFC][PATCH] native file dialogs

2018-02-01 Thread Guenter Milde
ought about it sometimes is the removal of the > native file dialogs and the placement in the Help menu of an entry that > would allow to open the file picker for Examples. Because, at least to > me, Examples conceptually belong to Help and not to File. Agreed. See also https://www.lyx.org/tr

Re: [RFC][PATCH] native file dialogs

2018-01-31 Thread Jürgen Spitzmüller
Am Mittwoch, den 31.01.2018, 11:00 +0100 schrieb Jean-Marc Lasgouttes: > Le 31/01/2018 à 08:20, Jürgen Spitzmüller a écrit : > > > Or set the default to use native everywhere and let experienced > > > people override that. > > > > Yes. But then, I think, you can also drop it altogether. > > Just

Re: [RFC][PATCH] native file dialogs

2018-01-31 Thread Jean-Marc Lasgouttes
Le 31/01/2018 à 08:20, Jürgen Spitzmüller a écrit : Or set the default to use native everywhere and let experienced people override that. Yes. But then, I think, you can also drop it altogether. Just because I propose to change the unix default? We need to have a cross platform strategy. The

Re: [RFC][PATCH] native file dialogs

2018-01-30 Thread Jürgen Spitzmüller
Am Dienstag, den 30.01.2018, 23:24 +0100 schrieb Jean-Marc Lasgouttes: > Nice, so to speak. To be frank, I have no interest in reworking 20+ > dialogs to give them nice buttons. But this is of course desirable > in > the long term. I agree. > > > 1/ apply this patch, maybe with a default of "fa

Re: [RFC][PATCH] native file dialogs

2018-01-30 Thread Andrew Parsloe
On 31/01/2018 4:41 a.m., Jean-Marc Lasgouttes wrote: Le 30/01/2018 à 16:33, José Abílio Matos a écrit : One option that I thought about it sometimes is the removal of the native file dialogs and the placement in the Help menu of an entry that would allow to open the file picker for Examples

Re: [RFC][PATCH] native file dialogs

2018-01-30 Thread Jean-Marc Lasgouttes
Le 30/01/2018 à 19:32, Jürgen Spitzmüller a écrit : The following patch allows to select the type of file dialog at runtime (see ticket http://www.lyx.org/trac/ticket/11003 for why I am doing that). Nice. Nice, so to speak. To be frank, I have no interest in reworking 20+ dialogs to give the

Re: [RFC][PATCH] native file dialogs

2018-01-30 Thread Jürgen Spitzmüller
Am Dienstag, den 30.01.2018, 15:01 +0100 schrieb Jean-Marc Lasgouttes: > Currently native file dialogs are used on windows and Mac. It is > possible to select them on unix with cmake, but not autoconf. > > The following patch allows to select the type of file dialog at > runtime

Re: [RFC][PATCH] native file dialogs

2018-01-30 Thread Scott Kostyshak
On Tue, Jan 30, 2018 at 02:01:54PM +, Jean-Marc Lasgouttes wrote: > Does somebody use the custom Documents/Examples buttons? Are they really > needed? I use them, but the cost of forgetting that they are not available on all platforms always comes back to bite me when I give a presentation on

Re: [RFC][PATCH] native file dialogs

2018-01-30 Thread José Abílio Matos
On Tuesday, 30 January 2018 15.41.28 WET Jean-Marc Lasgouttes wrote: > You mean _custom_ file dialogs, right? > > JMarc Sure. My mistake. :-) -- José Abílio

Re: [RFC][PATCH] native file dialogs

2018-01-30 Thread Jean-Marc Lasgouttes
Le 30/01/2018 à 16:33, José Abílio Matos a écrit : One option that I thought about it sometimes is the removal of the native file dialogs and the placement in the Help menu of an entry that would allow to open the file picker for Examples. Because, at least to me, Examples conceptually belong

Re: [RFC][PATCH] native file dialogs

2018-01-30 Thread José Abílio Matos
e users list. If not for other reason for the fact that most of us on this list are tainted. One option that I thought about it sometimes is the removal of the native file dialogs and the placement in the Help menu of an entry that would allow to open the file picker for Examples. Because

Re: [RFC][PATCH] native file dialogs

2018-01-30 Thread Pavel Sanda
Jean-Marc Lasgouttes wrote: > Does somebody use the custom Documents/Examples buttons? Are they really > needed? I use them sometimes, but can't say whether it's because of real usage or devel activities... P

Re: [RFC][PATCH] native file dialogs

2018-01-30 Thread Jean-Pierre Chrétien
Le 30/01/2018 à 15:01, Jean-Marc Lasgouttes a écrit : Does somebody use the custom Documents/Examples buttons? Are they really needed? I use these two quite often (more frequently examples), but my use of LyX is mostly for translations. -- Jean-Pierre

[RFC][PATCH] native file dialogs

2018-01-30 Thread Jean-Marc Lasgouttes
Currently native file dialogs are used on windows and Mac. It is possible to select them on unix with cmake, but not autoconf. The following patch allows to select the type of file dialog at runtime (see ticket http://www.lyx.org/trac/ticket/11003 for why I am doing that). Currently all

Re: Native file dialogs

2006-12-29 Thread Peter Kümmel
Georg Baum wrote: > On Friday 29 December 2006 20:56, Peter Kümmel wrote: >> Is there a reason not to use the native >> file dialogs on Windows? > > Yes: The extra buttons for examples and documents. We discussed this several OK... > times already. We got complaints

Re: Native file dialogs

2006-12-29 Thread Edwin Leuven
Georg Baum wrote: > We got complaints from OS X users that the > file dialog looks ugly. when i added the buttons (and got a different result than with the previous qt) i had an exchange with trolltech about this. the result is that they are "aware" of it: http://www.trolltech.com/developer/t

Re: Native file dialogs

2006-12-29 Thread Georg Baum
On Friday 29 December 2006 20:56, Peter Kümmel wrote: > Is there a reason not to use the native > file dialogs on Windows? Yes: The extra buttons for examples and documents. We discussed this several times already. We got complaints from OS X users that the file dialog looks ugly. Af

Re: Native file dialogs

2006-12-29 Thread Abdelrazak Younes
Peter Kümmel wrote: Is there a reason not to use the native file dialogs on Windows? Personally I like our home made file dialog because of the convenient bookmark buttons. The native dialog is really too much... A good compromise would be to use our file dialog for opening or saving LyX

Native file dialogs

2006-12-29 Thread Peter Kümmel
Is there a reason not to use the native file dialogs on Windows? If not, with attached patch they could be enabled. Peter Index: src/frontends/qt4/FileDialog.C === --- src/frontends/qt4/FileDialog.C (revision 16431) +++ src