Re: Missing includes

2024-11-18 Thread Lorenzo Bertini
>From my understanding, this is a standard Qt practice but a semi-non-standard C++ practice. On a forum someone said that all files you include should be ".h" or ".hpp" and meson is picky about this. Notable project that use this technique (which should save some compile time) are Qt and SQLite (wh

Re: Missing includes

2024-11-18 Thread Jean-Marc Lasgouttes
Le 18/11/2024 à 16:15, Lorenzo Bertini a écrit : From my understanding, this is a standard Qt practice but a semi-non- standard C++ practice. On a forum someone said that all files you include should be ".h" or ".hpp" and meson is picky about this. Notable project that use this technique (whic

Re: Missing includes

2024-11-18 Thread Jean-Marc Lasgouttes
Le 18/11/2024 à 15:51, Pavel Sanda a écrit : On Mon, Nov 18, 2024 at 02:26:03PM +0100, Lorenzo Bertini wrote: and are named moc_.cpp. They are then included in .cpp with #include "moc_.cpp". Ah, right. P Is this a standard Qt practice? If yes, meson should have some support for it (I see th

Re: Missing includes

2024-11-18 Thread Pavel Sanda
On Mon, Nov 18, 2024 at 02:26:03PM +0100, Lorenzo Bertini wrote: > and are named moc_.cpp. They are then included in .cpp with > #include "moc_.cpp". Ah, right. P -- lyx-devel mailing list lyx-devel@lists.lyx.org https://lists.lyx.org/mailman/listinfo/lyx-devel

Re: Missing includes

2024-11-18 Thread Lorenzo Bertini
They are the moc generated ones. They are obtained from moc_headers = [ 'Action.h', 'BulletsModule.h', 'CategorizedCombo.h', 'CustomizedWidgets.h', 'DialogView.h', 'DockView.h', 'EmptyTable.h', 'FancyLineEdit.h', 'FindAndReplace.h', 'FloatPlacement.h', 'GuiAbout.h', 'GuiApp

Re: Missing includes

2024-11-18 Thread Pavel Sanda
On Mon, Nov 18, 2024 at 12:36:32PM +0100, Lorenzo Bertini wrote: > Currently, there is no way except hacks to tell meson that some cpp files > are not to be compiled but included. I have opened an issue in their repo. > In the meanwhile let's put the patches on hold. BTW do you have list of these

Re: Missing includes

2024-11-18 Thread Pavel Sanda
nOn Mon, Nov 18, 2024 at 10:04:57AM +0100, Lorenzo Bertini wrote: > I have included everything in the patch. When I look at those errors, the > fix seems like a best practice to me, this is why I'm proposing the > changes. Also, I can't figure how can CMake and Autotools still finish the > build.

Re: Missing includes

2024-11-18 Thread Lorenzo Bertini
Currently, there is no way except hacks to tell meson that some cpp files are not to be compiled but included. I have opened an issue in their repo. In the meanwhile let's put the patches on hold. Lorenzo Il giorno lun 18 nov 2024 alle ore 10:47 Lorenzo Bertini < lorenzobertin...@gmail.com> ha sc

Re: Missing includes

2024-11-18 Thread Lorenzo Bertini
Sorry, it was Clipboard.h instead of GuiClipboard.h. Moreover, I found that ConsoleApplicationPrivate.h does a forward declaration of ConsoleApplication, but uses one of the methods. This required the full declaration of the class, we may need to include ConsoleApplication.h in there. Also, moc_Gu

Re: Missing includes

2024-11-18 Thread Lorenzo Bertini
It has occurred to me that something is wrong with this build because to have multiple definitions of functions, so I must be including things twice, once where I shouldn't. This is probably it. I'll report back once I figure this out. Thanks for the help, Lorenzo Il giorno lun 18 nov 2024 alle o

Re: Missing includes

2024-11-18 Thread Lorenzo Bertini
I'm on GCC 14, Fedora 41. C++ standard is set to C++17. I call it with a meson.build like this: sources = [ 'DockView.cpp', ... ] ui_files = [ 'ui/AboutUi.ui', ... ] moc_headers = [ 'Action.h', ... ] ui_headers = qt_mod.compile_ui(sources: ui_sources) moc_sources = qt_mod.compile_moc(headers: m

Re: Missing includes

2024-11-17 Thread Pavel Sanda
On Sun, Nov 17, 2024 at 12:12:11PM +0100, Lorenzo Bertini wrote: > Dear devs, > when trying to port LyX to yet another build system I found that > src/frontends/GuiClipboard.h is missing and "support/docstring.h", > and GuiSearch.h only "support/docstring.h". I don't exactly know how > autotools m

Missing includes

2024-11-17 Thread Lorenzo Bertini
Dear devs, when trying to port LyX to yet another build system I found that src/frontends/GuiClipboard.h is missing and "support/docstring.h", and GuiSearch.h only "support/docstring.h". I don't exactly know how autotools manages to build anyway, but the files use std::string and docstring without

Re: missing #includes complaints by MSVC 2017

2020-10-24 Thread Pavel Sanda
On Sat, Oct 24, 2020 at 11:10:47AM +0300, Yuriy Skalko wrote: > >Dear LyX developers, > > > >I just tried to compile LyX (commit > >2c1753a5265c59ebd11fc465cdb119ff589ad965) on windows 10 with MSVC 2017 > >toolkit, and encountered compiling errors of the sort: > > > > > > src\DocIterator.h(335):

missing #includes complaints by MSVC 2017

2020-10-24 Thread Yuriy Skalko
Dear LyX developers, I just tried to compile LyX (commit 2c1753a5265c59ebd11fc465cdb119ff589ad965) on windows 10 with MSVC 2017 toolkit, and encountered compiling errors of the sort: src\DocIterator.h(335): error C2039: 'min': is not a member of 'std and another one about std::isspace. It'

missing #includes complaints by MSVC 2017

2020-10-24 Thread Yuriy Skalko
Dear LyX developers, I just tried to compile LyX (commit 2c1753a5265c59ebd11fc465cdb119ff589ad965) on windows 10 with MSVC 2017 toolkit, and encountered compiling errors of the sort: src\DocIterator.h(335): error C2039: 'min': is not a member of 'std Pavel, please check da8b5de97. Should

missing #includes complaints by MSVC 2017

2020-10-23 Thread Panruo Wu
Dear LyX developers, I just tried to compile LyX (commit 2c1753a5265c59ebd11fc465cdb119ff589ad965) on windows 10 with MSVC 2017 toolkit, and encountered compiling errors of the sort: src\DocIterator.h(335): error C2039: 'min': is not a member of 'std and another one about std::isspace. It's

Re: [LyX/master] Add missing includes after change to boost signals2

2016-06-12 Thread Georg Baum
Jean-Marc Lasgouttes wrote: > Le 12/06/2016 12:14, Stephan Witt a écrit : >>> Different structure of headers, just switching between different gcc >>> versions and their accompanied libs is enough to trigger such errors on >>> the same system. >> >> I’m not used to this behavior with other develop

Re: [LyX/master] Add missing includes after change to boost signals2

2016-06-12 Thread Jean-Marc Lasgouttes
Le 12/06/2016 12:14, Stephan Witt a écrit : Different structure of headers, just switching between different gcc versions and their accompanied libs is enough to trigger such errors on the same system. I’m not used to this behavior with other development environment. For example, the docs say

Re: [LyX/master] Add missing includes after change to boost signals2

2016-06-12 Thread Stephan Witt
Am 12.06.2016 um 10:39 schrieb Pavel Sanda : > > Stephan Witt wrote: >> sstream or iostream (as JMarc wrote) because of std::endl. > > But where in the _header_ do you need that? Ok, I misunderstood then. It should go to Server.cpp of course. Stephan > >> I have to admit that I start to mist

Re: [LyX/master] Add missing includes after change to boost signals2

2016-06-12 Thread Pavel Sanda
Stephan Witt wrote: > sstream or iostream (as JMarc wrote) because of std::endl. But where in the _header_ do you need that? > I have to admit that I start to mistrust the GCC-compilers. > I don???t understand why our sources compile on some systems > and not on some other systems. Why do I need

Re: [LyX/master] Add missing includes after change to boost signals2

2016-06-11 Thread Stephan Witt
Am 11.06.2016 um 22:30 schrieb Pavel Sanda : > > Stephan Witt wrote: >> commit e8b15b5f0cd216a342dbcaef7b9e90722bc99fc3 >> Author: Stephan Witt >> Date: Sat Jun 11 09:56:35 2016 +0200 >> >>Add missing includes after change to boost signals2 >> &

Re: [LyX/master] Add missing includes after change to boost signals2

2016-06-11 Thread Jean-Marc Lasgouttes
Le 11/06/2016 22:30, Pavel Sanda a écrit : Stephan Witt wrote: commit e8b15b5f0cd216a342dbcaef7b9e90722bc99fc3 Author: Stephan Witt Date: Sat Jun 11 09:56:35 2016 +0200 Add missing includes after change to boost signals2 diff --git a/src/Server.h b/src/Server.h index 7aecde6..2c1162d

Re: [LyX/master] Add missing includes after change to boost signals2

2016-06-11 Thread Pavel Sanda
Stephan Witt wrote: > commit e8b15b5f0cd216a342dbcaef7b9e90722bc99fc3 > Author: Stephan Witt > Date: Sat Jun 11 09:56:35 2016 +0200 > > Add missing includes after change to boost signals2 > > diff --git a/src/Server.h b/src/Server.h > index 7aecde6..2c1162d 100