Re: Merging features/fix-tex2lyx-tests to master

2015-06-09 Thread Georg Baum
Uwe Stöhr wrote: > Am 31.05.2015 um 22:01 schrieb Georg Baum: > >> I tested that the old LyX file produced correct .tex results, now I see >> that it creates correct .tex results with the new version as well. It did >> not occur to me that both hor_pos "c" and hor_pos "l" in .lyx would >> produce

Re: Merging features/fix-tex2lyx-tests to master

2015-06-09 Thread Georg Baum
Uwe Stöhr wrote: > Am 02.06.2015 um 20:27 schrieb Georg Baum: > >>> tex2lyx -f -roundtrip test-insets.tex >> >> This command looks good. Again, please answer my question: Did you copy >> test-insets.tex somewhere, or did you run this command on the .tex file >> in the git tree? > > I don't under

Re: Merging features/fix-tex2lyx-tests to master

2015-06-08 Thread Uwe Stöhr
Am 31.05.2015 um 22:01 schrieb Georg Baum: I tested that the old LyX file produced correct .tex results, now I see that it creates correct .tex results with the new version as well. It did not occur to me that both hor_pos "c" and hor_pos "l" in .lyx would produce the same .tex output. Why is th

Re: Merging features/fix-tex2lyx-tests to master

2015-06-08 Thread Uwe Stöhr
Am 02.06.2015 um 20:27 schrieb Georg Baum: tex2lyx -f -roundtrip test-insets.tex This command looks good. Again, please answer my question: Did you copy test-insets.tex somewhere, or did you run this command on the .tex file in the git tree? I don't understand what yo mean with git tree. I c

Re: Merging features/fix-tex2lyx-tests to master

2015-06-02 Thread Georg Baum
Uwe Stöhr wrote: > Am 31.05.2015 um 19:06 schrieb Uwe Stöhr: > >>> This might be a tex2lyx bug as well, depending how the reference was >>> created. This is not in 1) since I can reproduce the results in 1) with >>> current tex2lyx but not this one. Uwe, how did you create the reference >>> which

Re: Merging features/fix-tex2lyx-tests to master

2015-06-01 Thread Uwe Stöhr
Am 31.05.2015 um 19:06 schrieb Uwe Stöhr: This might be a tex2lyx bug as well, depending how the reference was created. This is not in 1) since I can reproduce the results in 1) with current tex2lyx but not this one. Uwe, how did you create the reference which does not contain the external inset

Re: Merging features/fix-tex2lyx-tests to master

2015-05-31 Thread Georg Baum
Uwe Stöhr wrote: > Am 31.05.2015 um 15:24 schrieb Georg Baum: > >> 1) tex2lyx bugs >> These are changes which should have never gone into the test references, >> since they hide recently introduced bugs. Uwe, please have a look at the >> diffs and fix the bugs. If you think that some are not bugs

Re: Merging features/fix-tex2lyx-tests to master

2015-05-31 Thread Uwe Stöhr
Am 31.05.2015 um 15:24 schrieb Georg Baum: 1) tex2lyx bugs These are changes which should have never gone into the test references, since they hide recently introduced bugs. Uwe, please have a look at the diffs and fix the bugs. If you think that some are not bugs, please explain why. What? Wh

Re: Merging features/fix-tex2lyx-tests to master

2015-05-31 Thread Kornel Benko
Am Sonntag, 31. Mai 2015 um 15:24:21, schrieb Georg Baum > I want to merge the current status of the features/fix-tex2lyx-tests now to > master, but I am unsure how to do it. I could simply merge it with git, but > then the history of master would contain an ugly revert 201ee24d13 which is > p

Re: Merging features/fix-tex2lyx-tests to master

2015-05-31 Thread Jürgen Spitzmüller
2015-05-31 15:24 GMT+02:00 Georg Baum: > I want to merge the current status of the features/fix-tex2lyx-tests now to > master, but I am unsure how to do it. I could simply merge it with git, but > then the history of master would contain an ugly revert 201ee24d13 which is > partly undone by later

Merging features/fix-tex2lyx-tests to master

2015-05-31 Thread Georg Baum
Hi, I am now finished with fixing the tex2lyx tests. Unfortunately it took much more time than initially thought. The diffs to current master are attached. The differences can be divided into several categories: 1) tex2lyx bugs These are changes which should have never gone into the test refe