Re: [patch] Re: Lyx crashes with paragraph up.

2007-07-23 Thread Helge Hafting
Bo Peng wrote: Sure it can, one time I had a command sequence that launched LyX, opened the UserGuide, scrolled it to the end, and exit LyX at the end. You can put any LFUN in this command-sequence. and check if lyx crashes, Surely a test program can be made to notice that LyX crashes. Or at

Re: [patch] Re: Lyx crashes with paragraph up.

2007-07-13 Thread Bo Peng
Sure it can, one time I had a command sequence that launched LyX, opened the UserGuide, scrolled it to the end, and exit LyX at the end. You can put any LFUN in this command-sequence. and check if lyx crashes, and if the pasted text is what you cut? I guess the long term goal (?) is having eithe

Re: [patch] Re: Lyx crashes with paragraph up.

2007-07-13 Thread Abdelrazak Younes
Bo Peng wrote: LyX can be scripted too thanks to the LFUNs... Then we need to write a bunch of scripts to convert back and forth, move, select, cut, paste, save/load, new/close window although I do not think lyx can be manipulated like that externally. Sure it can, one time I had a comma

Re: [patch] Re: Lyx crashes with paragraph up.

2007-07-13 Thread Bo Peng
LyX can be scripted too thanks to the LFUNs... Then we need to write a bunch of scripts to convert back and forth, move, select, cut, paste, save/load, new/close window although I do not think lyx can be manipulated like that externally. Bo

Re: [patch] Re: Lyx crashes with paragraph up.

2007-07-13 Thread Abdelrazak Younes
Bo Peng wrote: On 7/13/07, Jürgen Spitzmüller <[EMAIL PROTECTED]> wrote: Abdelrazak Younes wrote: > No, my patch is the right fix and I am responsible for this: in rev > 19040, I eagerly erased two lines (++cur.pit() and --cur.pit()). Well, then put it in again, before I'll release the dogs ;-)

Re: [patch] Re: Lyx crashes with paragraph up.

2007-07-13 Thread Abdelrazak Younes
Bo Peng wrote: Just let me the time to switch my repository to trunk :-) Just to confirm that your patch works. Please put it in. It's in already :-) Abdel.

Re: [patch] Re: Lyx crashes with paragraph up.

2007-07-13 Thread Bo Peng
Just let me the time to switch my repository to trunk :-) Just to confirm that your patch works. Please put it in. Bo

Re: [patch] Re: Lyx crashes with paragraph up.

2007-07-13 Thread Bo Peng
On 7/13/07, Jürgen Spitzmüller <[EMAIL PROTECTED]> wrote: Abdelrazak Younes wrote: > No, my patch is the right fix and I am responsible for this: in rev > 19040, I eagerly erased two lines (++cur.pit() and --cur.pit()). Well, then put it in again, before I'll release the dogs ;-) This makes me

Re: [patch] Re: Lyx crashes with paragraph up.

2007-07-13 Thread Abdelrazak Younes
Jürgen Spitzmüller wrote: Abdelrazak Younes wrote: No, my patch is the right fix and I am responsible for this: in rev 19040, I eagerly erased two lines (++cur.pit() and --cur.pit()). Well, then put it in again, before I'll release the dogs ;-) Just let me the time to switch my repository to

Re: [patch] Re: Lyx crashes with paragraph up.

2007-07-13 Thread Bo Peng
> fix attached. No, my patch is the right fix and I am responsible for this: in rev 19040, I eagerly erased two lines (++cur.pit() and --cur.pit()). I produced exactly the same patch (5s later than you :-) ... please commit if it works. Cheers, Bo

Re: [patch] Re: Lyx crashes with paragraph up.

2007-07-13 Thread Jürgen Spitzmüller
Abdelrazak Younes wrote: > No, my patch is the right fix and I am responsible for this: in rev > 19040, I eagerly erased two lines (++cur.pit() and --cur.pit()). Well, then put it in again, before I'll release the dogs ;-) Jürgen

Re: [patch] Re: Lyx crashes with paragraph up.

2007-07-13 Thread Abdelrazak Younes
Jürgen Spitzmüller wrote: Bo Peng wrote: Open the attached lyx file, move cursor to the end of the second line (actually anywhere with pos > length of previous line). Edit -> paragraph up, lyx crashes. fix attached. No, my patch is the right fix and I am responsible for this: in rev 19040,

Re: [patch] Re: Lyx crashes with paragraph up.

2007-07-13 Thread Jürgen Spitzmüller
Bo Peng wrote: > > fix attached. > > This fixes the crash but I think the correct behavior should be > keeping the cursor in its original paragraph and location, right? That would be Abdel's patch. Jürgen

[PATCH] Re: Lyx crashes with paragraph up.

2007-07-13 Thread Abdelrazak Younes
Jürgen Spitzmüller wrote: Abdelrazak Younes wrote: Obvious candidates for the brown paper bag: http://www.lyx.org/trac/changeset/19057 Unlikely (this affects only LaTeX output). http://www.lyx.org/trac/changeset/19046 Reverting this does not fix the crash. I was wrong, see my other post

Re: [patch] Re: Lyx crashes with paragraph up.

2007-07-13 Thread Bo Peng
On 7/13/07, Jürgen Spitzmüller <[EMAIL PROTECTED]> wrote: Bo Peng wrote: > Open the attached lyx file, move cursor to the end of the second line > (actually anywhere with pos > length of previous line). Edit -> > paragraph up, lyx crashes. fix attached. This fixes the crash but I think the cor

Re: Lyx crashes with paragraph up.

2007-07-13 Thread Bo Peng
I am investigating if there is a quick fix,... and Pavel says it is introduced after rc2. I guess it is something like: P1: len 8 P2: len 20 Cursor: par = 2, pos = 20 after paragraph up P1: len 20 P2: len 8 Cursor: par = 2, pos = 20 Fitcursor fails because pos > len. Looks like cursor needs

[patch] Re: Lyx crashes with paragraph up.

2007-07-13 Thread Jürgen Spitzmüller
Bo Peng wrote: > Open the attached lyx file, move cursor to the end of the second line > (actually anywhere with pos > length of previous line). Edit -> > paragraph up, lyx crashes. fix attached. Jürgen Index: src/Text3.cpp === --- s

Re: Lyx crashes with paragraph up.

2007-07-13 Thread Jürgen Spitzmüller
Abdelrazak Younes wrote: > Obvious candidates for the brown paper bag: > > http://www.lyx.org/trac/changeset/19057 Unlikely (this affects only LaTeX output). > http://www.lyx.org/trac/changeset/19046 Reverting this does not fix the crash. Jürgen

Re: Lyx crashes with paragraph up.

2007-07-13 Thread Abdelrazak Younes
Abdelrazak Younes wrote: Bo Peng wrote: Open the attached lyx file, move cursor to the end of the second line (actually anywhere with pos > length of previous line). Edit -> paragraph up, lyx crashes. Can any one confirm? Works fine with rev. 19044. Wrong, I was using a release build with a

Re: Lyx crashes with paragraph up.

2007-07-13 Thread Abdelrazak Younes
Jürgen Spitzmüller wrote: Bo Peng wrote: Open the attached lyx file, move cursor to the end of the second line (actually anywhere with pos > length of previous line). Edit -> paragraph up, lyx crashes. Can any one confirm? Yes. Please file a bug report. With the frequency of crashes I am ex

Re: Lyx crashes with paragraph up.

2007-07-13 Thread Bo Peng
> Can any one confirm? Yes. Please file a bug report. I am investigating if there is a quick fix,... and Pavel says it is introduced after rc2. Well, obviously, nobody used this function until now. I'm confident that more crashes will come to our attention once 1.5.0 is released. It is not

Re: Lyx crashes with paragraph up.

2007-07-13 Thread Abdelrazak Younes
Bo Peng wrote: Can any one confirm? Confirmed under linux as well. Obvious candidates for the brown paper bag: http://www.lyx.org/trac/changeset/19057 http://www.lyx.org/trac/changeset/19046 #0 0x003dcd22e21d in raise () from /lib64/tls/libc.so.6 #1 0x003dcd22fa1e in abort () fr

Re: Lyx crashes with paragraph up.

2007-07-13 Thread Abdelrazak Younes
Bo Peng wrote: Open the attached lyx file, move cursor to the end of the second line (actually anywhere with pos > length of previous line). Edit -> paragraph up, lyx crashes. Can any one confirm? Works fine with rev. 19044. Abdel.

Re: Lyx crashes with paragraph up.

2007-07-13 Thread Bo Peng
Can any one confirm? Confirmed under linux as well. #0 0x003dcd22e21d in raise () from /lib64/tls/libc.so.6 #1 0x003dcd22fa1e in abort () from /lib64/tls/libc.so.6 #2 0x0096aee1 in lyx::support::abort () at src/support/abort.cpp:25 #3 0x004eda7b in boost::assertion_f

Re: Lyx crashes with paragraph up.

2007-07-13 Thread Pavel Sanda
> Can any one confirm? cant confirm with rc2. can confirm with svn. pavel

Re: Lyx crashes with paragraph up.

2007-07-13 Thread Jürgen Spitzmüller
Bo Peng wrote: > Open the attached lyx file, move cursor to the end of the second line > (actually anywhere with pos > length of previous line). Edit -> > paragraph up, lyx crashes. > > Can any one confirm? Yes. Please file a bug report. > With the frequency of crashes I am experiencing right now

Lyx crashes with paragraph up.

2007-07-13 Thread Bo Peng
Open the attached lyx file, move cursor to the end of the second line (actually anywhere with pos > length of previous line). Edit -> paragraph up, lyx crashes. Can any one confirm? With the frequency of crashes I am experiencing right now, I am wondering if lyx 1.5.0 is really ready. :-( Bo