Re: Link error when compiling with -fsanitize=undefined

2022-01-21 Thread Kornel Benko
Am Thu, 20 Jan 2022 18:47:43 +0100 schrieb Jean-Marc Lasgouttes : > Le 20/01/2022 à 18:16, Scott Kostyshak a écrit : > >> JMarc any objection to Kornel's patch? > > > > Ping to JMarc. > > Go ahead. > > JMarc Committed at 2764ed20. Kornel pgpFnFZWOW5Jy.pgp Description: Digitale S

Re: Link error when compiling with -fsanitize=undefined

2022-01-20 Thread Jean-Marc Lasgouttes
Le 20/01/2022 à 18:16, Scott Kostyshak a écrit : JMarc any objection to Kornel's patch? Ping to JMarc. Go ahead. JMarc -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: Link error when compiling with -fsanitize=undefined

2022-01-20 Thread Scott Kostyshak
On Fri, Nov 05, 2021 at 09:18:05PM -0400, Scott Kostyshak wrote: > On Wed, Sep 22, 2021 at 07:08:48PM +0200, Kornel Benko wrote: > > Am Wed, 22 Sep 2021 10:28:44 +0200 > > schrieb Jean-Marc Lasgouttes : > > > > > Le 21/09/2021 à 16:52, Scott Kostyshak a écrit : > > > >> Some debugging lead to foll

Re: Link error when compiling with -fsanitize=undefined

2021-11-05 Thread Scott Kostyshak
On Wed, Sep 22, 2021 at 07:08:48PM +0200, Kornel Benko wrote: > Am Wed, 22 Sep 2021 10:28:44 +0200 > schrieb Jean-Marc Lasgouttes : > > > Le 21/09/2021 à 16:52, Scott Kostyshak a écrit : > > >> Some debugging lead to following observation: > > >> Each inserted branch add a color to the list. The o

Re: Link error when compiling with -fsanitize=undefined

2021-09-22 Thread Kornel Benko
Am Wed, 22 Sep 2021 10:28:44 +0200 schrieb Jean-Marc Lasgouttes : > Le 21/09/2021 à 16:52, Scott Kostyshak a écrit : > >> Some debugging lead to following observation: > >> Each inserted branch add a color to the list. The original enum defined > >> colors (about > >> 102), last Color_ignore. > >

Re: Link error when compiling with -fsanitize=undefined

2021-09-22 Thread Jean-Marc Lasgouttes
Le 22/09/2021 à 16:04, Scott Kostyshak a écrit : I do have 25+ branches. OK, forget what I wrote ;) JMarc -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: Link error when compiling with -fsanitize=undefined

2021-09-22 Thread Scott Kostyshak
On Wed, Sep 22, 2021 at 10:28:44AM +0200, Jean-Marc Lasgouttes wrote: > Le 21/09/2021 à 16:52, Scott Kostyshak a écrit : > > > Some debugging lead to following observation: > > > Each inserted branch add a color to the list. The original enum defined > > > colors (about > > > 102), last Color_igno

Re: Link error when compiling with -fsanitize=undefined

2021-09-22 Thread Jean-Marc Lasgouttes
Le 21/09/2021 à 16:52, Scott Kostyshak a écrit : Some debugging lead to following observation: Each inserted branch add a color to the list. The original enum defined colors (about 102), last Color_ignore. So each branch will now get colors 103, 104, ..., and so on, so that the original enum (p

Re: Link error when compiling with -fsanitize=undefined

2021-09-21 Thread Scott Kostyshak
On Tue, Sep 21, 2021 at 10:52:34AM -0400, Scott Kostyshak wrote: > I didn't understand how JMarc's suggestion to change the type to int would > solve the (non) issue. I think I understand now: the code just needs to assign some value, it doesn't actually have to correspond to a correct color?

Re: Link error when compiling with -fsanitize=undefined

2021-09-21 Thread Scott Kostyshak
On Mon, Sep 20, 2021 at 06:30:14PM +0200, Kornel Benko wrote: > Am Mon, 20 Sep 2021 11:48:37 +0200 > schrieb Kornel Benko : > > > Am Sun, 19 Sep 2021 20:19:15 -0400 > > schrieb Scott Kostyshak : > > > > > On Sun, Sep 19, 2021 at 08:37:16PM +0200, Kornel Benko wrote: > > > > Am Sun, 19 Sep 2021

Re: Link error when compiling with -fsanitize=undefined

2021-09-20 Thread Kornel Benko
Am Mon, 20 Sep 2021 11:48:37 +0200 schrieb Kornel Benko : > Am Sun, 19 Sep 2021 20:19:15 -0400 > schrieb Scott Kostyshak : > > > On Sun, Sep 19, 2021 at 08:37:16PM +0200, Kornel Benko wrote: > > > Am Sun, 19 Sep 2021 14:15:21 -0400 > > > schrieb Scott Kostyshak : > > > > > > > On Sun, Sep

Re: Link error when compiling with -fsanitize=undefined

2021-09-20 Thread Kornel Benko
Am Sun, 19 Sep 2021 20:19:15 -0400 schrieb Scott Kostyshak : > On Sun, Sep 19, 2021 at 08:37:16PM +0200, Kornel Benko wrote: > > Am Sun, 19 Sep 2021 14:15:21 -0400 > > schrieb Scott Kostyshak : > > > > > On Sun, Sep 19, 2021 at 02:00:33PM +0200, Kornel Benko wrote: > > > > Am Sun, 19 Sep 2021

Re: Link error when compiling with -fsanitize=undefined

2021-09-20 Thread Jean-Marc Lasgouttes
Le 19/09/2021 à 20:15, Scott Kostyshak a écrit : It seems that it is triggered with a lot of branches (or perhaps more generally any different kind of insets?). Attached is an LFUN sequence that reproduces it. Does it trigger the error for you? Look at ColorSet::setColor in Color.cpp. Branche

Re: Link error when compiling with -fsanitize=undefined

2021-09-20 Thread Jean-Marc Lasgouttes
Le 18/09/2021 à 18:46, Kornel Benko a écrit : Am Sat, 18 Sep 2021 10:34:49 -0400 schrieb Scott Kostyshak : I tried but failed. The problem is that tex2lyx uses libzlibstatic.a, ../../lib/libsupport.a to link with, but these are compiled with -fsanitize. So the only way is to define dummy versi

Re: Link error when compiling with -fsanitize=undefined

2021-09-19 Thread Scott Kostyshak
On Sun, Sep 19, 2021 at 08:37:16PM +0200, Kornel Benko wrote: > Am Sun, 19 Sep 2021 14:15:21 -0400 > schrieb Scott Kostyshak : > > > On Sun, Sep 19, 2021 at 02:00:33PM +0200, Kornel Benko wrote: > > > Am Sun, 19 Sep 2021 07:45:19 -0400 > > > schrieb Scott Kostyshak : > > > > > > > > > > So inse

Re: Link error when compiling with -fsanitize=undefined

2021-09-19 Thread Kornel Benko
Am Sun, 19 Sep 2021 14:15:21 -0400 schrieb Scott Kostyshak : > On Sun, Sep 19, 2021 at 02:00:33PM +0200, Kornel Benko wrote: > > Am Sun, 19 Sep 2021 07:45:19 -0400 > > schrieb Scott Kostyshak : > > > > > > > > So inserting this include cured the compilation for me. > > > > > > > > > > Th

Re: Link error when compiling with -fsanitize=undefined

2021-09-19 Thread Scott Kostyshak
On Sun, Sep 19, 2021 at 02:00:33PM +0200, Kornel Benko wrote: > Am Sun, 19 Sep 2021 07:45:19 -0400 > schrieb Scott Kostyshak : > > > > > > So inserting this include cured the compilation for me. > > > > > > > > That's great you figured it out and it doesn't add too much complexity > > > > to

Re: Link error when compiling with -fsanitize=undefined

2021-09-19 Thread Kornel Benko
Am Sun, 19 Sep 2021 07:45:19 -0400 schrieb Scott Kostyshak : > > > > So inserting this include cured the compilation for me. > > > > > > That's great you figured it out and it doesn't add too much complexity to > > > the code. > > > Are you sure it ended up using the -fsanitize=undefined fla

Re: Link error when compiling with -fsanitize=undefined

2021-09-19 Thread Scott Kostyshak
On Sun, Sep 19, 2021 at 10:35:44AM +0200, Kornel Benko wrote: > Am Sat, 18 Sep 2021 20:52:43 -0400 > schrieb Scott Kostyshak : > > > On Sat, Sep 18, 2021 at 06:46:47PM +0200, Kornel Benko wrote: > > > Am Sat, 18 Sep 2021 10:34:49 -0400 > > > schrieb Scott Kostyshak : > > > > > > > > I tried but

Re: Link error when compiling with -fsanitize=undefined

2021-09-19 Thread Kornel Benko
Am Sat, 18 Sep 2021 20:52:43 -0400 schrieb Scott Kostyshak : > On Sat, Sep 18, 2021 at 06:46:47PM +0200, Kornel Benko wrote: > > Am Sat, 18 Sep 2021 10:34:49 -0400 > > schrieb Scott Kostyshak : > > > > > > I tried but failed. The problem is that tex2lyx uses > > > > libzlibstatic.a, ../../lib/l

Re: Link error when compiling with -fsanitize=undefined

2021-09-18 Thread Scott Kostyshak
On Sat, Sep 18, 2021 at 06:46:47PM +0200, Kornel Benko wrote: > Am Sat, 18 Sep 2021 10:34:49 -0400 > schrieb Scott Kostyshak : > > > > I tried but failed. The problem is that tex2lyx uses > > > libzlibstatic.a, ../../lib/libsupport.a to link with, but these are > > > compiled with > > > -fsanitiz

Re: Link error when compiling with -fsanitize=undefined

2021-09-18 Thread Kornel Benko
Am Sat, 18 Sep 2021 10:34:49 -0400 schrieb Scott Kostyshak : > > I tried but failed. The problem is that tex2lyx uses > > libzlibstatic.a, ../../lib/libsupport.a to link with, but these are > > compiled with > > -fsanitize. So the only way is to define dummy versions as Jean-Marc > > pointed out

Re: Link error when compiling with -fsanitize=undefined

2021-09-18 Thread Scott Kostyshak
On Sat, Sep 18, 2021 at 04:29:40PM +0200, Kornel Benko wrote: > Am Fri, 17 Sep 2021 16:41:09 -0400 > schrieb Scott Kostyshak : > > > On Fri, Sep 17, 2021 at 10:22:28PM +0200, Kornel Benko wrote: > > > Am Fri, 17 Sep 2021 20:24:17 +0200 > > > schrieb Jean-Marc Lasgouttes : > > > > > > > Le 17/09

Re: Link error when compiling with -fsanitize=undefined

2021-09-18 Thread Kornel Benko
Am Fri, 17 Sep 2021 16:41:09 -0400 schrieb Scott Kostyshak : > On Fri, Sep 17, 2021 at 10:22:28PM +0200, Kornel Benko wrote: > > Am Fri, 17 Sep 2021 20:24:17 +0200 > > schrieb Jean-Marc Lasgouttes : > > > > > Le 17/09/2021 à 20:21, Scott Kostyshak a écrit : > > > > /usr/include/c++/10/bits/st

Re: Link error when compiling with -fsanitize=undefined

2021-09-17 Thread Scott Kostyshak
On Fri, Sep 17, 2021 at 10:22:28PM +0200, Kornel Benko wrote: > Am Fri, 17 Sep 2021 20:24:17 +0200 > schrieb Jean-Marc Lasgouttes : > > > Le 17/09/2021 à 20:21, Scott Kostyshak a écrit : > > > /usr/include/c++/10/bits/stl_function.h:386:20: runtime error: load of > > > value 128, > > > which is n

Re: Link error when compiling with -fsanitize=undefined

2021-09-17 Thread Kornel Benko
Am Fri, 17 Sep 2021 20:24:17 +0200 schrieb Jean-Marc Lasgouttes : > Le 17/09/2021 à 20:21, Scott Kostyshak a écrit : > > /usr/include/c++/10/bits/stl_function.h:386:20: runtime error: load of > > value 128, > > which is not a valid value for type 'ColorCode' > > /usr/include/c++/10/tuple:1693:70

Re: Link error when compiling with -fsanitize=undefined

2021-09-17 Thread Jean-Marc Lasgouttes
Le 17/09/2021 à 20:21, Scott Kostyshak a écrit : /usr/include/c++/10/bits/stl_function.h:386:20: runtime error: load of value 128, which is not a valid value for type 'ColorCode' /usr/include/c++/10/tuple:1693:70: runtime error: load of value 128, which is not a valid value for type 'ColorCode'

Re: Link error when compiling with -fsanitize=undefined

2021-09-17 Thread Scott Kostyshak
On Fri, Sep 17, 2021 at 12:11:46PM +0200, Jean-Marc Lasgouttes wrote: > Le 16/09/2021 à 22:13, Kornel Benko a écrit : > > Am Thu, 16 Sep 2021 15:12:34 -0400 > > schrieb Scott Kostyshak : > > > > > I was curious about compiling with -fsanitize=undefined. > > > > > > When building (with CMake), I g

Re: Link error when compiling with -fsanitize=undefined

2021-09-17 Thread Jean-Marc Lasgouttes
Le 16/09/2021 à 22:13, Kornel Benko a écrit : Am Thu, 16 Sep 2021 15:12:34 -0400 schrieb Scott Kostyshak : I was curious about compiling with -fsanitize=undefined. When building (with CMake), I get the following: -lz /usr/bin/ld: CMakeFiles/tex2lyx.dir/dummy_impl.cpp.o:(.data.rel+0x118): u

Re: Link error when compiling with -fsanitize=undefined

2021-09-17 Thread Kornel Benko
Am Thu, 16 Sep 2021 21:12:38 -0400 schrieb Scott Kostyshak : > On Thu, Sep 16, 2021 at 10:13:15PM +0200, Kornel Benko wrote: > > Am Thu, 16 Sep 2021 15:12:34 -0400 > > schrieb Scott Kostyshak : > > > > > I was curious about compiling with -fsanitize=undefined. > > > > > > When building (with C

Re: Link error when compiling with -fsanitize=undefined

2021-09-16 Thread Scott Kostyshak
On Thu, Sep 16, 2021 at 10:13:15PM +0200, Kornel Benko wrote: > Am Thu, 16 Sep 2021 15:12:34 -0400 > schrieb Scott Kostyshak : > > > I was curious about compiling with -fsanitize=undefined. > > > > When building (with CMake), I get the following: > > > > [ 93%] Linking CXX executable ../../bin/t

Re: Link error when compiling with -fsanitize=undefined

2021-09-16 Thread Kornel Benko
Am Thu, 16 Sep 2021 15:12:34 -0400 schrieb Scott Kostyshak : > I was curious about compiling with -fsanitize=undefined. > > When building (with CMake), I get the following: > > [ 93%] Linking CXX executable ../../bin/tex2lyx > cd /home/scott/lyxbuilds/master/CMakeBuild/src/tex2lyx && /usr/bin/cm

Link error when compiling with -fsanitize=undefined

2021-09-16 Thread Scott Kostyshak
I was curious about compiling with -fsanitize=undefined. When building (with CMake), I get the following: [ 93%] Linking CXX executable ../../bin/tex2lyx cd /home/scott/lyxbuilds/master/CMakeBuild/src/tex2lyx && /usr/bin/cmake -E cmake_link_script CMakeFiles/tex2lyx.dir/link.txt --verbose=1 /usr