Re: It's not fair!

2007-09-04 Thread Abdelrazak Younes
Jean-Marc Lasgouttes wrote: Abdelrazak Younes <[EMAIL PROTECTED]> writes: Jean-Marc Lasgouttes wrote: So, basically, 60% of the time spent in updateLabel is spent in TocBackend::update. The said TocBackend::update call has been added at some point by some sloppy Gremlin who thought that nobody

Re: It's not fair!

2007-09-04 Thread Jean-Marc Lasgouttes
Abdelrazak Younes <[EMAIL PROTECTED]> writes: > Jean-Marc Lasgouttes wrote: >> So, basically, 60% of the time spent in updateLabel is spent in >> TocBackend::update. The said TocBackend::update call has been added at >> some point by some sloppy Gremlin who thought that nobody would >> notice. >>

Re: It's not fair!

2007-08-17 Thread Abdelrazak Younes
Jean-Marc Lasgouttes wrote: > Hum, maybe we (you?) could do this as a first step: The later problem could be addressed by rewriting it like updateLabels to avoid using ParConstIterator. This is as easy as defining a InsetText::addToToc (and a InsetLabel::addToToc, maybe). And this as a second

Re: It's not fair!

2007-08-17 Thread Abdelrazak Younes
Jean-Marc Lasgouttes wrote: So, basically, 60% of the time spent in updateLabel is spent in TocBackend::update. The said TocBackend::update call has been added at some point by some sloppy Gremlin who thought that nobody would notice. So: updateLabel is fast. TocBackend::update is slow. I am p

It's not fair!

2007-08-17 Thread Jean-Marc Lasgouttes
I fired gprof to try to see whether updateLabel was as slow as Abdel claims (by loading the user guide and repeateadly breaking and merging a section paragraph to trigger renumber). The answer is: [7] 85.00.00 25.80 249 lyx::updateLabels(lyx::Buffer const &, bool) [7]