Re: Header refactoring patches

2020-10-26 Thread Yuriy Skalko
Previously it happened that these headers in all clients were included after some other headers that define these types (directly or indirectly). Oh, I see it's just that we were always lucky to have e.g. include FileName.h before include Clipboard.h. Thanks, Pavel Yes. C/C++ header include

Re: Header refactoring patches

2020-10-25 Thread Pavel Sanda
On Mon, Oct 26, 2020 at 12:45:53AM +0200, Yuriy Skalko wrote: > Previously it happened that these headers in all clients were included after > some other headers that define these types (directly or indirectly). Oh, I see it's just that we were always lucky to have e.g. include FileName.h before i

Re: Header refactoring patches

2020-10-25 Thread Yuriy Skalko
--- a/src/frontends/Clipboard.h +++ b/src/frontends/Clipboard.h @@ -14,6 +14,7 @@ #ifndef BASE_CLIPBOARD_H #define BASE_CLIPBOARD_H +#include "support/FileName.h" #include "support/strfwd.h" namespace lyx { diff --git a/src/frontends/qt/GuiKeySymbol.h b/src/frontends/qt/GuiKeySymbol.h in

Re: Header refactoring patches

2020-10-25 Thread Pavel Sanda
On Sun, Oct 25, 2020 at 09:09:00AM +0200, Yuriy Skalko wrote: > --- a/src/frontends/Clipboard.h > +++ b/src/frontends/Clipboard.h > @@ -14,6 +14,7 @@ > #ifndef BASE_CLIPBOARD_H > #define BASE_CLIPBOARD_H > > +#include "support/FileName.h" > #include "support/strfwd.h" > > namespace lyx { >

Re: Header refactoring patches

2020-10-25 Thread Richard Kimberly Heck
OK on these. Riki -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel

Header refactoring patches

2020-10-25 Thread Yuriy Skalko
From eeacba8e112b8af7e5c924ad2cacb1457dc816dd Mon Sep 17 00:00:00 2001 From: Yuriy Skalko Date: Sun, 25 Oct 2020 00:47:13 +0300 Subject: [PATCH 1/2] Move include of own header to the top. Fix dependencies --- src/BiblioInfo.cpp | 3 ++- src/FontInfo.cpp