Re: GIT::findFile() fix

2013-04-10 Thread Georg Baum
Nico Williams wrote: > Please, please give me an option to have LyX do nothing regarding git. > In particular I want an option to have LyX make absolutely no > commands like: git add, git commit, git pull, git push, git merge, git > cherry-pick, git branch, or git checkout, and no versions of any

Re: GIT::findFile() fix

2013-04-08 Thread Nico Williams
On Mon, Apr 8, 2013 at 4:22 PM, Tommaso Cucinotta wrote: > On 04/04/13 03:03, Nico Williams wrote: > > ... > It looks like you'd like LyX to launch gitk! Why repeating all that stuff > within LyX :-)? Actually, I want LyX to do *nothing* with git *except*, maybe, tell me if any file it's working

Re: GIT::findFile() fix

2013-04-08 Thread Tommaso Cucinotta
On 04/04/13 03:03, Nico Williams wrote: > > On Apr 3, 2013 6:58 PM, "Pavel Sanda" mailto:sa...@lyx.org>> > wrote: >> Perhaps we can drop this check-out behaviour if it makes troubles, wait for >> Georg's opinion. >> There is also still the problem that we run GIT::find_file 2x IIRC. > > I'm har

Re: GIT::findFile() fix

2013-04-08 Thread Nico Williams
Please, please give me an option to have LyX do nothing regarding git. In particular I want an option to have LyX make absolutely no commands like: git add, git commit, git pull, git push, git merge, git cherry-pick, git branch, or git checkout, and no versions of any of those that have side effec

Re: GIT::findFile() fix

2013-04-08 Thread Georg Baum
Pavel Sanda wrote: > Georg Baum wrote: >> > Perhaps we can drop this check-out behaviour if it makes troubles, wait >> > for Georg's opinion. There is also still the problem that we run >> > GIT::find_file 2x IIRC. >> >> Really? I thought I got rid of it. Sorry, I have currently no time to >> che

Re: GIT::findFile() fix

2013-04-06 Thread Tommaso Cucinotta
On 06/04/13 05:29, Pavel Sanda wrote: > Tommaso Cucinotta wrote: >> Does it seem ok ? > > Haven't tested but looks fine now. > Pavel > . > It's in: [26dd4d0c/lyxgit]. T.

Re: GIT::findFile() fix

2013-04-05 Thread Pavel Sanda
Georg Baum wrote: > > Perhaps we can drop this check-out behaviour if it makes troubles, wait > > for Georg's opinion. There is also still the problem that we run > > GIT::find_file 2x IIRC. > > Really? I thought I got rid of it. Sorry, I have currently no time to check. I haven't seen any commit

Re: GIT::findFile() fix

2013-04-05 Thread Pavel Sanda
Tommaso Cucinotta wrote: > Does it seem ok ? Haven't tested but looks fine now. Pavel

Re: GIT::findFile() fix

2013-04-05 Thread Tommaso Cucinotta
On 04/04/13 21:35, Pavel Sanda wrote: > Georg Baum wrote: >> case a file does not exist in git, but this is not an error here. Do you >> know whether this behaviour (output something on stdout only if the file is >> know) is as stable as the --porcelain optin for other commands? > >>From stabili

Re: GIT::findFile() fix

2013-04-05 Thread Tommaso Cucinotta
On 04/04/13 20:09, Georg Baum wrote: > This is a feature that did only work for RCS for a long time, and which I > extended to the other VCS as well recently: If you try to open a file, and > the file does not exist locally, and you are in a tree which is under > version control, and the file ex

Re: GIT::findFile() fix

2013-04-04 Thread Pavel Sanda
Georg Baum wrote: > case a file does not exist in git, but this is not an error here. Do you > know whether this behaviour (output something on stdout only if the file is > know) is as stable as the --porcelain optin for other commands? >From stability point of view it might be better to check t

Re: GIT::findFile() fix

2013-04-04 Thread Georg Baum
Tommaso Cucinotta wrote: > Hi, > > I just noticed that GIT::findFile() doesn't seem to work, namely if I open > with git any file within the lyx sources tree, it always asks me whether I > want to retrieve the file from the VCS (which in turn causes all test > cases in autotests to fail, but it's

Re: GIT::findFile() fix

2013-04-04 Thread Georg Baum
Pavel Sanda wrote: > The problem is that such behaviour is intentional i guess, my > understanding is File exists & is in repo -> we load with git support > File exists & not in repo-> ?? porcelain case, we don't load with VCS > support File !exists& we are in repo (more exactly within dir structu

Re: GIT::findFile() fix

2013-04-04 Thread Tommaso Cucinotta
On 04/04/13 00:57, Pavel Sanda wrote: > File !exists& we are in repo (more exactly within dir structure where .git > can be found in ancestors) -> we offer to check it out from archive (your > "bug") > File !exists& we are not in repo -> just create new file I work a lot creating new files local

Re: GIT::findFile() fix

2013-04-03 Thread Nico Williams
On Apr 3, 2013 6:58 PM, "Pavel Sanda" wrote: > Perhaps we can drop this check-out behaviour if it makes troubles, wait for Georg's opinion. > There is also still the problem that we run GIT::find_file 2x IIRC. I'm hard-pressed to think of git-specific behavior in LyX that i want besides a) a menu

Re: GIT::findFile() fix

2013-04-03 Thread Pavel Sanda
Tommaso Cucinotta wrote: > On 04/04/13 00:31, Pavel Sanda wrote: > >> tommaso@mobiletom:~/lyx-trunk-ws/lyx/development/autotests$ git status > >> hello-world-in.txt > >> # On branch master > >> nothing to commit (working directory clean) > >> tommaso@mobiletom:~/lyx-trunk-ws/lyx/development/autote

Re: GIT::findFile() fix

2013-04-03 Thread Tommaso Cucinotta
On 04/04/13 00:31, Pavel Sanda wrote: >> tommaso@mobiletom:~/lyx-trunk-ws/lyx/development/autotests$ git status >> hello-world-in.txt >> # On branch master >> nothing to commit (working directory clean) >> tommaso@mobiletom:~/lyx-trunk-ws/lyx/development/autotests$ git status >> non-existent.txt

Re: GIT::findFile() fix

2013-04-03 Thread Pavel Sanda
Tommaso Cucinotta wrote: > Hi, > > I just noticed that GIT::findFile() doesn't seem to work, namely if I open > with git any file within the lyx sources tree, it always asks me whether I > want to retrieve the file from the VCS (which in turn causes all test cases > in autotests to fail, but it

GIT::findFile() fix

2013-04-03 Thread Tommaso Cucinotta
Hi, I just noticed that GIT::findFile() doesn't seem to work, namely if I open with git any file within the lyx sources tree, it always asks me whether I want to retrieve the file from the VCS (which in turn causes all test cases in autotests to fail, but it's unimportant now). I noticed the c