Re: [patch] Fix for segfault on recursive macros, Bug #1395

2007-04-17 Thread Abdelrazak Younes
Stefan Schimanski wrote: Stefan Schimanski wrote: Stefan, could you please update your patch with Andre's comment? Here it is. Thanks. I also need a log for the SVN commit. Here it is: Locking counter added to MacroData: it is increased before drawing/metric calculations and decreased aft

Re: [patch] Fix for segfault on recursive macros, Bug #1395

2007-04-17 Thread Stefan Schimanski
Stefan Schimanski wrote: Stefan, could you please update your patch with Andre's comment? Here it is. Thanks. I also need a log for the SVN commit. Here it is: Locking counter added to MacroData: it is increased before drawing/ metric calculations and decreased afterwards in InsetMathMacro

Re: [patch] Fix for segfault on recursive macros, Bug #1395

2007-04-17 Thread Abdelrazak Younes
Stefan Schimanski wrote: Stefan, could you please update your patch with Andre's comment? Here it is. Thanks. I also need a log for the SVN commit. Abdel.

Re: [patch] Fix for segfault on recursive macros, Bug #1395

2007-04-17 Thread Stefan Schimanski
Stefan, could you please update your patch with Andre's comment? Here it is. Stefan recursivemacros.patch Description: Binary data PGP.sig Description: Signierter Teil der Nachricht

Re: [patch] Fix for segfault on recursive macros, Bug #1395

2007-04-17 Thread Abdelrazak Younes
Andre Poenitz wrote: On Mon, Apr 16, 2007 at 04:53:44PM +0200, Abdelrazak Younes wrote: Stefan Schimanski wrote: Hi! Here is a proposal to fix the crash when you try to define macros with self references, i.e. by using \foo inside of the definition of \foo itself (or by any other definitiona

Re: [patch] Fix for segfault on recursive macros, Bug #1395

2007-04-16 Thread Andre Poenitz
On Mon, Apr 16, 2007 at 04:59:40PM +0200, Stefan Schimanski wrote: > I was thinking about tracking the dependency graph of used macros in > a macro definition and look for loops. Then return a harmless > MathMacro with some error string in that case. But that would > probably be much more com

Re: [patch] Fix for segfault on recursive macros, Bug #1395

2007-04-16 Thread Andre Poenitz
On Mon, Apr 16, 2007 at 04:53:44PM +0200, Abdelrazak Younes wrote: > Stefan Schimanski wrote: > >Hi! > > > >Here is a proposal to fix the crash when you try to define macros with > >self references, i.e. by using \foo inside of the definition of \foo > >itself (or by any other definitional loop):

Re: [patch] Fix for segfault on recursive macros, Bug #1395

2007-04-16 Thread Stefan Schimanski
Am 16.04.2007 um 16:53 schrieb Abdelrazak Younes: Stefan Schimanski wrote: Hi! Here is a proposal to fix the crash when you try to define macros with self references, i.e. by using \foo inside of the definition of \foo itself (or by any other definitional loop): http://bugzilla.lyx.org/

Re: [patch] Fix for segfault on recursive macros, Bug #1395

2007-04-16 Thread Abdelrazak Younes
Stefan Schimanski wrote: Hi! Here is a proposal to fix the crash when you try to define macros with self references, i.e. by using \foo inside of the definition of \foo itself (or by any other definitional loop): http://bugzilla.lyx.org/attachment.cgi?id=1548&action=view It basically impl

Re: [patch] Fix for segfault on recursive macros, Bug #1395

2007-04-16 Thread Abdelrazak Younes
Stefan Schimanski wrote: Hi! Here is a proposal to fix the crash when you try to define macros with self references, i.e. by using \foo inside of the definition of \foo itself (or by any other definitional loop): Hello Stephan, Sorry I can't comment on your patch (cause I am totally ignoran

[patch] Fix for segfault on recursive macros, Bug #1395

2007-04-16 Thread Stefan Schimanski
Hi! Here is a proposal to fix the crash when you try to define macros with self references, i.e. by using \foo inside of the definition of \foo itself (or by any other definitional loop): http://bugzilla.lyx.org/attachment.cgi?id=1548&action=view It basically implements a locking counter

Fix for segfault

2000-03-15 Thread Lars Gullik Bjønnes
I have just checked in a fix to the seggfault problem . At least I am not able to make Lyx segfault in my simplistic testes anymore. So if you earlier were able to make LyX seffault easy do the same now and report the status. The error I fixed were in LyXText::Backspace where we deleted a lyxpar