> "Edwin" == Edwin Leuven <[EMAIL PROTECTED]> writes:
>> My favourite is 'a.'.
Edwin> the casing suggests the presence of a Frontend class somewhere.
Edwin> if the file contains functions used in the frontend but not
Edwin> related to a Frontend class then i think that d. makes most
Edwin>
Andre Poenitz schrieb:
_pimpl.[Ch] should be included in the respective .C files. Actually I
think there's none left...
There are still two *_pimpl left:
$ find . -name "*impl*"
./frontends/Alert_pimpl.h
./frontends/qt4/Alert_pimpl.C
Michael
On Wed, 25 Apr 2007, Bo Peng wrote:
I vote d.
You guys already won. see src/frontends/controllers/frontend_helpers.h/cpp.
:-)
I have also changed file extension for controllers/*.C, and that will be
all for today. I need to leave some time for you guys to check if
everything is still wor
>> d. frontend_helper
>>
>> I vote d.
>
> I vote a, as I have said.
I vote d.
You guys already won. see src/frontends/controllers/frontend_helpers.h/cpp. :-)
I have also changed file extension for controllers/*.C, and that will
be all for today. I need to leave some time for you guys to
On Wed, 25 Apr 2007, Bo Peng wrote:
Did you see my small script for checking that?
Not yet. Did you find anything wrong in insets, graphics and mathed?
Bo> a. FrontendHelper
b. frontendHelper
c. Frontend_helper
d. frontend_helper
I vote d.
I vote a, as I have said.
On Wed, Apr 25, 2007 at 05:58:19PM +0200, Jean-Marc Lasgouttes wrote:
> > "Bo" == Bo Peng <[EMAIL PROTECTED]> writes:
>
> >> pegase: ../checknames.sh graphics/*.h insets/*.h
> >> graphics/GraphicsCache.h is bad graphics/GraphicsCacheItem.h is bad
> >> graphics/GraphicsConverter.h is bad graphi
On Wed, Apr 25, 2007 at 10:20:55AM -0500, Bo Peng wrote:
> >My rules are more or less:
> >
> >it should be Foo.h/Foo.cpp.
> >it should be named Foo.h/Foo.cpp.
> >it should be named Foo.h/Foo.cpp.
> >
> >Name clashes should be avoided.
>
> There is a problem with your approach, as in the case of sr
Andre Poenitz wrote:
On Wed, Apr 25, 2007 at 10:07:56AM -0500, Bo Peng wrote:
PS. I like to be consistent in the naming, but what are the guidelines?
Guideline1: classname = filename. Because classnames are in
uppercase, files are also named in this way. src/insets/*,
src/mathed/* and src/grap
On Wed, Apr 25, 2007 at 10:07:56AM -0500, Bo Peng wrote:
> >PS. I like to be consistent in the naming, but what are the guidelines?
>
> Guideline1: classname = filename. Because classnames are in
> uppercase, files are also named in this way. src/insets/*,
> src/mathed/* and src/graphics/* follow
> "Bo" == Bo Peng <[EMAIL PROTECTED]> writes:
>> pegase: ../checknames.sh graphics/*.h insets/*.h
>> graphics/GraphicsCache.h is bad graphics/GraphicsCacheItem.h is bad
>> graphics/GraphicsConverter.h is bad graphics/GraphicsImage.h is bad
>> graphics/GraphicsLoader.h is bad graphics/GraphicsP
pegase: ../checknames.sh graphics/*.h insets/*.h
graphics/GraphicsCache.h is bad
graphics/GraphicsCacheItem.h is bad
graphics/GraphicsConverter.h is bad
graphics/GraphicsImage.h is bad
graphics/GraphicsLoader.h is bad
graphics/GraphicsParams.h is bad
insets/ExternalTemplate.h is bad
insets/Externa
> "Bo" == Bo Peng <[EMAIL PROTECTED]> writes:
>> Did you see my small script for checking that?
Bo> Not yet. Did you find anything wrong in insets, graphics and
Bo> mathed?
pegase: ../checknames.sh graphics/*.h insets/*.h
graphics/GraphicsCache.h is bad
graphics/GraphicsCacheItem.h is bad
gra
My rules are more or less:
it should be Foo.h/Foo.cpp.
it should be named Foo.h/Foo.cpp.
it should be named Foo.h/Foo.cpp.
Name clashes should be avoided.
There is a problem with your approach, as in the case of src/box and
src/frontends/qt4/box. I am not offended by QBox, although I dislike
Q
On Wed, Apr 25, 2007 at 01:43:06PM +0200, [EMAIL PROTECTED] wrote:
> On Wed, 25 Apr 2007, Abdelrazak Younes wrote:
>
> >Jean-Marc Lasgouttes wrote:
> >>> > > > > "christian" == christian ridderstrom
> >>> > > > > <[EMAIL PROTECTED]>
> >>> > > > > writes:
> >>
> >>> > > Actually, I propose to
Did you see my small script for checking that?
Not yet. Did you find anything wrong in insets, graphics and mathed?
Bo> a. FrontendHelper b. frontendHelper c. Frontend_helper d.
Bo> frontend_helper
I vote d.
I vote a, as I have said.
Bo
> "Bo" == Bo Peng <[EMAIL PROTECTED]> writes:
>> PS. I like to be consistent in the naming, but what are the
>> guidelines?
Bo> Guideline1: classname = filename. Because classnames are in
Bo> uppercase, files are also named in this way. src/insets/*,
Bo> src/mathed/* and src/graphics/* follow
PS. I like to be consistent in the naming, but what are the guidelines?
Guideline1: classname = filename. Because classnames are in
uppercase, files are also named in this way. src/insets/*,
src/mathed/* and src/graphics/* follow this guideline well so these
are what I have renamed so far.
Gui
On Wed, 25 Apr 2007, Abdelrazak Younes wrote:
Jean-Marc Lasgouttes wrote:
> > > > > "christian" == christian ridderstrom
> > > > > <[EMAIL PROTECTED]>
> > > > > writes:
> > > Actually, I propose to merge all these files to FrontendHelpers.
christian> I probably missed it in the thread,
Jean-Marc Lasgouttes wrote:
"christian" == christian ridderstrom <[EMAIL PROTECTED]> writes:
Actually, I propose to merge all these files to FrontendHelpers.
christian> I probably missed it in the thread, but I thought
christian> UpperCase.cpp was intended for a file that defined the
christi
> "christian" == christian ridderstrom <[EMAIL PROTECTED]> writes:
>>> Actually, I propose to merge all these files to FrontendHelpers.
christian> I probably missed it in the thread, but I thought
christian> UpperCase.cpp was intended for a file that defined the
christian> class UpperCase?
I
On Wed, 25 Apr 2007, Andre Poenitz wrote:
On Tue, Apr 24, 2007 at 11:03:43PM -0500, Bo Peng wrote:
Only five files do not follow the new conventions.
biblio.C
tex_helpers.C
frnt_lang.C
helper_funcs.C
character.C
How about:
BiblioHelpers.cpp (the old name? I see BIBLIOHELPERS_H defined)
TexHe
On Tue, Apr 24, 2007 at 11:03:43PM -0500, Bo Peng wrote:
> Only five files do not follow the new conventions.
>
> biblio.C
> tex_helpers.C
> frnt_lang.C
> helper_funcs.C
> character.C
>
> How about:
>
> BiblioHelpers.cpp (the old name? I see BIBLIOHELPERS_H defined)
> TexHelpers.cpp
> LangHelper
Only five files do not follow the new conventions.
biblio.C
tex_helpers.C
frnt_lang.C
helper_funcs.C
character.C
How about:
BiblioHelpers.cpp (the old name? I see BIBLIOHELPERS_H defined)
TexHelpers.cpp
LangHelpers.cpp
FrontendHelpers.cpp
CharacterHelpers.cpp (the old name?)
Actually, I propos
23 matches
Mail list logo
