Re: EnumLColor: preliminary patch

2003-09-15 Thread Andre Poenitz
On Mon, Sep 15, 2003 at 03:09:23PM +, Angus Leeming wrote: > On Monday 15 September 2003 1:58 pm, Andre Poenitz wrote: > > As I said, I'd prefer a de-coupled version without macros, but as > > I am already a bit upset about people going into nitpick mode > > Can I make the same suggestion to y

Re: EnumLColor: preliminary patch

2003-09-15 Thread Lars Gullik Bjønnes
Angus Leeming <[EMAIL PROTECTED]> writes: | Andre Poenitz wrote: > >> On Mon, Sep 15, 2003 at 02:22:57PM +, Angus Leeming wrote: >> >> +struct Class { \ >> + /** The default argument is nasty, \ >> +* but allows us to use Class in STL containers. \ >> +*/ \ >> + C

Re: EnumLColor: preliminary patch

2003-09-15 Thread Angus Leeming
Andre Poenitz wrote: > Why to LColor.h and not to a separate header LColor_enum.h containing > > enum ColorEnum { > /// No particular color---clear or default > none, > /// The different text colors > black, > /// >

Re: EnumLColor: preliminary patch

2003-09-15 Thread Angus Leeming
On Monday 15 September 2003 1:58 pm, Andre Poenitz wrote: > As I said, I'd prefer a de-coupled version without macros, but as I am > already a bit upset about people going into nitpick mode Can I make the same suggestion to you as you make to me (below)? > the final words are: > I do not really c

Re: EnumLColor: preliminary patch

2003-09-15 Thread Andre Poenitz
On Mon, Sep 15, 2003 at 02:47:40PM +, Angus Leeming wrote: > Andre Poenitz wrote: > > > On Mon, Sep 15, 2003 at 02:22:57PM +, Angus Leeming wrote: > > > > +struct Class { \ > > + /** The default argument is nasty, \ > > +* but allows us to use Class in STL containers. \ > >

Re: EnumLColor: preliminary patch

2003-09-15 Thread Angus Leeming
Andre Poenitz wrote: > On Mon, Sep 15, 2003 at 02:22:57PM +, Angus Leeming wrote: > > +struct Class { \ > + /** The default argument is nasty, \ > +* but allows us to use Class in STL containers. \ > +*/ \ > + Class(Enum val = static_cast(-1)) : val_(val) {} \ > +

Re: EnumLColor: preliminary patch

2003-09-15 Thread Andre Poenitz
On Mon, Sep 15, 2003 at 02:22:57PM +, Angus Leeming wrote: +struct Class { \ + /** The default argument is nasty, \ +* but allows us to use Class in STL containers. \ +*/ \ + Class(Enum val = static_cast(-1)) : val_(val) {} \ + operator Enum() const{ retur

Re: EnumLColor: preliminary patch

2003-09-15 Thread Angus Leeming
Angus Leeming wrote: > 4. There are two LColor::color values that are used as default values, > foreground and none. As in: > void foo(EnumLColor const & = LColor::foreground); > void bar(EnumLColor const & back = LColor::none); > I propose adding a couple of functions and then dec

EnumLColor: preliminary patch

2003-09-14 Thread Angus Leeming
Attached is a preliminary patch on the road to removing #include "LColor.h" from header files simply to define a function's argument list. I have done no more than replace the LColor::color instances with EnumLColor const &. Questions. 1. Instances of both LColor::color and this EnumLColor wrap