On Thu, 25 Oct 2007 10:01:21 +0200
Jean-Marc Lasgouttes <[EMAIL PROTECTED]> wrote:
> Martin Vermeer <[EMAIL PROTECTED]> writes:
>
> > Done, see attached.
>
> Very good.
>
> JMarc
It's committed, thanks.
- Martin
Martin Vermeer <[EMAIL PROTECTED]> writes:
> Done, see attached.
Very good.
JMarc
Every day, and in every way, it gets better and better. (With apologies
to Inspector Dreyfus, not to mention Emile Coue.)
rh
Martin Vermeer wrote:
On Wed, Oct 24, 2007 at 12:38:54PM +0200, Jean-Marc Lasgouttes wrote:
Martin Vermeer <[EMAIL PROTECTED]> writes:
Ah. But doesn't verba
On Wed, Oct 24, 2007 at 12:38:54PM +0200, Jean-Marc Lasgouttes wrote:
> Martin Vermeer <[EMAIL PROTECTED]> writes:
>
> > Ah. But doesn't verbatim imply free spacing? And what about allowEmpty()?
> >
> > I see what's happening with the Verbatim layout and with the
> > FreeSpacing parameter, but wha
On Wednesday 24 October 2007 17:14:50 Andre Poenitz wrote:
> It's a thing that should be decided per case in the review proces...
I agree.
> In theory.
>
> Andre'
--
José Abílio
On Wed, Oct 24, 2007 at 10:05:22AM +0200, Abdelrazak Younes wrote:
> We should put a hard rule that anyone adding more than 10 lines of code
> to a method should do so in a new method. Or is it in the coding rules
> already?
It's a thing that should be decided per case in the review proces...
I
On Wednesday 24 October 2007 11:38:54 Jean-Marc Lasgouttes wrote:
> It would make sense to have the same concepts in both kind of layouts.
> I think your verbatim is what is called pass_thru in Layout. I do not
> care about particular names, but uniformity is good (meaning that if
> you prefer you
Martin Vermeer <[EMAIL PROTECTED]> writes:
> Ah. But doesn't verbatim imply free spacing? And what about allowEmpty()?
>
> I see what's happening with the Verbatim layout and with the
> FreeSpacing parameter, but what is the logic behind it (if any)?
> Should we have a separate FreeSpacing parm fo
On Wed, 24 Oct 2007 11:57:18 +0200
Jean-Marc Lasgouttes <[EMAIL PROTECTED]> wrote:
> Martin Vermeer <[EMAIL PROTECTED]> writes:
>
> > I am thinking of just implementing isFreeSpacing() for Inset, and then
> > inheriting and modifying it in Collapsable using layout.verbatim. Are
> > there any prob
Martin Vermeer wrote:
On Wed, 24 Oct 2007 10:05:22 +0200
Abdelrazak Younes <[EMAIL PROTECTED]> wrote:
...
I _hope_ the encoding problem was the only one remaining... can you say
'spaghetti'?
It wasn't so bad in the end, was it? ;)
I circumvented the spaghetti rather than addressing it ;-/ "N
Martin Vermeer <[EMAIL PROTECTED]> writes:
> I am thinking of just implementing isFreeSpacing() for Inset, and then
> inheriting and modifying it in Collapsable using layout.verbatim. Are
> there any problems with that?
I'd rather separate the notion of verbatim and the notion of free
spacing, li
On Wed, 24 Oct 2007 10:05:22 +0200
Abdelrazak Younes <[EMAIL PROTECTED]> wrote:
...
> >>> I _hope_ the encoding problem was the only one remaining... can you say
> >>> 'spaghetti'?
> >> It wasn't so bad in the end, was it? ;)
> >
> > I circumvented the spaghetti rather than addressing it ;-/ "No
Martin Vermeer wrote:
On Wed, Oct 24, 2007 at 12:51:00AM +0200, Dov Feldstern wrote:
But anyhow, IMO both r21153 and r21121 should be reverted. I think it's
best that we leave ERT out of this, at least for now. I don't really see
what we gain by making it use the "verbatim" layout --- the cod
On Wed, Oct 24, 2007 at 12:51:00AM +0200, Dov Feldstern wrote:
> Martin Vermeer wrote:
> >On Mon, 22 Oct 2007 23:33:32 +0200
> >Dov Feldstern <[EMAIL PROTECTED]> wrote:
> >
> >>This thread is about a separate problem, which is due to Martin's change
> >>in r21121. I have described above what the p
Martin Vermeer wrote:
On Mon, 22 Oct 2007 23:33:32 +0200
Dov Feldstern <[EMAIL PROTECTED]> wrote:
This thread is about a separate problem, which is due to Martin's change
in r21121. I have described above what the problem is, and provided a
sample file with both the incorrect output, and corre
On Mon, 22 Oct 2007 23:33:32 +0200
Dov Feldstern <[EMAIL PROTECTED]> wrote:
> Abdelrazak Younes wrote:
> > Dov Feldstern wrote:
> >> (This all relates to the situation after undoing the changes to
> >> Text.cpp from r21117)
> >>
> >> At the risk of being proved wrong again (but that's how we lear
Abdelrazak Younes wrote:
Dov Feldstern wrote:
(This all relates to the situation after undoing the changes to
Text.cpp from r21117)
At the risk of being proved wrong again (but that's how we learn ;) )
--- also r21121 breaks bidi. Undoing it fixes the problem.
This is the problem: ERT in RT
17 matches
Mail list logo
