Alfredo Braunstein wrote:
Jean-Marc Lasgouttes wrote:
I like it (fixes a bug, does useful cleanup). You should probably remove
the // finally, invoke the DEPM
comment which looks a bit strange in such a small method.
Done.
OK
I commited it.
Tested, and "paste" now work
Jean-Marc Lasgouttes wrote:
> I like it (fixes a bug, does useful cleanup). You should probably remove
> the // finally, invoke the DEPM
> comment which looks a bit strange in such a small method.
Done.
> OK
I commited it.
A/
> "Alfredo" == Alfredo Braunstein <[EMAIL PROTECTED]> writes:
Alfredo> Abdelrazak Younes wrote:
>> Looks good Alfredo but one question: why don't you just move
>> deleteEmptyParagraphMechanism() to paragraph_funcs as well? Same
>> thing for Text::fixCursorAfterDelete(), this has nothing to do
Alfredo Braunstein wrote:
Abdelrazak Younes wrote:
Looks good Alfredo but one question: why don't you just move
deleteEmptyParagraphMechanism() to paragraph_funcs as well? Same thing
for Text::fixCursorAfterDelete(), this has nothing to do with Text
AFAIS...
I see your point. However, I think
Abdelrazak Younes wrote:
> Looks good Alfredo but one question: why don't you just move
> deleteEmptyParagraphMechanism() to paragraph_funcs as well? Same thing
> for Text::fixCursorAfterDelete(), this has nothing to do with Text
> AFAIS...
I see your point. However, I think they don't belong to
> "Alfredo" == Alfredo Braunstein <[EMAIL PROTECTED]> writes:
Alfredo> Alfredo Braunstein wrote:
>> The problem has nothing to do with env depths, just with cut/past
>> of empty paragraphs. The problem is that Text::acceptChanges on the
>> internal cut/paste paragraph list calls DEPM and this
Alfredo Braunstein wrote:
Alfredo Braunstein wrote:
The problem has nothing to do with env depths, just with cut/past of empty
paragraphs. The problem is that Text::acceptChanges on the internal
cut/paste paragraph list calls DEPM and this removes an empty paragraph at
the beginning.
The fix i
On 6/26/07, Jean-Marc Lasgouttes <[EMAIL PROTECTED]> wrote:
So now we have patch in one place and the explanation in another
place...
http://bugzilla.lyx.org/attachment.cgi?id=1927&action=view
;-)
If only the list wouldn't take 1 hour to get my message in...
A/
> "Alfredo" == Alfredo Braunstein <[EMAIL PROTECTED]> writes:
Alfredo> Seems DEPM was not called after insertion, the following
Alfredo> change to pasteParagraphList (included in the patch) seems to
Alfredo> fix it:
Alfredo> - text->setCursor(cur.top(), ppp.first, ppp.second); +
Alfredo> text
Alfredo Braunstein wrote:
> The problem has nothing to do with env depths, just with cut/past of empty
> paragraphs. The problem is that Text::acceptChanges on the internal
> cut/paste paragraph list calls DEPM and this removes an empty paragraph at
> the beginning.
>
> The fix is to move the bul
> "Alfredo" == Alfredo Braunstein <[EMAIL PROTECTED]> writes:
Alfredo> The problem has nothing to do with env depths, just with
Alfredo> cut/past of empty paragraphs. The problem is that
Alfredo> Text::acceptChanges on the internal cut/paste paragraph list
Alfredo> calls DEPM and this removes
The problem has nothing to do with env depths, just with cut/past of empty
paragraphs. The problem is that Text::acceptChanges on the internal
cut/paste paragraph list calls DEPM and this removes an empty paragraph at
the beginning.
The fix is to move the bulk of acceptChanges to paragraph_funcs (
Helge Hafting wrote:
Environments with depths are not cut/pasted correctly.
Create the following document:
1. Enumerate AA
Standard text with increased depthBB
2. Enumerate goes on CC
3. Enumerate goes on
Now put the cursor after AA, and mark to after BB.
Press ctrl+c (copy)
Move the
Environments with depths are not cut/pasted correctly.
Create the following document:
1. Enumerate AA
Standard text with increased depthBB
2. Enumerate goes on CC
3. Enumerate goes on
Now put the cursor after AA, and mark to after BB.
Press ctrl+c (copy)
Move the cursor to after CC,
14 matches
Mail list logo
