Re: Customization ctests now failing on master

2023-08-15 Thread Jürgen Spitzmüller
Am Samstag, dem 12.08.2023 um 12:47 +0200 schrieb Jürgen Spitzmüller: > > Another possible patch attached > > Yes, this is neat, but I wanted to avoid changing the package loading > order if not absolutely necessary. I came back to this because I like its simplicity and went ahead implementing a

Re: Customization ctests now failing on master

2023-08-13 Thread Jürgen Spitzmüller
Am Sonntag, dem 13.08.2023 um 16:38 +0200 schrieb Jean-Pierre Chrétien: > I think that there are not many prettyref users in general, since > refstyle is much more powerful. Not sure about that. Personally, I never got warm with refstyle and still prefer prettyref (also due to its simplicity). --

Re: Customization ctests now failing on master

2023-08-13 Thread Jean-Pierre Chrétien
Le 12/08/2023 à 12:43, Jürgen Spitzmüller a écrit : I think the approach is sane enough. Since we haven't heard many reports about this bug recently, the case seems to be rather seldom (I suppose French users avoid prettyref). Thanks for solving this issue, Jürgen. I think that there are not

Re: Customization ctests now failing on master

2023-08-12 Thread Jürgen Spitzmüller
Am Samstag, dem 12.08.2023 um 12:18 +0300 schrieb Udicoudco: > > Another possible patch attached Yes, this is neat, but I wanted to avoid changing the package loading order if not absolutely necessary. -- Jürgen -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/lis

Re: Customization ctests now failing on master

2023-08-12 Thread Jürgen Spitzmüller
Am Freitag, dem 11.08.2023 um 23:11 +0300 schrieb Udicoudco: > Jürgen, your code should work, you just forgot > to  change the category code of @. > See the patch prettyref-detokenize.patch. Ouch %-/ Thanks! > But I think we should note it could potentially > change the behaviour of the package,

Re: Customization ctests now failing on master

2023-08-12 Thread Udicoudco
On Fri, Aug 11, 2023 at 11:11 PM Udicoudco wrote: > I propose a different approach. see the patch prettyref.patch. Another possible patch attached > lyx-devel mailing list > lyx-devel@lists.lyx.org > http://lists.lyx.org/mailman/listinfo/lyx-devel diff --git a/src/LaTeXFeatures.cpp b/src/LaTe

Re: Customization ctests now failing on master

2023-08-11 Thread Udicoudco
On Fri, Aug 11, 2023 at 8:09 PM Jürgen Spitzmüller wrote: > > Am Freitag, dem 11.08.2023 um 17:39 +0200 schrieb Jürgen Spitzmüller: > > Should be fixed now. > > Not yet. It does compile, but the references are broken. Jürgen, your code should work, you just forgot to change the category code of

Re: Customization ctests now failing on master

2023-08-11 Thread Udicoudco
On Fri, Aug 11, 2023 at 8:09 PM Jürgen Spitzmüller wrote: > > Am Freitag, dem 11.08.2023 um 17:39 +0200 schrieb Jürgen Spitzmüller: > > Should be fixed now. > > Not yet. It does compile, but the references are broken. I'll see if I I think \def\prettyref#1{\expandafter\@prettyref\expanded{#1\

Re: Customization ctests now failing on master

2023-08-11 Thread Scott Kostyshak
On Fri, Aug 11, 2023 at 07:08:34PM +0200, Jürgen Spitzmüller wrote: > Am Freitag, dem 11.08.2023 um 17:39 +0200 schrieb Jürgen Spitzmüller: > > Should be fixed now. > > Not yet. It does compile, Indeed the tests pass now. > but the references are broken. I'll see if I > can fix that. Otherwise,

Re: Customization ctests now failing on master

2023-08-11 Thread Jürgen Spitzmüller
Am Freitag, dem 11.08.2023 um 17:39 +0200 schrieb Jürgen Spitzmüller: > Should be fixed now. Not yet. It does compile, but the references are broken. I'll see if I can fix that. Otherwise, I'll revert. -- Jürgen signature.asc Description: This is a digitally signed message part -- lyx-devel m

Re: Customization ctests now failing on master

2023-08-11 Thread Jürgen Spitzmüller
Am Freitag, dem 11.08.2023 um 10:56 -0400 schrieb Scott Kostyshak: > Thanks for taking a look, Should be fixed now. -- Jürgen signature.asc Description: This is a digitally signed message part -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: Customization ctests now failing on master

2023-08-11 Thread Scott Kostyshak
On Fri, Aug 11, 2023 at 04:36:20PM +0200, Jürgen Spitzmüller wrote: > Am Freitag, dem 11.08.2023 um 07:56 -0400 schrieb Scott Kostyshak: > > I get the following: > > > >   export/doc/Customization_lyx22 (Failed) > >   export/doc/Customization_lyx23 (Failed) > >   export/doc/Customization_dvi (Fail

Re: Customization ctests now failing on master

2023-08-11 Thread Scott Kostyshak
On Fri, Aug 11, 2023 at 03:29:58PM +0100, José Matos wrote: > On Fri, 2023-08-11 at 07:56 -0400, Scott Kostyshak wrote: > > I get the following: > > > >   export/doc/Customization_lyx22 (Failed) > >   export/doc/Customization_lyx23 (Failed) > >   export/doc/Customization_dvi (Failed) > >   export/

Re: Customization ctests now failing on master

2023-08-11 Thread Jürgen Spitzmüller
Am Freitag, dem 11.08.2023 um 07:56 -0400 schrieb Scott Kostyshak: > I get the following: > >   export/doc/Customization_lyx22 (Failed) >   export/doc/Customization_lyx23 (Failed) >   export/doc/Customization_dvi (Failed) >   export/doc/Customization_pdf (Failed) >   DEFAULTOUTPUT_export/doc/Custo

Re: Customization ctests now failing on master

2023-08-11 Thread Jürgen Spitzmüller
Am Freitag, dem 11.08.2023 um 07:56 -0400 schrieb Scott Kostyshak: > I get the following: > >   export/doc/Customization_lyx22 (Failed) >   export/doc/Customization_lyx23 (Failed) >   export/doc/Customization_dvi (Failed) >   export/doc/Customization_pdf (Failed) >   DEFAULTOUTPUT_export/doc/Custo

Re: Customization ctests now failing on master

2023-08-11 Thread José Matos
On Fri, 2023-08-11 at 07:56 -0400, Scott Kostyshak wrote: > I get the following: > >   export/doc/Customization_lyx22 (Failed) >   export/doc/Customization_lyx23 (Failed) >   export/doc/Customization_dvi (Failed) >   export/doc/Customization_pdf (Failed) >   DEFAULTOUTPUT_export/doc/Customization_

Customization ctests now failing on master

2023-08-11 Thread Scott Kostyshak
I get the following: export/doc/Customization_lyx22 (Failed) export/doc/Customization_lyx23 (Failed) export/doc/Customization_dvi (Failed) export/doc/Customization_pdf (Failed) DEFAULTOUTPUT_export/doc/Customization_pdf2 (Failed) export/doc/Customization_pdf3 (Failed) Scott signatur