Re: Crash when BibTex Bibliography file not accessible

2006-08-29 Thread Juergen Spitzmueller
Lars Gullik Bjønnes wrote: > That looks quite ok. Please commit. Done. Jürgen

Re: Crash when BibTex Bibliography file not accessible

2006-08-29 Thread Lars Gullik Bjønnes
Juergen Spitzmueller <[EMAIL PROTECTED]> writes: | Lars Gullik Bjønnes wrote: | > You mean something like this: | | Yes, but I think we should return a proper error message (popup) in this case | (like we do in 1.4), additionally to the verbose fs debug message. See the | attached patch. That

Re: Crash when BibTex Bibliography file not accessible

2006-08-29 Thread Juergen Spitzmueller
Lars Gullik Bjønnes wrote: > You mean something like this: Yes, but I think we should return a proper error message (popup) in this case (like we do in 1.4), additionally to the verbose fs debug message. See the attached patch. Jürgen Index: src/buffer.C

Re: Crash when BibTex Bibliography file not accessible

2006-08-28 Thread Lars Gullik Bjønnes
Juergen Spitzmueller <[EMAIL PROTECTED]> writes: | Lars Gullik Bjønnes wrote: | > Can you try this one Jurgen? | | It fixes the given bug as well as my patch (and gives a nice debug message). | Note, while you are at it, that there is a similar pending case in | buffer::save: | http://bugzilla.l

Re: Crash when BibTex Bibliography file not accessible

2006-08-28 Thread Juergen Spitzmueller
Lars Gullik Bjønnes wrote: > Can you try this one Jurgen? It fixes the given bug as well as my patch (and gives a nice debug message). Note, while you are at it, that there is a similar pending case in buffer::save: http://bugzilla.lyx.org/show_bug.cgi?id=2740 Jürgen

Re: Crash when BibTex Bibliography file not accessible

2006-08-28 Thread Lars Gullik Bjønnes
Juergen Spitzmueller <[EMAIL PROTECTED]> writes: | Lars Gullik Bjønnes wrote: | > Right. | | OK. Can you resend the patch as an attachment, please? It's | difficult to apply the inline version. Index: src/insets/insetcite.C === ---

Re: Crash when BibTex Bibliography file not accessible

2006-08-28 Thread Juergen Spitzmueller
Lars Gullik Bjønnes wrote: > Right. OK. Can you resend the patch as an attachment, please? It's difficult to apply the inline version. Jürgen

Re: Crash when BibTex Bibliography file not accessible

2006-08-28 Thread Lars Gullik Bjønnes
Juergen Spitzmueller <[EMAIL PROTECTED]> writes: | Lars Gullik Bjønnes wrote: | > Can you try this one Jurgen? | | This is only for 1.5, right? Right. -- Lgb

Re: Crash when BibTex Bibliography file not accessible

2006-08-28 Thread Juergen Spitzmueller
Lars Gullik Bjønnes wrote: > Can you try this one Jurgen? This is only for 1.5, right? Jürgen

Re: Crash when BibTex Bibliography file not accessible

2006-08-20 Thread Lars Gullik Bjønnes
Juergen Spitzmueller <[EMAIL PROTECTED]> writes: | Jean-Marc Lasgouttes wrote: | > You can apply, then. | | After some more testing of the OP, it turned out that the crash actually | occurs if the directory where the bib file lives is not readable. I can | reproduce the crash, and the attached

Re: Crash when BibTex Bibliography file not accessible

2006-08-19 Thread Jean-Marc Lasgouttes
> "Juergen" == Juergen Spitzmueller <[EMAIL PROTECTED]> writes: Juergen> Jean-Marc Lasgouttes wrote: >> You mean that the file exists but is not readable? Juergen> The file exists but is in a non-readable directory. Actually, Juergen> it does not matter whether the file itself is readable or

Re: Crash when BibTex Bibliography file not accessible

2006-08-19 Thread Juergen Spitzmueller
Jean-Marc Lasgouttes wrote: > You mean that the file exists but is not readable? The file exists but is in a non-readable directory. Actually, it does not matter whether the file itself is readable or not (a non-readable file in a readable directory does not lead to problems). I'm not sure what

Re: Crash when BibTex Bibliography file not accessible

2006-08-18 Thread Jean-Marc Lasgouttes
> "Juergen" == Juergen Spitzmueller <[EMAIL PROTECTED]> writes: Juergen> Jean-Marc Lasgouttes wrote: >> You can apply, then. Juergen> After some more testing of the OP, it turned out that the Juergen> crash actually occurs if the directory where the bib file Juergen> lives is not readable. I

Re: Crash when BibTex Bibliography file not accessible

2006-08-18 Thread Juergen Spitzmueller
Jean-Marc Lasgouttes wrote: > You can apply, then. After some more testing of the OP, it turned out that the crash actually occurs if the directory where the bib file lives is not readable. I can reproduce the crash, and the attached patch fixes it. OK? Jürgen Index: src/insets/insetcite.C ===

Re: Crash when BibTex Bibliography file not accessible

2006-08-18 Thread Jean-Marc Lasgouttes
> "Juergen" == Juergen Spitzmueller <[EMAIL PROTECTED]> writes: Juergen> Jean-Marc Lasgouttes wrote: >> Can I see the patch? From what you say it looks reasonable. Juergen> Certainly. Juergen> Perhaps we could spit out a message when a file is not found. >> Yes, but only once per file... If

Re: Crash when BibTex Bibliography file not accessible

2006-08-18 Thread Juergen Spitzmueller
Jean-Marc Lasgouttes wrote: > Can I see the patch? From what you say it looks reasonable. Certainly. > Juergen> Perhaps we could spit out a message when a file is not found. > > Yes, but only once per file... If this is too compilcated, I prefer no > message to too many messages. I think this is

Re: Crash when BibTex Bibliography file not accessible

2006-08-18 Thread Georg Baum
Jean-Marc Lasgouttes wrote: >> "Juergen" == Juergen Spitzmueller >> <[EMAIL PROTECTED]> writes: > > Juergen> Perhaps we could spit out a message when a file is not found. > > Yes, but only once per file... If this is too compilcated, I prefer no > message to too many messages. We have s

Re: Crash when BibTex Bibliography file not accessible

2006-08-18 Thread Jean-Marc Lasgouttes
> "Juergen" == Juergen Spitzmueller <[EMAIL PROTECTED]> writes: Juergen> Juergen Spitzmueller wrote: >> It doesn't crash for me (SuSe 10.1, self-compiled), but I assume >> that the attached patch will help. Juergen> I think the patch should go in in any case, since Juergen> filesystem::last_w

Re: Crash when BibTex Bibliography file not accessible

2006-08-18 Thread Juergen Spitzmueller
Juergen Spitzmueller wrote: > It doesn't crash for me (SuSe 10.1, self-compiled), but I assume that the > attached patch will help. I think the patch should go in in any case, since filesystem::last_write_time(f) throws if !filesystem::exists(f). I don't know why it doesn't for me (exceptions di

Re: Crash when BibTex Bibliography file not accessible

2006-08-18 Thread Juergen Spitzmueller
Rainer M Krug wrote: > Sorry - LyX 1.4.2, SuSe 10.1, installed from rpm via www.lyx.org. It doesn't crash for me (SuSe 10.1, self-compiled), but I assume that the attached patch will help. Jürgen Index: src/insets/insetcite.C === --