Re: CharStyle metrics broken in 1.5.3

2008-01-05 Thread Pavel Sanda
> >I suggest that you use the version from the 1.5 svn branch instead of > >1.5.3. This is what all LyX developers (should) do. It would be > >wonderful if more advanced users (like you?) do the same. This would > >help us catch more bugs like this one before the actual release. > > Yes, I do t

Re: CharStyle metrics broken in 1.5.3

2007-12-23 Thread rgheck
Abdelrazak Younes wrote: Darren Freeman wrote: On Sat, 2007-12-22 at 16:56 +0100, Jürgen Spitzmüller wrote: Abdelrazak Younes wrote: Here is the patch. Please commit it yourself as I have to go. Done. I suggest a 1.5.4 release ASAP. No need to hurry IMO. Why not keep the branch somewhat

Re: CharStyle metrics broken in 1.5.3

2007-12-23 Thread Darren Freeman
On Sun, 2007-12-23 at 11:46 +0100, Abdelrazak Younes wrote: > Darren Freeman wrote: > > On Sat, 2007-12-22 at 16:56 +0100, Jürgen Spitzmüller wrote: > >> Abdelrazak Younes wrote: > >>> Here is the patch. Please commit it yourself as I have to go. > >> Done. > >> > >>> I suggest a 1.5.4 release ASA

Re: CharStyle metrics broken in 1.5.3

2007-12-23 Thread Jürgen Spitzmüller
Abdelrazak Younes wrote: > I really thought that this bug made the charstyles unusable. If that's > not the case then let's wait for 1.5.4 when it is ready, which should be > the case already, shouldn't it Juergen? You mean: ready for release? If the view-source issue is fixed, yes. But it doesn'

Re: CharStyle metrics broken in 1.5.3

2007-12-23 Thread Abdelrazak Younes
Darren Freeman wrote: On Sat, 2007-12-22 at 16:56 +0100, Jürgen Spitzmüller wrote: Abdelrazak Younes wrote: Here is the patch. Please commit it yourself as I have to go. Done. I suggest a 1.5.4 release ASAP. No need to hurry IMO. Why not keep the branch somewhat frozen and release 1.5.3.1

Re: CharStyle metrics broken in 1.5.3

2007-12-23 Thread Abdelrazak Younes
Bo Peng wrote: No need to hurry IMO. Why not keep the branch somewhat frozen and release 1.5.3.1 after another week of fixing/testing? I also see no hurry. I used charstyle and I did not notice it either. I think an emergency release is only needed for file corruption bugs such as the iostream

Re: CharStyle metrics broken in 1.5.3

2007-12-23 Thread Jürgen Spitzmüller
Bo Peng wrote: > I also see no hurry. I used charstyle and I did not notice it either. > I think an emergency release is only needed for file corruption bugs > such as the iostreams/gzip bug we had for 1.5.0. Exactly. And we'll surely get more reports once 1.5.3 is in wider use. Jürgen

Re: CharStyle metrics broken in 1.5.3

2007-12-22 Thread Bo Peng
> > No need to hurry IMO. > > Why not keep the branch somewhat frozen and release 1.5.3.1 after > another week of fixing/testing? I also see no hurry. I used charstyle and I did not notice it either. I think an emergency release is only needed for file corruption bugs such as the iostreams/gzip bu

Re: CharStyle metrics broken in 1.5.3

2007-12-22 Thread Darren Freeman
On Sat, 2007-12-22 at 16:56 +0100, Jürgen Spitzmüller wrote: > Abdelrazak Younes wrote: > > Here is the patch. Please commit it yourself as I have to go. > > Done. > > > I suggest a 1.5.4 release ASAP. > > No need to hurry IMO. Why not keep the branch somewhat frozen and release 1.5.3.1 after

Re: CharStyle metrics broken in 1.5.3

2007-12-22 Thread Jürgen Spitzmüller
Abdelrazak Younes wrote: > Here is the patch. Please commit it yourself as I have to go. Done. > I suggest a 1.5.4 release ASAP. No need to hurry IMO. Jürgen

Re: CharStyle metrics broken in 1.5.3

2007-12-22 Thread Abdelrazak Younes
Jürgen Spitzmüller wrote: Abdelrazak Younes wrote: It's even worse than I thought (there's a user report about this). I have to admit I never used charstyles with 1.5.x; obviously I should have tested it (and I am sorry for that Juergen) but I am amazed that nobody noticed that before the releas

Re: CharStyle metrics broken in 1.5.3

2007-12-22 Thread Abdelrazak Younes
Jürgen Spitzmüller wrote: Abdelrazak Younes wrote: It's even worse than I thought (there's a user report about this). I have to admit I never used charstyles with 1.5.x; obviously I should have tested it (and I am sorry for that Juergen) but I am amazed that nobody noticed that before the releas

Re: CharStyle metrics broken in 1.5.3

2007-12-22 Thread Jürgen Spitzmüller
Abdelrazak Younes wrote: > It's even worse than I thought (there's a user report about this). I > have to admit I never used charstyles with 1.5.x; obviously I should > have tested it (and I am sorry for that Juergen) but I am amazed that > nobody noticed that before the release. Nobody's using cha

Re: CharStyle metrics broken in 1.5.3

2007-12-22 Thread Abdelrazak Younes
Abdelrazak Younes wrote: Enrico Forestieri wrote: On Fri, Dec 21, 2007 at 09:31:24PM +0100, Abdelrazak Younes wrote: Enrico Forestieri wrote: Load the attached .lyx file using 1.5.3 or 1.5.4svn and move the cursor inside the inset to see it. What do you mean exactly by broken? I can see that

Re: CharStyle metrics broken in 1.5.3

2007-12-21 Thread Abdelrazak Younes
Enrico Forestieri wrote: On Fri, Dec 21, 2007 at 09:31:24PM +0100, Abdelrazak Younes wrote: Enrico Forestieri wrote: Load the attached .lyx file using 1.5.3 or 1.5.4svn and move the cursor inside the inset to see it. What do you mean exactly by broken? I can see that the cursor looks like it

Re: CharStyle metrics broken in 1.5.3

2007-12-21 Thread Enrico Forestieri
On Fri, Dec 21, 2007 at 09:31:24PM +0100, Abdelrazak Younes wrote: > Enrico Forestieri wrote: > > Load the attached .lyx file using 1.5.3 or 1.5.4svn and move the > > cursor inside the inset to see it. > > What do you mean exactly by broken? I can see that the cursor looks like > it is inside th

Re: CharStyle metrics broken in 1.5.3

2007-12-21 Thread Abdelrazak Younes
Enrico Forestieri wrote: Load the attached .lyx file using 1.5.3 or 1.5.4svn and move the cursor inside the inset to see it. What do you mean exactly by broken? I can see that the cursor looks like it is inside the inset when in front of it; is it what you mean? Abdel.

Re: CharStyle metrics broken in 1.5.3

2007-12-21 Thread Abdelrazak Younes
Enrico Forestieri wrote: Load the attached .lyx file using 1.5.3 or 1.5.4svn and move the cursor inside the inset to see it. This is a side effect of r21428. Should be easy to fix, Abdel. I'll have a look. Abdel.

CharStyle metrics broken in 1.5.3

2007-12-21 Thread Enrico Forestieri
Load the attached .lyx file using 1.5.3 or 1.5.4svn and move the cursor inside the inset to see it. This is a side effect of r21428. Should be easy to fix, Abdel. -- Enrico #LyX 1.5.3 created this file. For more info see http://www.lyx.org/ \lyxformat 276 \begin_document \begin_header \textclass