Re: Change tracking and replace: unexpected behavior

2007-06-09 Thread Jürgen Spitzmüller
Michael Gerz wrote: > IMHO, "find & replace" should always ignore deleted text, in CT mode as > well as in non-CT mode. That's what my patch does. I'm just waiting for your testing. Jürgen

Re: Change tracking and replace: unexpected behavior

2007-06-09 Thread Michael Gerz
Helge Hafting schrieb: If you turn off change tracking and edit, then surely all new stuff should be without the change tracking markings. (i.e. not deleted or marked as inserted by someone.) You may be able to add inside a deleted region, but that should split the deleted region in two. That'

Re: Change tracking and replace: unexpected behavior

2007-06-09 Thread Michael Gerz
Bennett Helm schrieb: I agree with the last sentence, but notice that the patch doesn't do this! When change tracking is turned off, it is entirely possible to delete -- remove from the file -- text that is marked as deleted. Right. Even if we prohibited it, the user may always accept deleted te

Re: Change tracking and replace: unexpected behavior

2007-06-08 Thread Bennett Helm
On Jun 8, 2007, at 3:16 AM, Jürgen Spitzmüller wrote: Jean-Marc Lasgouttes wrote: I think we should restrict manual replace too (if possible). It should not be allowed to do with replace something that would not be possible via normal editing. attached is a complete patch that includes ma

Re: Change tracking and replace: unexpected behavior

2007-06-08 Thread Jürgen Spitzmüller
Jean-Marc Lasgouttes wrote: > I think we should restrict manual replace too (if possible). It should > not be allowed to do with replace something that would not be possible > via normal editing. attached is a complete patch that includes manual replace (but not, editing). Jürgen Index: src/lyxfi

Re: Change tracking and replace: unexpected behavior

2007-06-07 Thread Michael Gerz
Jürgen Spitzmüller schrieb: Jean-Marc Lasgouttes wrote: I think we should restrict manual replace too (if possible). It should not be allowed to do with replace something that would not be possible via normal editing. Probably. Although OpenOffice allows this (and so does Word). Howeve

Re: Change tracking and replace: unexpected behavior

2007-06-06 Thread Bennett Helm
On Jun 6, 2007, at 4:38 AM, Helge Hafting wrote: Bennett Helm wrote: On Jun 5, 2007, at 9:52 AM, Jean-Marc Lasgouttes wrote: "Jürgen" == Jürgen Spitzmüller <[EMAIL PROTECTED]> writes: Jürgen> Bennett Helm wrote: Create a document with multiple occurrences of "foo". Turn change tracking on,

Re: Change tracking and replace: unexpected behavior

2007-06-06 Thread Helge Hafting
Bennett Helm wrote: On Jun 5, 2007, at 9:52 AM, Jean-Marc Lasgouttes wrote: "Jürgen" == Jürgen Spitzmüller <[EMAIL PROTECTED]> writes: Jürgen> Bennett Helm wrote: Create a document with multiple occurrences of "foo". Turn change tracking on, select a chunk of text (including some occurrences

Re: Change tracking and replace: unexpected behavior

2007-06-05 Thread Bennett Helm
On Jun 5, 2007, at 9:52 AM, Jean-Marc Lasgouttes wrote: "Jürgen" == Jürgen Spitzmüller <[EMAIL PROTECTED]> writes: Jürgen> Bennett Helm wrote: Create a document with multiple occurrences of "foo". Turn change tracking on, select a chunk of text (including some occurrences of "foo"), and del

Re: Change tracking and replace: unexpected behavior

2007-06-05 Thread Jürgen Spitzmüller
Jean-Marc Lasgouttes wrote: > I think we should restrict manual replace too (if possible). It should > not be allowed to do with replace something that would not be possible > via normal editing. Probably. Although OpenOffice allows this (and so does Word). However, we are not forced to emulate t

Re: Change tracking and replace: unexpected behavior

2007-06-05 Thread Jean-Marc Lasgouttes
> "Jürgen" == Jürgen Spitzmüller <[EMAIL PROTECTED]> writes: Jürgen> Bennett Helm wrote: >> Create a document with multiple occurrences of "foo". Turn change   >> tracking on, select a chunk of text (including some occurrences of >>   "foo"), and delete. Now go to the top and turn change track

Re: Change tracking and replace: unexpected behavior

2007-06-05 Thread Jürgen Spitzmüller
Bennett Helm wrote: > Create a document with multiple occurrences of "foo". Turn change   > tracking on, select a chunk of text (including some occurrences of   > "foo"), and delete. Now go to the top and turn change tracking *off*.   > Using Edit > Find & Replace, Replace all instances of "foo" wi

Change tracking and replace: unexpected behavior

2007-06-04 Thread Bennett Helm
I just noticed that searching for and replacing text interacts with change tracking in an unexpected way. Create a document with multiple occurrences of "foo". Turn change tracking on, select a chunk of text (including some occurrences of "foo"), and delete. Now go to the top and turn chang