What is so different about this type of notes?
Note: no output, should not break screen paragraph.
Comment: no output (with latex output), should not break screen paragraph
Gray out: part of paragraph, should be displayed as such (inline)
Other two: output in a separate paragraph, should be dis
> "Bo" == Bo Peng <[EMAIL PROTECTED]> writes:
>> Is this part really related?
>>
>> +Inset::DisplayType InsetNote::display() const +{ + switch
>> (params_.type) { + case InsetNoteParams::Framed: + case
>> InsetNoteParams::Shaded: + return AlignLeft; + default: + return
>> Inline;
>> + }
Is this part really related?
+Inset::DisplayType InsetNote::display() const
+{
+ switch (params_.type) {
+ case InsetNoteParams::Framed:
+ case InsetNoteParams::Shaded:
+ return AlignLeft;
+ default:
+ return Inline;
+ }
+}
This part is
> "Bo" == Bo Peng <[EMAIL PROTECTED]> writes:
>> OK. Thank you, with this code bug 3598 seems harmless enough to
>> fixed later. :-)
Bo> Attached patch fixes 3598 and a more serious bug of framed notes:
Bo> color is not required so 'new document, insert->framed note,
Bo> compile' would fail.
On Friday 18 May 2007 4:13:33 pm Bo Peng wrote:
> > OK. Thank you, with this code bug 3598 seems harmless enough to fixed
> > later. :-)
>
> Attached patch fixes 3598 and a more serious bug of framed notes:
> color is not required so 'new document, insert->framed note, compile'
> would fail.
>
>
OK. Thank you, with this code bug 3598 seems harmless enough to fixed
later. :-)
Attached patch fixes 3598 and a more serious bug of framed notes:
color is not required so 'new document, insert->framed note, compile'
would fail.
OK to apply?
Bo
Index: src/insets/InsetNote.cpp
===
On Friday 18 May 2007 3:33:19 pm Bo Peng wrote:
> I do not change the interface of any other Insets such as
> InsetInclude. Bug 3598 can be handled later.
OK. Thank you, with this code bug 3598 seems harmless enough to fixed
later. :-)
> Cheers,
> Bo
--
José Abílio
So I'm fine with Bo's patch.
Done (18404).
I do not change the interface of any other Insets such as
InsetInclude. Bug 3598 can be handled later.
Cheers,
Bo
José Matos wrote:
> Yet since this is a potential change in the interface I would like to hear
> other developers before continuing. If the majority likes this then it can
> go as it is before rc1. OK?
On the ui side, I like listings to be displayed on the left, but on a separate
paragraph (as Bo
Technically I think this solution is perfect for the purpose that it was
created.
Yet since this is a potential change in the interface I would like to hear
other developers before continuing. If the majority likes this then it can go
as it is before rc1. OK?
Sure. I will wait for one mor
On Thursday 17 May 2007 10:33:05 pm Bo Peng wrote:
> See attached.
>
> Jose?
Technically I think this solution is perfect for the purpose that it was
created.
Yet since this is a potential change in the interface I would like to hear
other developers before continuing. If the majority likes
I was thinking about display in the same sense as a inline versus display
equation.
I like this paradigm. What is your reason to change this?
I consider displayed as occupying the who paragraph, nothing to its
left or right. Displayed math formula is of course a perfect example
of this, b
On Thursday 17 May 2007 3:37:56 pm Bo Peng wrote:
> Dear all,
>
> InsetListings, like InsetInclude uses display() to aligh itself in the
> center. However, it is more natural to have them displayed (separate
> paragraph), but shift to the left.
I was thinking about display in the same sense as a
If you return an enum instead of a bool there won't be much line
changed, something like that:
enum DisplayType {
Inline = 0,
AlignRight,
AlignLeft,
AlignCenter
};
See attached.
Jose?
Bo
Index: src/insets/InsetTabular.h
=
Bo Peng wrote:
So, I'd personally prefer that you extent Inset::display() to pass the
default paragraph alignment.
Abdel.
Then I will have to change the interface of display() for all insets.
It is ok if intrusiveness is not judged by the number of lines
changed.
If you return an enum instea
> "Bo" == Bo Peng <[EMAIL PROTECTED]> writes:
>> Will the attached patch be acceptable? If people like it, I can
>> set displayLeft to InsetInclude as well.
Bo> Following the trend to yell out loud... Jose??
Bo> Be careful that this adds another virtual function to Inset, and I
Bo> may be r
Bo Peng wrote:
Will the attached patch be acceptable? If people like it, I can set
displayLeft to InsetInclude as well.
Following the trend to yell out loud... Jose??
Did you notice how effective that was?
Be careful that this adds another virtual function to Inset, and I may
be reinventi
Will the attached patch be acceptable? If people like it, I can set
displayLeft to InsetInclude as well.
Following the trend to yell out loud... Jose??
Be careful that this adds another virtual function to Inset, and I may
be reinventing the wheel...
Bo
Dear all,
InsetListings, like InsetInclude uses display() to aligh itself in the
center. However, it is more natural to have them displayed (separate
paragraph), but shift to the left.
Will the attached patch be acceptable? If people like it, I can set
displayLeft to InsetInclude as well.
Bo
I
19 matches
Mail list logo
