Re: [patch] Bug 3522: german umlaut does not work in math preview

2007-05-28 Thread Abdelrazak Younes
Jürgen Spitzmüller wrote: http://bugzilla.lyx.org/show_bug.cgi?id=3522 reviewed and approved by Georg. The patch does the following: - it moves all the encoding checks in BufferParams::writeLaTeX to an own function "writeEncodingPreamble" and (so in BufferParams.cpp most is just code-shu

Re: [patch] Bug 3522: german umlaut does not work in math preview

2007-05-27 Thread José Matos
On Sunday 27 May 2007 16:27:35 Jürgen Spitzmüller wrote: > I'm waiting for José's turn. I don't want to interfere his RC1 work. I will release RC1 later today, you can proceed. :-) > Thanks for testing. > Jürgen -- José Abílio

Re: [patch] Bug 3522: german umlaut does not work in math preview

2007-05-27 Thread Jürgen Spitzmüller
Uwe Stöhr wrote: > Works here on Windows too. > It is also reviewed by Georg so I say, put it in. I'm waiting for José's turn. I don't want to interfere his RC1 work. Thanks for testing. Jürgen

Re: [patch] Bug 3522: german umlaut does not work in math preview

2007-05-27 Thread Uwe Stöhr
reviewed and approved by Georg. I tested it with several encodings. Seems to work fine (more testing is appreciated, though). Works here on Windows too. It is also reviewed by Georg so I say, put it in. regards Uwe

[patch] Bug 3522: german umlaut does not work in math preview

2007-05-26 Thread Jürgen Spitzmüller
http://bugzilla.lyx.org/show_bug.cgi?id=3522 reviewed and approved by Georg. The patch does the following: - it moves all the encoding checks in BufferParams::writeLaTeX to an own function "writeEncodingPreamble" and (so in BufferParams.cpp most is just code-shuffling) - accesses that from

Re: Bug 3522, german umlaut does not work in math preview

2007-05-09 Thread Jean-Marc Lasgouttes
> "José" == José Matos <[EMAIL PROTECTED]> writes: José> BTW what is the minimum requirement for utf8 support? I am José> asking this because we require a latex version newer than José> 1995/12/01, what is there so special about this date? :-) You'd have to check the relevant ltnews to be s

Re: Bug 3522, german umlaut does not work in math preview

2007-05-08 Thread José Matos
On Sunday 06 May 2007 11:28:33 Jürgen Spitzmüller wrote: > - Is it correct to always use utf8 for preview? Basically, this breaks > preview-latex for older distributions that do not feature utf8. Ideally, we > should use the encoding of the document (if possible). I agree. BTW what is the min

Re: Bug 3522, german umlaut does not work in math preview

2007-05-06 Thread Jürgen Spitzmüller
Peter Kümmel wrote: > So why should Jürgen's patch not be correct? > When from_utf8 is used then we need a utf8 encoding. Several things need to be considered: - Is it correct to always use utf8 for preview? Basically, this breaks preview-latex for older distributions that do not feature utf8. I

Bug 3522, german umlaut does not work in math preview

2007-05-06 Thread Peter Kümmel
--- Additional Comment #4 From Juergen Spitzmueller 2007-05-05 12:02 --- The problem is that LyX passes the text to preview-latex as a utf8-encoded file, but doesn't indicate that with an appropriate inputenc option. Have a look at the FIXME in PreviewLoader.cpp: 573. A simple way to g