Re: Big memory leak in InsetText

2000-09-25 Thread Jean-Marc Lasgouttes
> "Juergen" == Juergen Vigna <[EMAIL PROTECTED]> writes: Juergen> On 25-Sep-2000 Jean-Marc Lasgouttes wrote: >> => LyXParagraph * par = new LyXParagraph; Juergen> Fixed! Fine! I'll try it out when you commit. JMarc

Re: Big memory leak in InsetText

2000-09-25 Thread Juergen Vigna
On 25-Sep-2000 Jean-Marc Lasgouttes wrote: > >=> LyXParagraph * par = new LyXParagraph; Fixed! Jürgen -- -._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._ Dr. Jürgen VignaE-Mail: [EMAIL PROTECTED] Italienallee 13/N

Re: Big memory leak in InsetText

2000-09-25 Thread Jean-Marc Lasgouttes
> "Juergen" == Juergen Vigna <[EMAIL PROTECTED]> writes: Juergen> On 23-Sep-2000 Lars Gullik Bjønnes wrote: >> This is correct. Objects will be deleted, pointers to objects too, >> but not the objects pointed to. Juergen> I soon will commit a fix for this, Jean-Marc could you then Juergen>

Re: Big memory leak in InsetText

2000-09-25 Thread Jean-Marc Lasgouttes
> "Juergen" == Juergen Vigna <[EMAIL PROTECTED]> writes: Juergen> On 23-Sep-2000 Lars Gullik Bjønnes wrote: >> This is correct. Objects will be deleted, pointers to objects too, >> but not the objects pointed to. Juergen> I soon will commit a fix for this, Jean-Marc could you then Juergen>

Re: Big memory leak in InsetText

2000-09-25 Thread Juergen Vigna
On 23-Sep-2000 Lars Gullik Bjønnes wrote: > > This is correct. Objects will be deleted, pointers to objects too, but > not the objects pointed to. I soon will commit a fix for this, Jean-Marc could you then have another look? Jürgen -- -._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._

Re: Big memory leak in InsetText

2000-09-22 Thread Lars Gullik Bjønnes
Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: | > "Juergen" == Juergen Vigna <[EMAIL PROTECTED]> writes: | | Juergen> You're right, but I thought that was done automatically when | Juergen> cache is deleted! If this is NOT the case (and it seems like | Juergen> that) we just have to put t

Re: Big memory leak in InsetText

2000-09-22 Thread Angus Leeming
A quick look in FormPreferences reveals that there are the following xform FORMs, but only dialog_ is deleted in the destructor. I think that this is a bug. Each should be deleted. Allan? Jean-Marc, as there is no free() in this class, it means that the xforms FORMS are to be detroyed only whe

Re: Big memory leak in InsetText

2000-09-22 Thread Jean-Marc Lasgouttes
> "Angus" == Angus Leeming <[EMAIL PROTECTED]> writes: Angus> I think that this is an example of evolving code! Some of the Angus> xforms FORMs are explicitly freed when the dialog is hidden. Angus> Most are not and the xforms FORM is destroyed only when the Angus> dialog is deleted itself.

Re: Big memory leak in InsetText

2000-09-22 Thread Angus Leeming
I think that this is an example of evolving code! Some of the xforms FORMs are explicitly freed when the dialog is hidden. Most are not and the xforms FORM is destroyed only when the dialog is deleted itself. Angus On Fri, 22 Sep 2000, Jean-Marc Lasgouttes wrote: > > "Juergen" == Juergen

Re: Big memory leak in InsetText

2000-09-22 Thread Angus Leeming
> The forms should be freed I see in FormDocument:~FormDocument(): > > free() > > Where in free() > ... > if (paper_) { > fl_free_form(paper_->form); > delete paper_; > paper_ = 0; > } > ... > fl_free_form(dialog_->form); > dele

Re: Big memory leak in InsetText

2000-09-22 Thread Jean-Marc Lasgouttes
> "Juergen" == Juergen Vigna <[EMAIL PROTECTED]> writes: Juergen> You're right, but I thought that was done automatically when Juergen> cache is deleted! If this is NOT the case (and it seems like Juergen> that) we just have to put the explicit delete of this in Juergen> ~InsetText(). But how

RE: Big memory leak in InsetText

2000-09-22 Thread Juergen Vigna
On 22-Sep-2000 Jean-Marc Lasgouttes wrote: [snip] >=> LyXText * lt = new LyXText(const_cast(this)); > lt->init(bv); > cache[bv] = lt; [snip] > > Juergen, it seems that the cache should be freed at some point... > You're right, but

Big memory leak in InsetText

2000-09-22 Thread Jean-Marc Lasgouttes
After loading the UserGuide under purify and moving around a bit (nothing ugly appeared :), I got a report of 575k of memory leaks, of which 500k come from the same place in InsetText (there are others similar entries): MLK: 261120 bytes leaked in 640 blocks This memory was all