Re: Better Fix for 3109

2007-03-29 Thread Abdelrazak Younes
Richard Heck wrote: Abdelrazak Younes wrote: Richard Heck wrote: The issue was that the newcolors_ were being checked against prefcolors_ to make sure the color had changed, but prefcolors_ contained the colors from the preferences file and was not updated when changes were made. Hence any atte

Re: Better Fix for 3109

2007-03-29 Thread Richard Heck
Abdelrazak Younes wrote: > Richard Heck wrote: >> The issue was that the newcolors_ were being checked against prefcolors_ >> to make sure the color had changed, but prefcolors_ contained the colors >> from the preferences file and was not updated when changes were made. >> Hence any attempt to rev

Re: Better Fix for 3109

2007-03-28 Thread Abdelrazak Younes
Richard Heck wrote: OK, now I've learned about mutable. This seems to be a better patch for 3109. Comments requested before I commit. This one is better ;-) The issue was that the newcolors_ were being checked against prefcolors_ to make sure the color had changed, but prefcolors_ contained

Better Fix for 3109

2007-03-28 Thread Richard Heck
OK, now I've learned about mutable. This seems to be a better patch for 3109. Comments requested before I commit. The issue was that the newcolors_ were being checked against prefcolors_ to make sure the color had changed, but prefcolors_ contained the colors from the preferences file and was not