Re: Bad Math Display Regression in 2.3.x

2017-10-16 Thread Jean-Marc Lasgouttes
Le 13/10/2017 à 20:38, Richard Heck a écrit : On 10/12/2017 04:08 PM, Jean-Marc Lasgouttes wrote: Le 08/10/2017 à 08:56, Jean-Marc Lasgouttes a écrit : The bisect is probably enough for me to find the bug (he said confidently). Here is a tentative patch that I will not be able to test and pus

Re: Bad Math Display Regression in 2.3.x

2017-10-14 Thread Scott Kostyshak
On Sat, Oct 14, 2017 at 07:06:06AM +, Jean-Marc Lasgouttes wrote: > Le 14 octobre 2017 04:39:49 GMT+02:00, Scott Kostyshak a > écrit : > >Are you proposing this patch for 2.3.x? I remember that I could not > >reproduce the issue on 2.3.x, but I think that others could, right? > > > No, this

Re: Bad Math Display Regression in 2.3.x

2017-10-14 Thread Jean-Marc Lasgouttes
Le 14 octobre 2017 04:39:49 GMT+02:00, Scott Kostyshak a écrit : >Are you proposing this patch for 2.3.x? I remember that I could not >reproduce the issue on 2.3.x, but I think that others could, right? No, this is only related to the new painting scheme in the properpaint branch. Basically wh

Re: Bad Math Display Regression in 2.3.x

2017-10-13 Thread Richard Heck
On 10/13/2017 10:39 PM, Scott Kostyshak wrote: > On Fri, Oct 13, 2017 at 07:04:39PM +, Jean-Marc Lasgouttes wrote: >> Le 13 octobre 2017 20:38:47 GMT+02:00, Richard Heck a écrit >> : >>> I don't really know this part of the code, so I can't really comment on >>> that. But I can confirm that t

Re: Bad Math Display Regression in 2.3.x

2017-10-13 Thread Scott Kostyshak
On Fri, Oct 13, 2017 at 07:04:39PM +, Jean-Marc Lasgouttes wrote: > Le 13 octobre 2017 20:38:47 GMT+02:00, Richard Heck a écrit : > > > >I don't really know this part of the code, so I can't really comment on > >that. But I can confirm that the patch fixes the problem. > > > >Richard > > The

Re: Bad Math Display Regression in 2.3.x

2017-10-13 Thread Jean-Marc Lasgouttes
Le 13 octobre 2017 20:38:47 GMT+02:00, Richard Heck a écrit : > >I don't really know this part of the code, so I can't really comment on >that. But I can confirm that the patch fixes the problem. > >Richard The risk is that it creates unrelated problems. But it is the way to go IMO. JMarc

Re: Bad Math Display Regression in 2.3.x

2017-10-13 Thread Richard Heck
On 10/12/2017 04:08 PM, Jean-Marc Lasgouttes wrote: > Le 08/10/2017 à 08:56, Jean-Marc Lasgouttes a écrit : >> The bisect is probably enough for me to find the bug (he said >> confidently). > > Here is a tentative patch that I will not be able to test and push > until Monday. I will be interesting

Re: Bad Math Display Regression in 2.3.x

2017-10-12 Thread Jean-Marc Lasgouttes
Le 08/10/2017 à 08:56, Jean-Marc Lasgouttes a écrit : The bisect is probably enough for me to find the bug (he said confidently). Here is a tentative patch that I will not be able to test and push until Monday. I will be interesting by some feedback, though. JMarc >From 76bbcc2d4b0d595772

Re: Bad Math Display Regression in 2.3.x

2017-10-07 Thread Jean-Marc Lasgouttes
Le 8 octobre 2017 03:31:18 GMT+02:00, Scott Kostyshak a écrit : >On Sat, Oct 07, 2017 at 10:14:26PM +, Scott Kostyshak wrote: > >> I will compile newest master later. > >Tested latest master and I still see the issue. > >Scott The bisect is probably enough for me to find the bug (he said con

Re: Bad Math Display Regression in 2.3.x

2017-10-07 Thread Scott Kostyshak
On Sat, Oct 07, 2017 at 10:14:26PM +, Scott Kostyshak wrote: > I will compile newest master later. Tested latest master and I still see the issue. Scott signature.asc Description: PGP signature

Re: Bad Math Display Regression in 2.3.x

2017-10-07 Thread Jean-Marc Lasgouttes
Le 8 octobre 2017 00:48:28 GMT+02:00, Richard Heck a écrit : >I'm not sure if it is due to a difference in machines, but I'm now >seeing this only on master here, not on 2.3.x. And I see it on qt5 but not qt4. Anyway, the patch found by bisect is not in 2.3.x. However, it in in the oroperoaint

Re: Bad Math Display Regression in 2.3.x

2017-10-07 Thread Richard Heck
On 10/07/2017 06:38 PM, Richard Heck wrote: > On 10/07/2017 06:14 PM, Scott Kostyshak wrote: >> On Sat, Oct 07, 2017 at 10:24:31AM +, Jean-Marc Lasgouttes wrote: >>> Le 07/10/2017 à 03:19, Scott Kostyshak a écrit : On Fri, Oct 06, 2017 at 08:20:45PM +, Richard Heck wrote: > Recipe:

Re: Bad Math Display Regression in 2.3.x

2017-10-07 Thread Richard Heck
On 10/07/2017 06:14 PM, Scott Kostyshak wrote: > On Sat, Oct 07, 2017 at 10:24:31AM +, Jean-Marc Lasgouttes wrote: >> Le 07/10/2017 à 03:19, Scott Kostyshak a écrit : >>> On Fri, Oct 06, 2017 at 08:20:45PM +, Richard Heck wrote: Recipe: Open a new file. Create a math inset. Type "t" fo

Re: Bad Math Display Regression in 2.3.x

2017-10-07 Thread Scott Kostyshak
On Sat, Oct 07, 2017 at 10:24:31AM +, Jean-Marc Lasgouttes wrote: > Le 07/10/2017 à 03:19, Scott Kostyshak a écrit : > > On Fri, Oct 06, 2017 at 08:20:45PM +, Richard Heck wrote: > > > Recipe: Open a new file. Create a math inset. Type "t" followed by > > > "\wed" then hit tab. You will see

Re: Bad Math Display Regression in 2.3.x

2017-10-07 Thread Jean-Marc Lasgouttes
Le 07/10/2017 à 03:19, Scott Kostyshak a écrit : On Fri, Oct 06, 2017 at 08:20:45PM +, Richard Heck wrote: Recipe: Open a new file. Create a math inset. Type "t" followed by "\wed" then hit tab. You will see "\wedge" remaining on-screen as a math completion, without the wedge, but the cursor

Re: Bad Math Display Regression in 2.3.x

2017-10-06 Thread Scott Kostyshak
On Fri, Oct 06, 2017 at 08:20:45PM +, Richard Heck wrote: > Recipe: Open a new file. Create a math inset. Type "t" followed by > "\wed" then hit tab. You will see "\wedge" remaining on-screen as a math > completion, without the wedge, but the cursor is placed just after where > the wedge out to

Bad Math Display Regression in 2.3.x

2017-10-06 Thread Richard Heck
Recipe: Open a new file. Create a math inset. Type "t" followed by "\wed" then hit tab. You will see "\wedge" remaining on-screen as a math completion, without the wedge, but the cursor is placed just after where the wedge out to be (after the backslash, on my screen). In 2.2.x, the wedge just appe