Re: Another try on toc drawer on mac

2007-05-02 Thread Stefan Schimanski
(btw, is there a way now to compile with the Qt library bundles, instead of using a self compiled Qt?) In fact the cmake build system is using the Qt library bundle with all the frameworks already. I used it for weeks without knowing. Never noticed the different framework options while link

Re: Another try on toc drawer on mac

2007-05-02 Thread Stefan Schimanski
In the windowflags example of Qt it works fine though, in Qt 4.2 and 4.3. There must be something different in the toc widget which stop the draw from moving "into" the window. Is there anybody with Qt 4.3 on mac who could try the patch and see whether one can resize the drawer so much th

Re: Another try on toc drawer on mac

2007-05-01 Thread Bennett Helm
On May 1, 2007, at 2:59 AM, Jürgen Spitzmüller wrote: Bennett Helm wrote: Toggling the drawer works fine, both with the menu and a custom keybinding. One issue here, though, is focus. When the TOC drawer opens, the "Type" drop-down list has focus; on Mac, it's not possible to use the keyboard t

Re: Another try on toc drawer on mac

2007-05-01 Thread Andre Poenitz
On Tue, May 01, 2007 at 10:50:14AM +0200, Abdelrazak Younes wrote: > Andre Poenitz wrote: > >On Tue, May 01, 2007 at 10:38:14AM +0200, Abdelrazak Younes wrote: > >>Jürgen Spitzmüller wrote: > >>>Edwin Leuven wrote: > only one (and a half) small thing: > > i've added a toolbar button, a

Re: Another try on toc drawer on mac

2007-05-01 Thread Abdelrazak Younes
Andre Poenitz wrote: On Tue, May 01, 2007 at 10:38:14AM +0200, Abdelrazak Younes wrote: Jürgen Spitzmüller wrote: Edwin Leuven wrote: only one (and a half) small thing: i've added a toolbar button, and when i close the toc widget with the X the toolbutton is not untoggled; this happens only w

Re: Another try on toc drawer on mac

2007-05-01 Thread Andre Poenitz
On Tue, May 01, 2007 at 10:38:14AM +0200, Abdelrazak Younes wrote: > Jürgen Spitzmüller wrote: > >Edwin Leuven wrote: > >>only one (and a half) small thing: > >> > >>i've added a toolbar button, and when i close the toc widget with the X > >>the toolbutton is not untoggled; this happens only when i

Re: Another try on toc drawer on mac

2007-05-01 Thread Jürgen Spitzmüller
Abdelrazak Younes wrote: > We need a closed() or hidden() signal in DockView (emitted in the > DockView::closeEvent()) that will be connected to > LyXView::updateToolbars(). Could you do this, please? Jürgen

Re: Another try on toc drawer on mac

2007-05-01 Thread Abdelrazak Younes
Jürgen Spitzmüller wrote: Edwin Leuven wrote: only one (and a half) small thing: i've added a toolbar button, and when i close the toc widget with the X the toolbutton is not untoggled; this happens only when i click on the workarea... is there a missing update call somewhere? Probably. The

Re: Another try on toc drawer on mac

2007-05-01 Thread Jürgen Spitzmüller
Edwin Leuven wrote: > only one (and a half) small thing: > > i've added a toolbar button, and when i close the toc widget with the X > the toolbutton is not untoggled; this happens only when i click on the > workarea... > > is there a missing update call somewhere? Probably. The toolbars need to b

Re: Another try on toc drawer on mac

2007-05-01 Thread Jürgen Spitzmüller
Bennett Helm wrote: > Toggling the drawer works fine, both with the menu and a custom   > keybinding. One issue here, though, is focus. When the TOC drawer   > opens, the "Type" drop-down list has focus; on Mac, it's not possible   > to use the keyboard to navigate to the TOC contents or back to th

Re: Another try on toc drawer on mac

2007-04-30 Thread Edwin Leuven
Jürgen Spitzmüller wrote: Edwin Leuven wrote: i am sure you also like it better yourself... ;-) I took this as the second vote and committed. well done. only one (and a half) small thing: i've added a toolbar button, and when i close the toc widget with the X the toolbutton is not untoggl

Re: Another try on toc drawer on mac

2007-04-30 Thread Bennett Helm
On Apr 30, 2007, at 11:52 AM, Stefan Schimanski wrote: In fact I think that the title bar really is no problem. You can disable the moving anyway (did that in the patch), and having the close button there is not a bad thing either. What I don't like about the drawer in Qt is that you cannot

Re: Another try on toc drawer on mac

2007-04-30 Thread Bennett Helm
On Apr 30, 2007, at 12:04 PM, Abdelrazak Younes wrote: Stefan Schimanski wrote: (btw, is there a way now to compile with the Qt library bundles, instead of using a self compiled Qt?) I think Bennet tried once, without success. That would be very nice indeed. That's right. But then I woul

Re: Another try on toc drawer on mac

2007-04-30 Thread Abdelrazak Younes
Stefan Schimanski wrote: (btw, is there a way now to compile with the Qt library bundles, instead of using a self compiled Qt?) I think Bennet tried once, without success. That would be very nice indeed. Abdel.

Re: Another try on toc drawer on mac

2007-04-30 Thread Andre Poenitz
On Mon, Apr 30, 2007 at 10:31:09AM +0200, Stefan Schimanski wrote: > > > >Good! Then forget about my DrawerView proposition. > > > >>(Will 4.3 be out reasonably soon? Can we rely on it for the 1.5.0 > >>release?) > > > >I think this is a safe bet. > > > >>Anyway, this patch is looking promising.

Re: Another try on toc drawer on mac

2007-04-30 Thread Stefan Schimanski
In fact I think that the title bar really is no problem. You can disable the moving anyway (did that in the patch), and having the close button there is not a bad thing either. What I don't like about the drawer in Qt is that you cannot hide is by resizing it to 0. Cocoa apps can do tha

Re: Another try on toc drawer on mac

2007-04-30 Thread Jürgen Spitzmüller
Edwin Leuven wrote: > i am sure you also like it better yourself... ;-) I took this as the second vote and committed. Jürgen

Re: Another try on toc drawer on mac

2007-04-30 Thread Jürgen Spitzmüller
Edwin Leuven wrote: > the goodness won of the lazyness Let's say: the lazyness concerning something more important won over this particular lazyness ... > > attached is a patch that implements > > dialog-toggle (and uses it for toc and view-source). > > > > Opinions? > > i am sure you also like

Re: Another try on toc drawer on mac

2007-04-30 Thread Edwin Leuven
Jürgen Spitzmüller wrote: OK, I'm trying to be a good guy: the goodness won of the lazyness attached is a patch that implements dialog-toggle (and uses it for toc and view-source). Opinions? i am sure you also like it better yourself... ;-)

Re: Another try on toc drawer on mac

2007-04-30 Thread Abdelrazak Younes
Jürgen Spitzmüller wrote: Edwin Leuven wrote: because I'm lazy (and don't see the need for that ATM). fair enough ;-) OK, I'm trying to be a good guy: attached is a patch that implements dialog-toggle (and uses it for toc and view-source). Opinions? Looks sane and good. Abdel.

Re: Another try on toc drawer on mac

2007-04-30 Thread Jürgen Spitzmüller
Edwin Leuven wrote: > > because I'm lazy (and don't see the need for that ATM). > > fair enough ;-) OK, I'm trying to be a good guy: attached is a patch that implements dialog-toggle (and uses it for toc and view-source). Opinions? (most changes in lfuns.h are due to a miscount I detected) Jürg

Re: Another try on toc drawer on mac

2007-04-30 Thread Jürgen Spitzmüller
Michael Gerz wrote: > If we transform this command into a toggle command, then how about > "source-view"?  Shouldn't it be changed as well? Probably. > And are there any other commands of the same flavour? Don't think so. > IMHO we must be careful that we do not > change too many commands in

Re: Another try on toc drawer on mac

2007-04-30 Thread Michael Gerz
Jürgen Spitzmüller schrieb Jürgen Spitzmüller wrote: The lfun should probably be renamed LFUN_TOGGLE_TOC. The attached patch does this (LFUN_TOC_TOGGLE). OK to apply? If we transform this command into a toggle command, then how about "source-view"? Shouldn't it be changed as well

Re: Another try on toc drawer on mac

2007-04-30 Thread Edwin Leuven
Jürgen Spitzmüller wrote: Edwin Leuven wrote: just to show my ignorance (and satisfy my curiosity): why not a generic LFUN_DIALOG_TOGGLE ? because I'm lazy (and don't see the need for that ATM). fair enough ;-)

Re: Another try on toc drawer on mac

2007-04-30 Thread Jürgen Spitzmüller
Edwin Leuven wrote: > just to show my ignorance (and satisfy my curiosity): > > why not a generic LFUN_DIALOG_TOGGLE ? because I'm lazy (and don't see the need for that ATM). Jürgen

Re: Another try on toc drawer on mac

2007-04-30 Thread Edwin Leuven
Jürgen Spitzmüller wrote: The attached patch does this (LFUN_TOC_TOGGLE). just to show my ignorance (and satisfy my curiosity): why not a generic LFUN_DIALOG_TOGGLE ?

Re: Another try on toc drawer on mac

2007-04-30 Thread Jürgen Spitzmüller
Jürgen Spitzmüller wrote: > The lfun should probably be renamed LFUN_TOGGLE_TOC. The attached patch does this (LFUN_TOC_TOGGLE). OK to apply? Jürgen Index: src/LyXAction.cpp === --- src/LyXAction.cpp (Revision 18108) +++ src/LyXActi

Re: Another try on toc drawer on mac

2007-04-30 Thread Abdelrazak Younes
Stefan Schimanski wrote: Stefan, where are you WRT SVN access? Wrote Andre a mail about it Is he the one responsible to create accounts? JMarc and Christian are probably more in the knows-how. Abdel.

Re: Another try on toc drawer on mac

2007-04-30 Thread Jürgen Spitzmüller
Jean-Marc Lasgouttes wrote: > Stefan> I haven't found out how to fix the menu item as well. At the > Stefan> moment it greys out when the drawer is visible. It should > Stefan> switch between "Show TOC" and "Hide TOC" or it should be a > Stefan> toggle menu item. Would be happy about some hint wher

Re: Another try on toc drawer on mac

2007-04-30 Thread Jean-Marc Lasgouttes
> "Stefan" == Stefan Schimanski <[EMAIL PROTECTED]> writes: Stefan> I haven't found out how to fix the menu item as well. At the Stefan> moment it greys out when the drawer is visible. It should Stefan> switch between "Show TOC" and "Hide TOC" or it should be a Stefan> toggle menu item. Would

Re: Another try on toc drawer on mac

2007-04-30 Thread Stefan Schimanski
Good! Then forget about my DrawerView proposition. (Will 4.3 be out reasonably soon? Can we rely on it for the 1.5.0 release?) I think this is a safe bet. Anyway, this patch is looking promising. I can confirm that the toolbar button does toggle the TOC drawer, but the menu is grayed ou

Re: Another try on toc drawer on mac

2007-04-30 Thread Abdelrazak Younes
Bennett Helm wrote: On Apr 29, 2007, at 5:28 PM, Abdelrazak Younes wrote: Qt's doc say that the Drawer property will be ignored. So the #ifdef are not necessary. But IIRC the result of the discussion cited above was that, in order to get rid of the title bar we need a new container similar

Re: Another try on toc drawer on mac

2007-04-29 Thread Bennett Helm
On Apr 29, 2007, at 5:28 PM, Abdelrazak Younes wrote: Stefan Schimanski wrote: Hi! Not sure what the last state of discussion was to use a drawer for the TOC on Mac. I like it and here I got the impression that others do too: http://marc.info/?l=lyx-devel&m=117392182901685&w=2 So here is an

Re: Another try on toc drawer on mac

2007-04-29 Thread Stefan Schimanski
In fact I think that the title bar really is no problem. You can disable the moving anyway (did that in the patch), and having the close button there is not a bad thing either. What I don't like about the drawer in Qt is that you cannot hide is by resizing it to 0. Cocoa apps can do that,

Re: Another try on toc drawer on mac

2007-04-29 Thread Stefan Schimanski
But IIRC the result of the discussion cited above was that, in order to get rid of the title bar we need a new container similar to the DockView one but reserved for Drawer type widget: DrawerView. In fact QDockWidget::setTitleBarWidget allows exactly that, unfortunately only from Qt 4.3 on

Re: Another try on toc drawer on mac

2007-04-29 Thread Abdelrazak Younes
Stefan Schimanski wrote: Hi! Not sure what the last state of discussion was to use a drawer for the TOC on Mac. I like it and here I got the impression that others do too: http://marc.info/?l=lyx-devel&m=117392182901685&w=2 So here is another patch which fixes a few things (mentioned here h