Am Donnerstag, 8. April 2004 12:13 schrieb Jean-Marc Lasgouttes:
> I applied it.
Thanks. Now I can continue to work on the dvi export and graphics inset
problems.
Georg
> "Georg" == Georg Baum <[EMAIL PROTECTED]> writes:
Georg> Jean-Marc Lasgouttes wrote:
>> OK, OK I surrender, please stop hitting my head it hurts!
Georg> Well, I did not intend to hit your head, if Angus' post had
Georg> arrived before I wrote mine I would have been quiet.
>> Nevertheless,
Jean-Marc Lasgouttes wrote:
> OK, OK I surrender, please stop hitting my head it hurts!
Well, I did not intend to hit your head, if Angus' post had arrived before I
wrote mine I would have been quiet.
> Nevertheless, I am sure there is a way to have LaTeXFeatures::buffer_
> as a pointer, but kee
On Thu, Apr 01, 2004 at 09:53:21AM +0200, Jean-Marc Lasgouttes wrote:
> > "Georg" == Georg Baum <[EMAIL PROTECTED]> writes:
>
> Georg> Jean-Marc Lasgouttes wrote:
> >> What's wrong with the following without any pointer change?
> >>
> >> +void LaTeXFeatures::setBuffer(Buffer const & buffer) +
> "Georg" == Georg Baum <[EMAIL PROTECTED]> writes:
Georg> Jean-Marc Lasgouttes wrote:
>> What's wrong with the following without any pointer change?
>>
>> +void LaTeXFeatures::setBuffer(Buffer const & buffer) +{ + buffer_
>> = buffer;
>> }
Georg> This is wrong:
OK, OK I surrender, please s
Jean-Marc Lasgouttes wrote:
> What's wrong with the following without any pointer change?
>
> +void LaTeXFeatures::setBuffer(Buffer const & buffer)
> +{
> + buffer_ = buffer;
> }
This is wrong:
LaTeXFeatures.C: In member function `void LaTeXFeatures::setBuffer(const
Buffer&)':
LaTeXFeat
Jean-Marc Lasgouttes wrote:
> What's wrong with the following without any pointer change?
>
> +void LaTeXFeatures::setBuffer(Buffer const & buffer)
> +{
> + buffer_ = buffer;
> }
Your C++ is going to pot JMarc:
struct LatexFeatures {
Buffer const & buffer_;
};
1. You can't reset a
> "Georg" == Georg Baum <[EMAIL PROTECTED]> writes:
Georg> is my above guess valid? In any case, I have seen the failure
Georg> in 1.4cvs, and the attached patch fixes it. It is not pretty,
Georg> but I don't know a better solution, so IMO it should be applied
Georg> unless somebody else has a
Georg Baum wrote:
> Jean-Marc Lasgouttes wrote:
>
>> You are trying to make me feel guilty, aren't you? ;)
>
> Not really ;-)
>
>> Well, I do feel guilty, but I do not think much about it yet. I
>> understand what you wrote, but I do not understand why it does not
>> occur with my #605 patch (o
Jean-Marc Lasgouttes wrote:
> You are trying to make me feel guilty, aren't you? ;)
Not really ;-)
> Well, I do feel guilty, but I do not think much about it yet. I
> understand what you wrote, but I do not understand why it does not
> occur with my #605 patch (or why I did not see it).
I belie
> "Georg" == Georg Baum <[EMAIL PROTECTED]> writes:
Georg> Jean-Marc Lasgouttes wrote:
>> Hmm... I have to think about it, I guess.
Georg> Did you find time?
You are trying to make me feel guilty, aren't you? ;)
Well, I do feel guilty, but I do not think much about it yet. I
understand wha
Jean-Marc Lasgouttes wrote:
>> "Georg" == Georg Baum <[EMAIL PROTECTED]> writes:
> Georg> The reason for all that is that InsetInclude::validate() does
> Georg> not know its own buffer, but currently operates on the master
> Georg> buffer. loadIfNeeded() works if it is called with the correct
Jean-Marc Lasgouttes wrote:
> > "Georg" == Georg Baum <[EMAIL PROTECTED]> writes:
>
> Georg> No, I did not explain it in detail. The problem is that
> Georg> includedFilename(), that gets called by loadIfNeeded() with the
> Georg> buffer that originally came from LaTeXFeatures, returns in some
> "Georg" == Georg Baum <[EMAIL PROTECTED]> writes:
Georg> No, I did not explain it in detail. The problem is that
Georg> includedFilename(), that gets called by loadIfNeeded() with the
Georg> buffer that originally came from LaTeXFeatures, returns in some
Georg> cases a wrong filename for rel
Jean-Marc Lasgouttes wrote:
>> "Georg" == Georg Baum <[EMAIL PROTECTED]> writes:
> Georg> The problem now is that loadIfNeeded() is called with that
> Georg> buffer, but it really needs the buffer of the file that
> Georg> contains the inset.
>
> Why? From the code, I do not see what problem
> "Georg" == Georg Baum <[EMAIL PROTECTED]> writes:
Georg> LaTeXFeatures::buffer_ is in fact the master buffer, because it
Georg> is a reference that is set in the constructor.
Yes.
Georg> The problem now is that loadIfNeeded() is called with that
Georg> buffer, but it really needs the buff
Georg Baum wrote:
> Possible solution: Make LaTeXFeatures::buffer_ a pointer instead of
> a reference (InsetInclude::validate() is the only place where it is
> needed), and do the following in InsetInclude::validate():
>
> Buffer const * buffer = features.buffer();
> ...
> if (tmp
There is a problem related to nested included files that has not been solved
yet. InsetInclude::validate() gets its buffer like this:
Buffer const & buffer = features.buffer();
Lateron, the included file is validated:
if (tmp)
tmp->validate(features);
LaTeXFeatu
18 matches
Mail list logo
