Re: Another crash with TOC dock widget after undo

2007-06-13 Thread Abdelrazak Younes
Stefan Schimanski wrote: Any news about this? LyX still crashes... The fix is obvious. Just commit it Abdel.

Re: Another crash with TOC dock widget after undo

2007-06-13 Thread Stefan Schimanski
Any news about this? LyX still crashes... Stefan Am 11.06.2007 um 16:41 schrieb Jean-Marc Lasgouttes: "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Since label update is a view thing (nothing to do in core undo code imo), we could have a new update flag that does the update

Re: Another crash with TOC dock widget after undo

2007-06-11 Thread Jean-Marc Lasgouttes
> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: >> Since label update is a view thing (nothing to do in core undo >> code imo), we could have a new update flag that does the update >> (one entry or all entries) before the matrics update. Abdelrazak> Yes but not now! Yes, sur

Re: [patch] Another crash with TOC dock widget after undo

2007-06-11 Thread Abdelrazak Younes
Stefan Schimanski wrote: The obvious naive fix: Simple is beautiful and most of time correct. I'm sure it is this time ;-) Abdel.

Re: Another crash with TOC dock widget after undo

2007-06-11 Thread Abdelrazak Younes
Jean-Marc Lasgouttes wrote: "Stefan" == Stefan Schimanski <[EMAIL PROTECTED]> writes: Stefan> What about updating the TOC asynchronously? Don't know how to Stefan> do this with the current architecture. Are there asynchronous Stefan> lfuns? I.e. they are only executed from the frontend's messag

Re: Another crash with TOC dock widget after undo

2007-06-11 Thread Stefan Schimanski
Am 11.06.2007 um 15:16 schrieb Abdelrazak Younes: Richard Heck wrote: Stefan Schimanski wrote: FYI: http://bugzilla.lyx.org/show_bug.cgi?id=3851 First guess: looking at Undo::undoText... updateLabels(*buf) will trigger a TOC update. The cursor of the bufferview is still broken then. It is

Re: Another crash with TOC dock widget after undo

2007-06-11 Thread Abdelrazak Younes
Richard Heck wrote: Stefan Schimanski wrote: FYI: http://bugzilla.lyx.org/show_bug.cgi?id=3851 First guess: looking at Undo::undoText... updateLabels(*buf) will trigger a TOC update. The cursor of the bufferview is still broken then. It is only fixed after that call. But ControlToc::getCurrent

Re: Another crash with TOC dock widget after undo

2007-06-11 Thread Jean-Marc Lasgouttes
> "Stefan" == Stefan Schimanski <[EMAIL PROTECTED]> writes: Stefan> What about updating the TOC asynchronously? Don't know how to Stefan> do this with the current architecture. Are there asynchronous Stefan> lfuns? I.e. they are only executed from the frontend's message Stefan> loop after ever

[patch] Another crash with TOC dock widget after undo

2007-06-11 Thread Stefan Schimanski
The obvious naive fix: --- src/Undo.cpp(Revision 18737) +++ src/Undo.cpp(Arbeitskopie) @@ -164,6 +164,7 @@ // This does the actual undo/redo. //lyxerr << "undo, performing: " << undo << std::endl; + bool labelsUpdateNeeded = false; DocIterator dit = u

Re: Another crash with TOC dock widget after undo

2007-06-11 Thread Stefan Schimanski
Am 11.06.2007 um 15:06 schrieb Richard Heck: Stefan Schimanski wrote: FYI: http://bugzilla.lyx.org/show_bug.cgi?id=3851 First guess: looking at Undo::undoText... updateLabels(*buf) will trigger a TOC update. The cursor of the bufferview is still broken then. It is only fixed after that cal

Re: Another crash with TOC dock widget after undo

2007-06-11 Thread Richard Heck
Stefan Schimanski wrote: FYI: http://bugzilla.lyx.org/show_bug.cgi?id=3851 First guess: looking at Undo::undoText... updateLabels(*buf) will trigger a TOC update. The cursor of the bufferview is still broken then. It is only fixed after that call. But ControlToc::getCurrentTocItem(size_t type) fi

Another crash with TOC dock widget after undo

2007-06-11 Thread Stefan Schimanski
FYI: http://bugzilla.lyx.org/show_bug.cgi?id=3851 Stefan PGP.sig Description: Signierter Teil der Nachricht