Re: 6 advanced find tests are failing on master

2013-08-24 Thread Scott Kostyshak
On Sat, Aug 24, 2013 at 12:47 PM, Tommaso Cucinotta wrote: > On 22/08/13 04:37, Scott Kostyshak wrote: >> This still needs to be decided. The vote is 2 (Tommaso and me) in >> favor of reverting, 0 opposed. If no one else has an opinion, I will >> ask Tommaso to revert his commit. > > Reverted (for

Re: 6 advanced find tests are failing on master

2013-08-24 Thread Tommaso Cucinotta
On 22/08/13 04:37, Scott Kostyshak wrote: > This still needs to be decided. The vote is 2 (Tommaso and me) in > favor of reverting, 0 opposed. If no one else has an opinion, I will > ask Tommaso to revert his commit. Reverted (for now). Did we have a ticket to reopen where to remember this pendin

Re: 6 advanced find tests are failing on master

2013-08-21 Thread Scott Kostyshak
On Mon, Aug 5, 2013 at 5:14 AM, Scott Kostyshak wrote: > On Sun, Jul 28, 2013 at 8:15 AM, Tommaso Cucinotta wrote: >> On 28/07/13 06:59, Scott Kostyshak wrote: > > Let non-ASCII chars within regexp insets match their occurrence > within TEXT, rather than MATHS (seems the most recu

Re: 6 advanced find tests are failing on master

2013-08-05 Thread Scott Kostyshak
On Sun, Jul 28, 2013 at 8:15 AM, Tommaso Cucinotta wrote: > On 28/07/13 06:59, Scott Kostyshak wrote: Let non-ASCII chars within regexp insets match their occurrence within TEXT, rather than MATHS (seems the most recurrently needed scenario). >> >>> As for the release, I ca

Re: 6 advanced find tests are failing on master

2013-07-28 Thread Tommaso Cucinotta
On 28/07/13 06:59, Scott Kostyshak wrote: >>> >>> Let non-ASCII chars within regexp insets match their occurrence >>> within TEXT, rather than MATHS (seems the most recurrently needed >>> scenario). > >> As for the release, I cannot see a quick fix that makes both things work >> right now. >

Re: 6 advanced find tests are failing on master

2013-07-27 Thread Scott Kostyshak
On Tue, Jul 23, 2013 at 7:22 PM, Tommaso Cucinotta wrote: > On 16/07/13 09:16, Scott Kostyshak wrote: >> Insert "a b c" in a new document and use '\s' to find. It does not >> find the space. Git bisect leads to the following commit: >> >> commit 6a3792bdbb7e081fe15d6600b2d86bbefd20b2f0 >> Author:

Re: 6 advanced find tests are failing on master

2013-07-23 Thread Tommaso Cucinotta
On 16/07/13 09:16, Scott Kostyshak wrote: > Insert "a b c" in a new document and use '\s' to find. It does not > find the space. Git bisect leads to the following commit: > > commit 6a3792bdbb7e081fe15d6600b2d86bbefd20b2f0 > Author: Tommaso Cucinotta > Date: Sun Apr 7 23:28:41 2013 +0100 > >

Re: 6 advanced find tests are failing on master

2013-07-22 Thread Scott Kostyshak
On Mon, Jul 22, 2013 at 9:18 PM, Tommaso Cucinotta wrote: > On 15/07/13 07:00, Scott Kostyshak wrote: >> I have just confirmed that these tests also fail for me under automake. >> >> Can you check these tests? LyX 2.1 will be released soon and it would >> be nice to make sure we don't have any reg

Re: 6 advanced find tests are failing on master

2013-07-22 Thread Tommaso Cucinotta
On 15/07/13 07:00, Scott Kostyshak wrote: > I have just confirmed that these tests also fail for me under automake. > > Can you check these tests? LyX 2.1 will be released soon and it would > be nice to make sure we don't have any regressions here. It seems from distro-update to distro-update, Ly

Re: 6 advanced find tests are failing on master

2013-07-16 Thread Scott Kostyshak
On Mon, Jul 15, 2013 at 2:00 AM, Scott Kostyshak wrote: > On Mon, Jul 8, 2013 at 4:30 AM, Kornel Benko wrote: >> Am Sonntag, 7. Juli 2013 um 22:22:57, schrieb Scott Kostyshak >> >> >>> Six advanced find tests are failing for me on master: >> >>> >> >>> findadv-18 >> >>> findadv-19 >> >>> findadv

Re: 6 advanced find tests are failing on master

2013-07-14 Thread Scott Kostyshak
On Mon, Jul 8, 2013 at 4:30 AM, Kornel Benko wrote: > Am Sonntag, 7. Juli 2013 um 22:22:57, schrieb Scott Kostyshak > > >> Six advanced find tests are failing for me on master: > >> > >> findadv-18 > >> findadv-19 > >> findadv-re-01 > >> findadv-re-02 > >> findadv-re-03 > >> findadv-re-05 > >> >

Re: 6 advanced find tests are failing on master

2013-07-08 Thread Kornel Benko
Am Sonntag, 7. Juli 2013 um 22:22:57, schrieb Scott Kostyshak > Six advanced find tests are failing for me on master: > > findadv-18 > findadv-19 > findadv-re-01 > findadv-re-02 > findadv-re-03 > findadv-re-05 > > I remember that sometimes tests would pass for Tommaso but not for me > and Kornel

6 advanced find tests are failing on master

2013-07-07 Thread Scott Kostyshak
Six advanced find tests are failing for me on master: findadv-18 findadv-19 findadv-re-01 findadv-re-02 findadv-re-03 findadv-re-05 I remember that sometimes tests would pass for Tommaso but not for me and Kornel under CMake but I thought we solved this issue. What do others see? Scott