Re: [tentative PATCH] Bug 1451: spell check stuck in loop

2005-06-14 Thread Jean-Marc Lasgouttes
> "Jean-Marc" == Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: Jean-Marc> The following patch tries to fix bug 1451, but I am not Jean-Marc> sure I did things right. I applied it. JMarc

Re: [tentative PATCH] Bug 1451: spell check stuck in loop

2005-05-30 Thread Jean-Marc Lasgouttes
Angus> Sorry, JMarc. I've been lost in the depths of Windows Installer Angus> land, for which I blame you entirely :-P Angus> Looking at the patch, shouldn't updateSlot() be: Angus> +void ControlSpellchecker::updateSlot(bool switched) Angus> +{ Angus> +if (switched) Angus> +hide(); A

Re: [tentative PATCH] Bug 1451: spell check stuck in loop

2005-05-26 Thread Angus Leeming
Jean-Marc Lasgouttes wrote: Jean-Marc> What the patch does is to implement a better (?) Jean-Marc> ControlSpellchecker::updateSlot(). Angus, I would really Jean-Marc> appreciate if you could look at this. Angus? I'd really like to understand what the intent of this API is, to see whether it is u

Re: [tentative PATCH] Bug 1451: spell check stuck in loop

2005-05-26 Thread Jean-Marc Lasgouttes
> "Jean-Marc" == Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: Jean-Marc> What the patch does is to implement a better (?) Jean-Marc> ControlSpellchecker::updateSlot(). Angus, I would really Jean-Marc> appreciate if you could look at this. Angus? I'd really like to understand what the inte

[tentative PATCH] Bug 1451: spell check stuck in loop

2005-05-24 Thread Jean-Marc Lasgouttes
The following patch tries to fix bug 1451, but I am not sure I did things right. Basically what happens when switching document is the following call stack BufferView::buffer BufferView::Pimpl::buffer Dialogs::updateBufferDependent ControlConnectBD::updateSlot(true) ControlDialog::update() Contr