Re: [sample patch]: FileName class

2003-07-21 Thread Angus Leeming
Lars Gullik Bjønnes wrote: > John Levon <[EMAIL PROTECTED]> writes: > > | On Mon, Jul 21, 2003 at 06:21:17PM +0200, Lars Gullik Bj?nnes wrote: > | > | > boost::filesystem. > | > | You were against replacing our stuff with that last time I asked about > | it. > | > | Besides, that's an absolute

Re: [sample patch]: FileName class

2003-07-21 Thread Lars Gullik Bjønnes
John Levon <[EMAIL PROTECTED]> writes: | On Mon, Jul 21, 2003 at 06:21:17PM +0200, Lars Gullik Bj?nnes wrote: | | > boost::filesystem. | | You were against replacing our stuff with that last time I asked about | it. | | Besides, that's an absolutely massive patch (and I am strongly against | on

Re: [sample patch]: FileName class

2003-07-21 Thread Angus Leeming
Lars Gullik Bjønnes wrote: > | Do people think this is a clean solution? Should I move the class into > | its own files rather than putting it in support/filetools.[Ch]? > > Well... I think the boost::path stuff would do this... > > | Comments please. > > boost::filesystem. My proposal:

Re: [sample patch]: FileName class

2003-07-21 Thread John Levon
On Mon, Jul 21, 2003 at 06:21:17PM +0200, Lars Gullik Bj?nnes wrote: > boost::filesystem. You were against replacing our stuff with that last time I asked about it. Besides, that's an absolutely massive patch (and I am strongly against only using bits of boost::filesystem and bits of our support

Re: [sample patch]: FileName class

2003-07-21 Thread Lars Gullik Bjønnes
Angus Leeming <[EMAIL PROTECTED]> writes: | I remember having a rant sometime ago about the need for something better | than our current handling of file names. My proposal was to have a helper | class that would enable us to 'do the right thing' when reading/writing the | buffer to file: | |

Re: [sample patch]: FileName class

2003-07-21 Thread John Levon
On Mon, Jul 21, 2003 at 03:40:15PM +, Angus Leeming wrote: > Shrug. No, but this is a sample, encoding only the graphics inset with a > FileName member. I can't see what can go wrong with write given that > FileName stores the absolute path to the file and a flag save_abs_path_ > saying how

Re: [sample patch]: FileName class

2003-07-21 Thread Angus Leeming
John Levon wrote: > On Mon, Jul 21, 2003 at 12:28:29PM +, Angus Leeming wrote: > >> Might help if you had the patch... > > Have you tested this with things like "Save As" ? > > regards > john Shrug. No, but this is a sample, encoding only the graphics inset with a FileName member. I can't

Re: [sample patch]: FileName class

2003-07-21 Thread John Levon
On Mon, Jul 21, 2003 at 12:28:29PM +, Angus Leeming wrote: > Might help if you had the patch... Have you tested this with things like "Save As" ? regards john

Re: [sample patch]: FileName class

2003-07-21 Thread Angus Leeming
On Monday 21 July 2003 11:39 am, Andre Poenitz wrote: > + void absFilename(string const abs_filename); > string const &? Umm. Yes. Thanks. > @@ -144,7 +144,10 @@ void InsetGraphicsParams::Write(ostream > // Do not write the default values > > if (!filename.empty()) { > -

Re: [sample patch]: FileName class

2003-07-21 Thread Angus Leeming
Angus Leeming wrote: > Comments please. Might help if you had the patch... -- AngusIndex: src/support/filetools.h === RCS file: /usr/local/lyx/cvsroot/lyx-devel/src/support/filetools.h,v retrieving revision 1.47 diff -u -p -r1.47 fil

Re: [sample patch]: FileName class

2003-07-21 Thread Andre Poenitz
On Mon, Jul 21, 2003 at 12:24:02PM +, Angus Leeming wrote: > Comments please. Patch please. Andre' -- Those who desire to give up Freedom in order to gain Security, will not have, nor do they deserve, either one. (T. Jefferson or B. Franklin or both...)

[sample patch]: FileName class

2003-07-21 Thread Angus Leeming
I remember having a rant sometime ago about the need for something better than our current handling of file names. My proposal was to have a helper class that would enable us to 'do the right thing' when reading/writing the buffer to file: class FileName { public: FileName(); /*