Re: [patch] update and merge lyxpreview mechanisms

2011-09-12 Thread Julien Rioux
On 12/09/2011 7:37 AM, Jürgen Spitzmüller wrote: Julien Rioux wrote: Any reason to keep those \ifpdf etc. around, i.e. were these used for something else besides the color handling? We used it to pass the correct driver (pdftex,dvips,xetex) to preview-latex. You should check the package's manu

Re: [patch] update and merge lyxpreview mechanisms

2011-09-11 Thread Jürgen Spitzmüller
Julien Rioux wrote: > Any reason to keep > those \ifpdf etc. around, i.e. were these used for something else > besides the color handling? We used it to pass the correct driver (pdftex,dvips,xetex) to preview-latex. You should check the package's manual if/why this is necessary. Jürgen

Re: [patch] update and merge lyxpreview mechanisms

2011-09-11 Thread Julien Rioux
On 08/09/2011 6:15 PM, Julien Rioux wrote: On 03/09/2011 9:30 PM, José Matos wrote: On 09/02/2011 07:36 PM, Richard Heck wrote: If extensibility isn't really an issue, then it's more a matter of taste. Richard +1 :-) Thanks for the feedback. Without further objections, I'll probably put t

Re: [patch] update and merge lyxpreview mechanisms

2011-09-08 Thread Julien Rioux
On 03/09/2011 9:30 PM, José Matos wrote: On 09/02/2011 07:36 PM, Richard Heck wrote: If extensibility isn't really an issue, then it's more a matter of taste. Richard +1 :-) Thanks for the feedback. Without further objections, I'll probably put this into svn tomorrow or on the weekend.

Re: [patch] update and merge lyxpreview mechanisms

2011-09-03 Thread José Matos
On 09/02/2011 07:36 PM, Richard Heck wrote: > If extensibility isn't really an issue, then it's more a matter of taste. > > Richard +1 :-) -- José Matos

Re: [patch] update and merge lyxpreview mechanisms

2011-09-02 Thread Richard Heck
On 09/02/2011 12:44 PM, Julien Rioux wrote: > On 01/09/2011 11:29 AM, José Matos wrote: >> On 08/31/2011 07:07 PM, Julien Rioux wrote: >>> >>> If you have both --png and --ppm, the first one that appears will take >>> precedence. In principle you could produce both output as well. >> >> IMHO it is

Re: [patch] update and merge lyxpreview mechanisms

2011-09-02 Thread Julien Rioux
On 01/09/2011 11:29 AM, José Matos wrote: On 08/31/2011 07:07 PM, Julien Rioux wrote: If you have both --png and --ppm, the first one that appears will take precedence. In principle you could produce both output as well. IMHO it is a question of extensibility, if you add another format will y

Re: [patch] update and merge lyxpreview mechanisms

2011-09-01 Thread José Matos
On 08/31/2011 07:07 PM, Julien Rioux wrote: > > If you have both --png and --ppm, the first one that appears will take > precedence. In principle you could produce both output as well. IMHO it is a question of extensibility, if you add another format will you add another option? If need to output

Re: [patch] update and merge lyxpreview mechanisms

2011-08-31 Thread Julien Rioux
On 31/08/2011 7:03 PM, José Matos wrote: On 08/30/2011 06:49 PM, Julien Rioux wrote: lyxpreview2bitmap.py --png --dpi=128 --fg=00 --bg=faf0e6 0lyxpreview.tex which makes it more flexible as the arguments can move around. Then the special-casing of lilypond-book and japanese documents can be

Re: [patch] update and merge lyxpreview mechanisms

2011-08-31 Thread José Matos
On 08/30/2011 06:49 PM, Julien Rioux wrote: > lyxpreview2bitmap.py --png --dpi=128 --fg=00 --bg=faf0e6 > 0lyxpreview.tex > > which makes it more flexible as the arguments can move around. Then > the special-casing of lilypond-book and japanese documents can be > treated more easily by command-l

Re: [patch] update and merge lyxpreview mechanisms

2011-08-31 Thread Pavel Sanda
Julien Rioux wrote: > Comments awaited eagerly, can't comment on the code but thanks for returning to the merge of doubled scripts, it was needed. pavel

Re: [patch] update and merge lyxpreview mechanisms

2011-08-31 Thread Jürgen Spitzmüller
Julien Rioux wrote: > Here's a patch that cleans up the handling of previews. Excellent move. Jürgen

[patch] update and merge lyxpreview mechanisms

2011-08-30 Thread Julien Rioux
Dear everyone, Here's a patch that cleans up the handling of previews. At the moment the lyxpreview2bitmap.py script expects its arguments in a specific order: lyxpreview2bitmap.py png 0lyxpreview.tex 128 00 faf0e6 I change this using getopt (python 2.3) to: lyxpreview2bitmap.py --png --