Re: [patch] tex2lyx whitespace changes

2003-11-05 Thread Georg Baum
Am Dienstag, 4. November 2003 10:05 schrieb Jean-Marc Lasgouttes: > > "Georg" == Georg Baum <[EMAIL PROTECTED]> writes: > > Georg> There are still nesting errors with nesting list like > Georg> environments. They are different than without the patch. I will > Georg> have a look at that again, b

Re: [patch] tex2lyx whitespace changes

2003-11-04 Thread Georg Baum
Am Montag, 3. November 2003 14:41 schrieb Andre Poenitz: > Ok. I don't have the time to check this thoroughly. It looks sensible, > so if you can confirm that the ound-trip on the UserGuide is no worse > than before, I'd commit this. Please take the attached version. It has exactly the same nesti

Re: [patch] tex2lyx whitespace changes

2003-11-04 Thread Jean-Marc Lasgouttes
> "Georg" == Georg Baum <[EMAIL PROTECTED]> writes: Georg> There are still nesting errors with nesting list like Georg> environments. They are different than without the patch. I will Georg> have a look at that again, but it would be nice if somebody who Georg> understands need_deeper, deeper_

Re: [patch] tex2lyx whitespace changes

2003-11-03 Thread Andre Poenitz
On Mon, Nov 03, 2003 at 07:08:43PM +0100, Georg Baum wrote: > Andre Poenitz wrote: > > > Maybe we must settle at a 'round trip' definition. There are several > > possibilities: > > > > 1. round trip in the weak sense: > > .lyx -> .tex -> .dvi == .lyx -> .tex -> .lyx -> .tex -> .dvi > > > >

Re: [patch] tex2lyx whitespace changes

2003-11-03 Thread Georg Baum
Andre Poenitz wrote: > Try to stick to LyX-style formatting: > >if (c == '{') { > > [There are other plases like that] I accidently sent the wrong patch. The non tex2lyx part of the patch was not intended and contains some half-finished test stuff written some time ago. I hope you notice

Re: [patch] tex2lyx whitespace changes

2003-11-03 Thread Georg Baum
Andre Poenitz wrote: > Maybe we must settle at a 'round trip' definition. There are several > possibilities: > > 1. round trip in the weak sense: > .lyx -> .tex -> .dvi == .lyx -> .tex -> .lyx -> .tex -> .dvi > > 2. round trip in the realistic sense: > > .lyx == .lyx -> .tex -> .lyx

Re: [patch] tex2lyx whitespace changes

2003-11-03 Thread Jose' Matos
On Monday 03 November 2003 13:41, Andre Poenitz wrote: > > > @@ -293,8 +370,8 @@ > > if (p.next_token().asInput() == "[") { > > latex_inner_pos = p.getArg('[', ']'); > > switch(latex_inner_pos[0]) {

Re: [patch] tex2lyx whitespace changes

2003-11-03 Thread Andre Poenitz
On Mon, Nov 03, 2003 at 01:29:58PM +0100, Georg Baum wrote: > Jean-Marc Lasgouttes wrote: > > > It looks good, except this bit that I do not like much: > > Me neither. But if the goal is real roundtrip support, something like this > is needed. The problem is that lyx generates a newline at some p

Re: [patch] tex2lyx whitespace changes

2003-11-03 Thread Lars Gullik Bjønnes
Andre Poenitz <[EMAIL PROTECTED]> writes: | Does minipage really code its inner_position as 0 1 2 3 instead of 't', | 'c', 'b'? *sigh* No... I do not think so... If we do that is a but we should fix promtly (latex uses proper values) -- Lgb

Re: [patch] tex2lyx whitespace changes

2003-11-03 Thread Andre Poenitz
> Index: lib/symbols > === > RCS file: /cvs/lyx/lyx-devel/lib/symbols,v > retrieving revision 1.44 > diff -u -r1.44 symbols > --- lib/symbols 2003/10/13 09:50:08 1.44 > +++ lib/symbols 2003/11/03 09:31:29 > @@ -120,6 +1

Re: [patch] tex2lyx whitespace changes

2003-11-03 Thread Georg Baum
Jean-Marc Lasgouttes wrote: > It looks good, except this bit that I do not like much: Me neither. But if the goal is real roundtrip support, something like this is needed. The problem is that lyx generates a newline at some places (like before \end{qoute} etc. that does not correspond to a space

Re: [patch] tex2lyx whitespace changes

2003-11-03 Thread Georg Baum
Angus Leeming wrote: > Some preliminary questions: > > * 'swallow_newlines' is used to clean-up the output, right? Ie, the > input has already been parsed and the output data generated, but > swallow_newlines is used to 'prettify' this output? Yes. This should probably be modified to handle space

Re: [patch] tex2lyx whitespace changes

2003-11-03 Thread Jean-Marc Lasgouttes
> "Georg" == Georg Baum <[EMAIL PROTECTED]> writes: Georg> Sorry, wrong patch (contained some unrelated test stuff), use Georg> this instead. Georg It looks good, except this bit that I do not like much: + (next.cs() == "end" && (context.layout->latextype == LATEX_ITEM_ENVIRONMENT

Re: [patch] tex2lyx whitespace changes

2003-11-03 Thread Angus Leeming
Georg Baum wrote: > Sorry, wrong patch (contained some unrelated test stuff), use this > instead. Some preliminary questions: * 'swallow_newlines' is used to clean-up the output, right? Ie, the input has already been parsed and the output data generated, but swallow_newlines is used to 'pretti

Re: [patch] tex2lyx whitespace changes

2003-11-03 Thread Lars Gullik Bjønnes
Georg Baum <[EMAIL PROTECTED]> writes: | Sorry, wrong patch (contained some unrelated test stuff), use this instead. Look pretty good to me, but I'd like Andre to have a look as well. -- Lgb

Re: [patch] tex2lyx whitespace changes

2003-11-03 Thread Georg Baum
Sorry, wrong patch (contained some unrelated test stuff), use this instead. GeorgIndex: src/tex2lyx/ChangeLog === RCS file: /cvs/lyx/lyx-devel/src/tex2lyx/ChangeLog,v retrieving revision 1.40 diff -u -r1.40 ChangeLog --- src/tex2lyx/C

[patch] tex2lyx whitespace changes

2003-11-03 Thread Georg Baum
I have modified the parser to not drop any spaces anymore. The result is that the Userguide roundtrip works better. Apart from the preamble, a diff -u Userguide.tex Userguide-new.tex shows now almost only real problems. Another benefit is that it is possible to add support for verbatim and simila