Re: [patch] support for 'solution' in theorems

2015-11-28 Thread Richard Heck
On 11/28/2015 02:44 PM, Uwe Stöhr wrote: > Am 28.11.2015 um 04:58 schrieb Richard Heck: > >> Yes, well, we have had that discussion, and you know how it went. > > I know. And you know that I did nt forget solution* purposely. Of course. >> And honestly, it is not that hard to write reversion code

Re: [patch] support for 'solution' in theorems

2015-11-28 Thread Uwe Stöhr
Am 28.11.2015 um 04:58 schrieb Richard Heck: Yes, well, we have had that discussion, and you know how it went. I know. And you know that I did nt forget solution* purposely. And honestly, it is not that hard to write reversion code. For me it is. That is the part of a new feature that cost

Re: [patch] support for 'solution' in theorems

2015-11-28 Thread Georg Baum
Uwe Stöhr wrote: > Guys, please! If you find a problem then shout but not if there is no > real problem. Jürgen reviewed my proposal, I did a lot of tests and > waited until alpha 1 is released upon request of Scott. For the third time: Unless it was done in private communication, there was _no_

Re: [patch] support for 'solution' in theorems

2015-11-27 Thread Richard Heck
On 11/27/2015 10:10 PM, Uwe Stöhr wrote: > Am 28.11.2015 um 03:48 schrieb Richard Heck: > >> I found a bug: You forgot to revert Solution* in the lyx2lyx code. It >> was completely accidental that I found this, too. > > OK, but this is no reason to stop shipping alpha2. And you know my > opinion ab

Re: [patch] support for 'solution' in theorems

2015-11-27 Thread Uwe Stöhr
Am 28.11.2015 um 03:48 schrieb Richard Heck: I found a bug: You forgot to revert Solution* in the lyx2lyx code. It was completely accidental that I found this, too. OK, but this is no reason to stop shipping alpha2. And you know my opinion about reverting new features to TeX code. If I could

Re: [patch] support for 'solution' in theorems

2015-11-27 Thread Richard Heck
On 11/27/2015 09:35 PM, Uwe Stöhr wrote: > Am 27.11.2015 um 18:55 schrieb Georg Baum: > >>> I don't know if there are problems (apart from the copy-paste error >>> found >>> by Guillaume)... > > Guys, please! If you find a problem then shout but not if there is no > real problem. Jürgen reviewed my

Re: [patch] support for 'solution' in theorems

2015-11-27 Thread Uwe Stöhr
Am 27.11.2015 um 18:55 schrieb Georg Baum: I don't know if there are problems (apart from the copy-paste error found by Guillaume)... Guys, please! If you find a problem then shout but not if there is no real problem. Jürgen reviewed my proposal, I did a lot of tests and waited until alpha 1

Re: [patch] support for 'solution' in theorems

2015-11-27 Thread Richard Heck
On 11/27/2015 02:08 PM, Scott Kostyshak wrote: > On Fri, Nov 27, 2015 at 08:00:53PM +0100, Georg Baum wrote: >> Scott > Kostyshak wrote: >> >>> Oops. I take responsibility for this for releasing with unreviewed >>> stuff. Would you recommend I stop the release of alpha2? >> >> No IMHO, since tarba

Re: [patch] support for 'solution' in theorems

2015-11-27 Thread Scott Kostyshak
On Fri, Nov 27, 2015 at 08:00:53PM +0100, Georg Baum wrote: > Scott Kostyshak wrote: > > > Oops. I take responsibility for this for releasing with unreviewed > > stuff. Would you recommend I stop the release of alpha2? > > No IMHO, since tarballs have already been published, this would only cause

Re: [patch] support for 'solution' in theorems

2015-11-27 Thread Georg Baum
Scott Kostyshak wrote: > Oops. I take responsibility for this for releasing with unreviewed > stuff. Would you recommend I stop the release of alpha2? No IMHO, since tarballs have already been published, this would only cause confusion. The probability that something is wrong is low (but not zer

Re: [patch] support for 'solution' in theorems

2015-11-27 Thread Scott Kostyshak
On Fri, Nov 27, 2015 at 06:55:52PM +0100, Georg Baum wrote: > Georg Baum wrote: > > > Uwe Stöhr wrote: > > > >> Am 18.11.2015 um 20:35 schrieb Georg Baum: > > > > Where is the review of the second commit 0ae337014ec6c? I might not have > > looked well enough, but I only saw the one on trac, whic

Re: [patch] support for 'solution' in theorems

2015-11-27 Thread Georg Baum
Georg Baum wrote: > Uwe Stöhr wrote: > >> Am 18.11.2015 um 20:35 schrieb Georg Baum: > > Where is the review of the second commit 0ae337014ec6c? I might not have > looked well enough, but I only saw the one on trac, which did only cover > the first commit cc6c86ff3b7. > >>> Changing the AMS the

Re: [patch] support for 'solution' in theorems

2015-11-20 Thread Georg Baum
Uwe Stöhr wrote: > Am 18.11.2015 um 20:35 schrieb Georg Baum: > >> How can tex2lyx force you to touch completely unrelated modules? This >> looks like a bug in tex2lyx, which should be addressed properly. > > Because on importing it tex2lyx loads an AMS module because it cannot > know if e.g. th

Re: [patch] support for 'solution' in theorems

2015-11-19 Thread Uwe Stöhr
Am 18.11.2015 um 20:35 schrieb Georg Baum: How can tex2lyx force you to touch completely unrelated modules? This looks like a bug in tex2lyx, which should be addressed properly. Because on importing it tex2lyx loads an AMS module because it cannot know if e.g. the environment "xca" should be

Re: [patch] support for 'solution' in theorems

2015-11-18 Thread Georg Baum
Uwe Stöhr wrote: > OK, tex2lyx forced me to add the solution environment also to the AMS > theorem modules. Now the testfile works. How can tex2lyx force you to touch completely unrelated modules? This looks like a bug in tex2lyx, which should be addressed properly. BTW, you are hopefully aware

Re: [patch] support for 'solution' in theorems

2015-11-18 Thread Georg Baum
Uwe Stöhr wrote: > Am 17.11.2015 um 20:05 schrieb Georg Baum: > >> b) If the lyx2lyx conversion from the old to the new format is empty, or >> if tex2lyx does not yet output the changed feature, you do not need any >> further tex2lyx changes. Otherwise, search for the changed feature in >> tex2ly

Re: [patch] support for 'solution' in theorems

2015-11-17 Thread Uwe Stöhr
Am 18.11.2015 um 01:43 schrieb Uwe Stöhr: The point is that tex2lyx reads theorems in a generic way by reading the \newtheorem statements from the preamble. But when using the attached TeX test file, the solution environment is not recognized as such and ERT is created. So I was asking what I sh

Re: [patch] support for 'solution' in theorems

2015-11-17 Thread Uwe Stöhr
Am 17.11.2015 um 20:05 schrieb Georg Baum: b) If the lyx2lyx conversion from the old to the new format is empty, or if tex2lyx does not yet output the changed feature, you do not need any further tex2lyx changes. Otherwise, search for the changed feature in tex2lyx, and adjust the output accordi

Re: [patch] support for 'solution' in theorems

2015-11-17 Thread Georg Baum
Uwe Stöhr wrote: > The attached patch would fix the longstanding bug > > http://www.lyx.org/trac/ticket/6363 > > This would be a fileformat change and that is why Scott wanted to have > this in after alpha 1. The actual file format change is missing, I guess this will be in the final version?

Re: [patch] support for 'solution' in theorems

2015-11-17 Thread Richard Heck
On 11/16/2015 07:13 PM, Uwe Stöhr wrote: > The attached patch would fix the longstanding bug > > > http://www.lyx.org/trac/ticket/6363 > > This would be a fileformat change and that is why Scott wanted to have this in after alpha 1. > > OK to proceed or do I have to add special tex2lyx things? I

[patch] support for 'solution' in theorems

2015-11-16 Thread Uwe Stöhr
The attached patch would fix the longstanding bug http://www.lyx.org/trac/ticket/6363 This would be a fileformat change and that is why Scott wanted to have this in after alpha 1. OK to proceed or do I have to add special tex2lyx things? thanks and regards Uwe lib/layouts/theorems-bytype.in