Re: [patch] small fix for cygwin

2006-09-08 Thread Jean-Marc Lasgouttes
> "Bo" == Bo Peng <[EMAIL PROTECTED]> writes: >> Yes, Andrè asked for some polish: >> http://thread.gmane.org/gmane.editors.lyx.devel/65033/focus=65975 >> Bo> I understand that you have improved your patch according to Bo> Andre's suggest so I just submitted your newest version to the Bo> tr

Re: [patch] small fix for cygwin

2006-09-02 Thread Enrico Forestieri
On Fri, Sep 01, 2006 at 09:10:58PM -0500, Bo Peng wrote: > > Yes, Andrè asked for some polish: > > http://thread.gmane.org/gmane.editors.lyx.devel/65033/focus=65975 > > > > I understand that you have improved your patch according to Andre's > suggest so I just submitted your newest version to the

Re: [patch] small fix for cygwin

2006-09-01 Thread Bo Peng
Yes, Andrè asked for some polish: http://thread.gmane.org/gmane.editors.lyx.devel/65033/focus=65975 I understand that you have improved your patch according to Andre's suggest so I just submitted your newest version to the trunk. Please patch against the trunk if you have some further improveme

Re: [patch] small fix for cygwin

2006-09-01 Thread Enrico Forestieri
On Fri, Sep 01, 2006 at 03:39:32PM +0200, Abdelrazak Younes wrote: > Enrico, I have committed the patch for trunk only. Thanks Abdel. Appreciated. > If you are really > serious about taking all the blame for it then you should ask for commit > privilege. There nothing scaring about that. ;-)

Re: [patch] small fix for cygwin

2006-09-01 Thread Enrico Forestieri
On Fri, Sep 01, 2006 at 04:56:31PM +0200, Georg Baum wrote: > Bo Peng wrote: > > >> Abdel is right. Come on Enrico... > > > > I second that. BTW, what is the status of the CAS patch? > > Approved by several (including Andre) and should go in. There might have > been some minor modifications t

Re: [patch] small fix for cygwin

2006-09-01 Thread Enrico Forestieri
On Fri, Sep 01, 2006 at 08:59:30AM -0500, Bo Peng wrote: > > Abdel is right. Come on Enrico... > > I second that. First of all, let me thank you all for trusting me. As I already said several times, I am not a programmer, even if I have some skill at programming. I am not sure that I can make

Re: [patch] small fix for cygwin

2006-09-01 Thread Georg Baum
Bo Peng wrote: >> Abdel is right. Come on Enrico... > > I second that. BTW, what is the status of the CAS patch? Approved by several (including Andre) and should go in. There might have been some minor modifications that should be made, but I forgot if that was the case. Georg

Re: [patch] small fix for cygwin

2006-09-01 Thread Bo Peng
Abdel is right. Come on Enrico... I second that. BTW, what is the status of the CAS patch? BO

Re: [patch] small fix for cygwin

2006-09-01 Thread José Matos
On Friday 01 September 2006 14:39, Abdelrazak Younes wrote: > Enrico, I have committed the patch for trunk only. If you are really > serious about taking all the blame for it then you should ask for commit > privilege. There nothing scaring about that. Abdel is right. Come on Enrico... (I wou

Re: [patch] small fix for cygwin

2006-09-01 Thread Abdelrazak Younes
Enrico Forestieri wrote: In src/support/os_cygwin.C path styles are converted (when needed) from one style to another. I discovered a couple of cases in which an unnecessary conversion takes place. The default output path style in external_path is windows because this function is also used when

[patch] small fix for cygwin

2006-08-30 Thread Enrico Forestieri
In src/support/os_cygwin.C path styles are converted (when needed) from one style to another. I discovered a couple of cases in which an unnecessary conversion takes place. The default output path style in external_path is windows because this function is also used when adding fonts though a nativ