Re: [Patch] Small cleanup in BufferView*

2006-06-28 Thread Abdelrazak Younes
Jean-Marc Lasgouttes wrote: "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> Right, I am talking about transferring "cursor_timeout" Abdelrazak> and "cursorToggle()" not the "LCursor cursor_" which is Abdelrazak> something completely different. So you won't get rid of

Re: [Patch] Small cleanup in BufferView*

2006-06-28 Thread Jean-Marc Lasgouttes
> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> Right, I am talking about transferring "cursor_timeout" Abdelrazak> and "cursorToggle()" not the "LCursor cursor_" which is Abdelrazak> something completely different. So you won't get rid of cursor.h. JMarc

Re: [Patch] Small cleanup in BufferView*

2006-06-28 Thread Abdelrazak Younes
Jean-Marc Lasgouttes wrote: "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> If we manage to transfer the cursor handling to Abdelrazak> frontends/GuiCursor, only those two will remain: But the cursor handling of GuiCursor is just the flashing thing on screen, right? T

Re: [Patch] Small cleanup in BufferView*

2006-06-28 Thread Jean-Marc Lasgouttes
> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> If we manage to transfer the cursor handling to Abdelrazak> frontends/GuiCursor, only those two will remain: But the cursor handling of GuiCursor is just the flashing thing on screen, right? The use of cursor in Buffe

Re: [Patch] Small cleanup in BufferView*

2006-06-28 Thread Abdelrazak Younes
Jean-Marc Lasgouttes wrote: "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> Hello, I don't think there would be any objection to this Abdelrazak> patch but I'll wait till the end of the day before Abdelrazak> committing. After this patch the BufferView.h and Abdelrazak

Re: [Patch] Small cleanup in BufferView*

2006-06-28 Thread Jean-Marc Lasgouttes
> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> Hello, I don't think there would be any objection to this Abdelrazak> patch but I'll wait till the end of the day before Abdelrazak> committing. After this patch the BufferView.h and Abdelrazak> BufferView_pimpl.h head

[Patch] Small cleanup in BufferView*

2006-06-28 Thread Abdelrazak Younes
Hello, I don't think there would be any objection to this patch but I'll wait till the end of the day before committing. After this patch the BufferView.h and BufferView_pimpl.h headers are pretty similar. So, unless there is a strong objection I will put the cursor handling out of the pimpl

Re: [Devel] [patch] small cleanup

2003-11-28 Thread Alfredo Braunstein
On Friday 28 November 2003 21:31, Alfredo Braunstein wrote: > do not use cursors when not needed, rewrite loops in a more standard > way, and do not abuse parOffset calculations (inside loops). > All semi-automatic (it can containg bugs as always, though) > I'm leaving in a few hours, so I will not

[patch] small cleanup

2003-11-28 Thread Alfredo Braunstein
do not use cursors when not needed, rewrite loops in a more standard way, and do not abuse parOffset calculations (inside loops). All semi-automatic (it can containg bugs as always, though) I'm leaving in a few hours, so I will not apply this by myself. (I'll look again at it on monday or so)