Re: [patch] rowbreakpoint

2003-10-27 Thread Andre Poenitz
On Mon, Oct 27, 2003 at 11:12:32AM +0100, Alfredo Braunstein wrote: > Alfredo Braunstein wrote: > > > These are the two missing fixes + a bit of noncontroversial rowbreakpoint > > simplification. > > I'd apply this if no one objects. Not me ;-) Andre'

Re: [patch] rowbreakpoint

2003-10-27 Thread Alfredo Braunstein
Alfredo Braunstein wrote: > These are the two missing fixes + a bit of noncontroversial rowbreakpoint > simplification. I'd apply this if no one objects. Alfredo

Re: [patch] rowbreakpoint

2003-10-25 Thread Angus Leeming
Alfredo Braunstein wrote: >> Do you need 'i' after the end of this for loop? If so, rename it. >> If > > Yes. What do you suggest for a name? I'm out of imagination. Ok, I looked at the code and all appears fine. Sorry for the noise. Angus pos_type point = end; pos_type i = pos;

Re: [patch] rowbreakpoint

2003-10-25 Thread Alfredo Braunstein
Angus Leeming wrote: > Alfredo Braunstein wrote: > >> +pos_type i = pos; >> for ( ; i < end; ++i) { > > Do you need 'i' after the end of this for loop? If so, rename it. If Yes. What do you suggest for a name? I'm out of imagination. Alfredo

Re: [patch] rowbreakpoint

2003-10-25 Thread Angus Leeming
Alfredo Braunstein wrote: > +pos_type i = pos; > for ( ; i < end; ++i) { Do you need 'i' after the end of this for loop? If so, rename it. If not, shove it into 'for (pos_type i = pos; i < end; ++i) {' -- Angus

[patch] rowbreakpoint

2003-10-25 Thread Alfredo Braunstein
These are the two missing fixes + a bit of noncontroversial rowbreakpoint simplification. Regards, Alfredo Index: src/ChangeLog === RCS file: /usr/local/lyx/cvsroot/lyx-devel/src/ChangeLog,v retrieving revision 1.1651 diff -u -p -u -r