Re: [patch] quote-insert

2004-03-16 Thread Juergen Spitzmueller
Jean-Marc Lasgouttes wrote: > Yes, we definitely should. Did you fix that? (1.3.5cvs could use this > too). Not yet. I'll commit to 1.4 and 1.3.5 (patch attached). BTW the latest fun in cvs is: quotation marks get inserted *after* the cursor. Jürgen. Index: src/insets/ChangeLog ==

Re: [patch] quote-insert

2004-03-15 Thread Jean-Marc Lasgouttes
> "Juergen" == Juergen Spitzmueller <[EMAIL PROTECTED]> writes: Juergen> BTW, Jean-Marc, is there a special reason why we don't use Juergen> opening quotes after '['? I think we should (analogous to Juergen> '('). Yes, we definitely should. Did you fix that? (1.3.5cvs could use this too). JM

Re: [patch] quote-insert

2004-02-20 Thread Juergen Spitzmueller
Andre Poenitz wrote: > > Is it o.k. when I just commit the stuff without the ERT fix and let you > > do this? > > Yes. Thanks. It's in. Over to you. Jürgen.

Re: [patch] quote-insert

2004-02-20 Thread Andre Poenitz
On Fri, Feb 20, 2004 at 10:49:36AM +0100, Juergen Spitzmueller wrote: > Andre Poenitz: > > This should be handled in the ERTInset's dispatch, or even better, > > 'forbidden' by LyXFunc::status. And LyXFunc::status should be split into > > inset specific parts and shifted to the some Inset::status w

Re: [patch] quote-insert

2004-02-20 Thread Juergen Spitzmueller
Andre Poenitz: > This should be handled in the ERTInset's dispatch, or even better, > 'forbidden' by LyXFunc::status. And LyXFunc::status should be split into > inset sopecific parts and shifted to the some Inset::status where > appropriate. Is it o.k. when I just commit the stuff without the ERT

Re: [patch] quote-insert

2004-02-19 Thread Andre Poenitz
On Thu, Feb 19, 2004 at 01:08:14PM +0100, Juergen Spitzmueller wrote: > Juergen Spitzmueller wrote: > > OK, here's a patch with the proposed changes and the changes to the ui > > (qt/xforms document dialogs, bindings [1], menus). > > Please tell me if this can go in. > > One additional question. E

Re: [patch] quote-insert

2004-02-19 Thread Andre Poenitz
On Wed, Feb 18, 2004 at 05:57:30PM +0100, Juergen Spitzmueller wrote: > As you may have noticed, quote-insert is broken in current cvs (always inserts > raw quotes). IMHO this is due to this change: > http://www.lyx.org/cgi-bin/viewcvs.cgi/lyx-devel/src/text3.C.diff?r1=1.214&r2=1.215 > >

Re: [patch] quote-insert

2004-02-19 Thread Andre Poenitz
On Wed, Feb 18, 2004 at 06:20:22PM +0100, Juergen Spitzmueller wrote: > Jean-Marc Lasgouttes wrote: > > Note however that inner/outer is not the same as single/double. There > > probably needs to be big changes in insetquote data structures to > > support this inner/outer stuff properly. > > I can

Re: [patch] quote-insert

2004-02-19 Thread Juergen Spitzmueller
Juergen Spitzmueller wrote: > OK, here's a patch with the proposed changes and the changes to the ui > (qt/xforms document dialogs, bindings [1], menus). > Please tell me if this can go in. One additional question. ERT allows typographical quotation marks now. I think this is not my doing, but I'

Re: [patch] quote-insert

2004-02-19 Thread Jean-Marc Lasgouttes
> "Ronald" == Ronald Florence <[EMAIL PROTECTED]> writes: Ronald> Juergen Spitzmueller wrote: >> [1] I do not understand aqua.bind. I have added a FIXME there. For Ronald> the other >> ones, I have bound single quotes to S-" and raw quote to M-" where >> possible, because I think single quote

Re: [patch] quote-insert

2004-02-18 Thread Juergen Spitzmueller
Ronald Florence wrote: > aqua.bind is used only in addition to one of the traditional bind files > like cua.bind or emacs.bind (to provide keyboard shortcuts for LyX/Aqua > users), so it probably doesn't need this new change for single or double > quotes. OK, thanks. Please make sure that single q

Re: [patch] quote-insert

2004-02-18 Thread Ronald Florence
Juergen Spitzmueller wrote: > [1] I do not understand aqua.bind. I have added a FIXME there. For the other ones, I have bound single quotes to S-" and raw quote to M-" where possible, because I think single quote is used more frequently. aqua.bind is used only in addition to one of the traditio

Re: [patch] quote-insert

2004-02-18 Thread Juergen Spitzmueller
Juergen Spitzmueller: > I'll prepare a patch with all this changes. OK, here's a patch with the proposed changes and the changes to the ui (qt/xforms document dialogs, bindings [1], menus). Please tell me if this can go in. BTW, Jean-Marc, is there a special reason why we don't use opening quote

Re: [patch] quote-insert

2004-02-18 Thread Jean-Marc Lasgouttes
> "Juergen" == Juergen Spitzmueller <[EMAIL PROTECTED]> writes: Juergen> I can also call the arguments "single|double" (is this Juergen> better?). This changes are of course only a first step and do Juergen> not support quote nesting. I just makes the handling of Juergen> single and double quo

Re: [patch] quote-insert

2004-02-18 Thread Juergen Spitzmueller
Jean-Marc Lasgouttes wrote: > Note however that inner/outer is not the same as single/double. There > probably needs to be big changes in insetquote data structures to > support this inner/outer stuff properly. I can also call the arguments "single|double" (is this better?). This changes are of c

Re: [patch] quote-insert

2004-02-18 Thread Jean-Marc Lasgouttes
> "Juergen" == Juergen Spitzmueller <[EMAIL PROTECTED]> writes: Juergen> I fixed this on the way to a first step towards better Juergen> quotation mark handling: the attached patch introduces lfun Juergen> arguments "quote-insert [inner| outer]" where single and Juergen> double quotation marks

Re: [patch] quote-insert

2004-02-18 Thread John Levon
On Wed, Feb 18, 2004 at 05:57:30PM +0100, Juergen Spitzmueller wrote: > [1] I think we could get rid of the toggle and bind "quote-insert inner" to > M-" or whatever. Yay to this part anyway. (Needs menu UI though I think) john -- "Spammers get STABBED by GOD." - Ron Echeverri

[patch] quote-insert

2004-02-18 Thread Juergen Spitzmueller
As you may have noticed, quote-insert is broken in current cvs (always inserts raw quotes). IMHO this is due to this change: http://www.lyx.org/cgi-bin/viewcvs.cgi/lyx-devel/src/text3.C.diff?r1=1.214&r2=1.215 BufferParams const & bufparams = bv->buffer()->params();