Re: [patch] partial pimpl-ing of BufferParams

2003-09-10 Thread Andre Poenitz
On Wed, Sep 10, 2003 at 10:37:38AM +0200, Andre' Poenitz wrote: > On Tue, Sep 09, 2003 at 04:21:04PM +, Angus Leeming wrote: > > This patch is a 'pragmatic pimpl-ing' of BufferParams. It moves into Impl only > > those member variables that currently drag in header files into > > bufferparams.

Re: [patch] partial pimpl-ing of BufferParams

2003-09-10 Thread Andre Poenitz
On Tue, Sep 09, 2003 at 04:21:04PM +, Angus Leeming wrote: > This patch is a 'pragmatic pimpl-ing' of BufferParams. It moves into Impl only > those member variables that currently drag in header files into > bufferparams.h. > > I had two choices when implementing it. > * Explicitly define a

Re: Basic-rambling (was Re: [patch] partial pimpl-ing of BufferParams)

2003-09-09 Thread Martin Vermeer
On Tue, Sep 09, 2003 at 03:13:03PM -0400, Kuba Ober spake thusly: ... > > Thanks for the link! IIRC Micro$oft Extended Color Basic used > > precisely COW for its string heap (yes I'm *that* old :-) > > So you did interface to the string heap from assembly or C, right? peeking and > poking was

Basic-rambling (was Re: [patch] partial pimpl-ing of BufferParams)

2003-09-09 Thread Kuba Ober
> > The Loki library certainly has one, but I think that this one is > > perfectly acceptable. It was written by Yonat Sharon: > > http://ootips.org/yonat/ I just used boost::shared_ptr internally rather > > than his hand-written equivalent. I have changed the authorship of the > > file appropriate

Re: [patch] partial pimpl-ing of BufferParams

2003-09-09 Thread Martin Vermeer
On Tue, Sep 09, 2003 at 05:22:58PM +, Angus Leeming spake thusly: ... > The Loki library certainly has one, but I think that this one is perfectly > acceptable. It was written by Yonat Sharon: http://ootips.org/yonat/ > I just used boost::shared_ptr internally rather than his hand-written

Re: [patch] partial pimpl-ing of BufferParams

2003-09-09 Thread Lars Gullik Bjønnes
Angus Leeming <[EMAIL PROTECTED]> writes: | Anyway, can I apply the patch? If you comment on my assert patch. -- Lgb

Re: [patch] partial pimpl-ing of BufferParams

2003-09-09 Thread Angus Leeming
Lars Gullik Bjønnes wrote: > Angus Leeming <[EMAIL PROTECTED]> writes: > > | This patch is a 'pragmatic pimpl-ing' of BufferParams. It moves into Impl > | only those member variables that currently drag in header files into > | bufferparams.h. >> > | I had two choices when implementing it. > | *

Re: [patch] partial pimpl-ing of BufferParams

2003-09-09 Thread Lars Gullik Bjønnes
Angus Leeming <[EMAIL PROTECTED]> writes: | This patch is a 'pragmatic pimpl-ing' of BufferParams. It moves into Impl only | those member variables that currently drag in header files into | bufferparams.h. > | I had two choices when implementing it. | * Explicitly define a copy constructor and

[patch] partial pimpl-ing of BufferParams

2003-09-09 Thread Angus Leeming
This patch is a 'pragmatic pimpl-ing' of BufferParams. It moves into Impl only those member variables that currently drag in header files into bufferparams.h. I had two choices when implementing it. * Explicitly define a copy constructor and assignment operator for BufferParams. * Define a smar