On Thu, Jul 17, 2003 at 10:10:57AM +0200, Alfredo Braunstein wrote:
> How about this?
> [...]
> }
> +
> +
> +
> +
> +string const BufferParams::paperSizeName() const
Four empty lines look a bit excessive ;-)
Rest looks ok.
Andre'
--
Those who desire to give up Freedom in order to gain Securi
Andre Poenitz wrote:
>> Yes, but don't kill the messenger ;^)
>
> I won't. That's what the 'I'd think so' was good for...
I want to remark that I was joking, and I really apreciate your comments (I
think that we are in a state that, if someone reads and understand a piece
of code, it's a pitty i
On Thu, Jul 17, 2003 at 09:16:28AM +0200, Alfredo Braunstein wrote:
> Andre Poenitz wrote:
>
> >> +string const papersize(Buffer const * buffer)
> >> +{
> >
> > Shouldn't a BufferParams const & suffice?
>
> Yes, but don't kill the messenger ;^)
I won't. That's what the 'I'd think so' was good f
Andre Poenitz wrote:
>> +string const papersize(Buffer const * buffer)
>> +{
>
> Shouldn't a BufferParams const & suffice?
Yes, but don't kill the messenger ;^)
>> +string const dvips_options(Buffer const * buffer)
>> +{
>
> Same here.
>
> Hm.. and as bufferparams.h uses string anyway, this
On Thu, Jul 17, 2003 at 09:02:50AM +0200, Alfredo Braunstein wrote:
> These are not related to converter/format and are reused.
>
> Ok to apply?
I'd think so.
> +string const papersize(Buffer const * buffer)
> +{
Shouldn't a BufferParams const & suffice?
> +string const dvips_options(Buffer co
These are not related to converter/format and are reused.
Ok to apply?
Index: ChangeLog
===
RCS file: /usr/local/lyx/cvsroot/lyx-devel/src/ChangeLog,v
retrieving revision 1.1421
diff -u -p -u -r1.1421 ChangeLog
--- ChangeLog 17 Ju
