Re: [patch] move x_fix from LyXCursor to BufferView

2003-11-03 Thread Andre Poenitz
On Mon, Nov 03, 2003 at 06:57:49PM +, Angus Leeming wrote: > Since all other BufferView data members are in the Pimpl, shouldn't > this go in there too? Maybe, maybe not. Actually I prefer to have simple stuff not pimpled. Including getters and setters we end up with ~20 LOC just for a pimpl

Re: [patch] move x_fix from LyXCursor to BufferView

2003-11-03 Thread Andre Poenitz
On Mon, Nov 03, 2003 at 06:39:57PM +, John Levon wrote: > On Mon, Nov 03, 2003 at 06:57:02PM +0100, Andre Poenitz wrote: > > > x_target? > > saved_x ? latent_x ? > > Isn't the big fat comment I added enough ? The comment is still there. I don't care about the name but Lars did not like it.

Re: [patch] move x_fix from LyXCursor to BufferView

2003-11-03 Thread Angus Leeming
Lars Gullik Bjønnes wrote: > Andre Poenitz <[EMAIL PROTECTED]> writes: > > | On Mon, Nov 03, 2003 at 06:49:31PM +0100, Lars Gullik Bjønnes > | wrote: >>> Andre Poenitz <[EMAIL PROTECTED]> writes: >>> >>> | Conceptually there is only one 'target x position' per >>> | BufferView, not one per inset

Re: [patch] move x_fix from LyXCursor to BufferView

2003-11-03 Thread John Levon
On Mon, Nov 03, 2003 at 07:43:20PM +0100, Lars Gullik Bj?nnes wrote: > x_latent_pos_read_doc_at_declaration Hmm, now you are reminding me of a certain lecturer during my undergrad CS days :) (Running joke was that he wrote programs by encoding the entire logic in a single variable name :) john

Re: [patch] move x_fix from LyXCursor to BufferView

2003-11-03 Thread Lars Gullik Bjønnes
John Levon <[EMAIL PROTECTED]> writes: | On Mon, Nov 03, 2003 at 06:57:02PM +0100, Andre Poenitz wrote: > >> x_target? > | saved_x ? latent_x ? > | Isn't the big fat comment I added enough ? not with the x_fix name :-) But sure, the comment helps a lot. x_latent_pos_read_doc_at_declaration --

Re: [patch] move x_fix from LyXCursor to BufferView

2003-11-03 Thread John Levon
On Mon, Nov 03, 2003 at 06:57:02PM +0100, Andre Poenitz wrote: > x_target? saved_x ? latent_x ? Isn't the big fat comment I added enough ? john -- Khendon's Law: If the same point is made twice by the same person, the thread is over.

Re: [patch] move x_fix from LyXCursor to BufferView

2003-11-03 Thread Lars Gullik Bjønnes
Andre Poenitz <[EMAIL PROTECTED]> writes: | On Mon, Nov 03, 2003 at 06:49:31PM +0100, Lars Gullik Bjønnes wrote: >> Andre Poenitz <[EMAIL PROTECTED]> writes: >> >> | Conceptually there is only one 'target x position' per BufferView, not >> | one per inset. And the LyXCursors used for selection ha

Re: [patch] move x_fix from LyXCursor to BufferView

2003-11-03 Thread Andre Poenitz
On Mon, Nov 03, 2003 at 06:49:31PM +0100, Lars Gullik Bjønnes wrote: > Andre Poenitz <[EMAIL PROTECTED]> writes: > > | Conceptually there is only one 'target x position' per BufferView, not > | one per inset. And the LyXCursors used for selection have not been using > | their x_fix at all. > > > |

Re: [patch] move x_fix from LyXCursor to BufferView

2003-11-03 Thread Lars Gullik Bjønnes
Andre Poenitz <[EMAIL PROTECTED]> writes: | Conceptually there is only one 'target x position' per BufferView, not | one per inset. And the LyXCursors used for selection have not been using | their x_fix at all. > | Small step towards cursor globalization. [Finally we'd have one 'real' | cursor pe

[patch] move x_fix from LyXCursor to BufferView

2003-11-03 Thread Andre Poenitz
Conceptually there is only one 'target x position' per BufferView, not one per inset. And the LyXCursors used for selection have not been using their x_fix at all. Small step towards cursor globalization. [Finally we'd have one 'real' cursor per bv] Andre' -- Those who desire to give up Freedo