Re: [patch] more buffer cleanup

2003-07-11 Thread Kayvan A. Sylvan
On Fri, Jul 11, 2003 at 03:02:25PM +0200, Alfredo Braunstein wrote: > Kayvan A. Sylvan wrote: > > > The only unusual behavior is a crash when trying to check in. > > > > It's the same as the File->Quit issue I just reported, I suspect. > > > > Just open Reference.lyx and do File->Quit > > Pleas

Re: [patch] more buffer cleanup

2003-07-11 Thread Alfredo Braunstein
Kayvan A. Sylvan wrote: > The only unusual behavior is a crash when trying to check in. > > It's the same as the File->Quit issue I just reported, I suspect. > > Just open Reference.lyx and do File->Quit Please try again and let me know if all is ok. Thanks, Alfredo

Re: [patch] more buffer cleanup

2003-07-10 Thread Kayvan A. Sylvan
On Thu, Jul 10, 2003 at 02:27:02PM +0200, Alfredo Braunstein wrote: > Lars Gullik Bjønnes wrote: > > > Please commit this. > > Done. > > Regards, Alfredo > > PS: People using LyX's RCS/CVS please report any unusual behaviour. The only unusual behavior is a crash when trying to check in. It's

Re: [patch] more buffer cleanup

2003-07-10 Thread Alfredo Braunstein
Lars Gullik Bjønnes wrote: > Please commit this. Done. Regards, Alfredo PS: People using LyX's RCS/CVS please report any unusual behaviour.

Re: [patch] more buffer cleanup

2003-07-09 Thread Alfredo Braunstein
Lars Gullik Bjønnes wrote: > Please commit this. Let me do some testing first. Regards, Alfredo

Re: [patch] more buffer cleanup

2003-07-09 Thread Lars Gullik Bjønnes
Alfredo Braunstein <[EMAIL PROTECTED]> writes: | the idea is to get rid of view-related back pointers in buffer, and make it | act as a mere backend as it should. This looks very nice. Please commit this. -- Lgb

Re: [patch] more buffer cleanup

2003-07-09 Thread Andre Poenitz
On Wed, Jul 09, 2003 at 12:44:05PM +0200, Alfredo Braunstein wrote: > Andre Poenitz wrote: > > > On Wed, Jul 09, 2003 at 12:26:37PM +0200, Alfredo Braunstein wrote: > >> Yes, but it's virtual from insetbase (returns 0 there) add I wanted to be > >> sure not to miss any call > > > > Ok. Good excus

Re: [patch] more buffer cleanup

2003-07-09 Thread Alfredo Braunstein
Andre Poenitz wrote: > On Wed, Jul 09, 2003 at 12:26:37PM +0200, Alfredo Braunstein wrote: >> Yes, but it's virtual from insetbase (returns 0 there) add I wanted to be >> sure not to miss any call > > Ok. Good excuse ;-) Actually, is there a way to detect if a method get linked when it's virtual

Re: [patch] more buffer cleanup

2003-07-09 Thread Andre Poenitz
On Wed, Jul 09, 2003 at 12:26:37PM +0200, Alfredo Braunstein wrote: > Yes, but it's virtual from insetbase (returns 0 there) add I wanted to be > sure not to miss any call Ok. Good excuse ;-) > (probably the one from insetbase should be removed also) Maybe in the end. Seems to be used by the pre

Re: [patch] more buffer cleanup

2003-07-09 Thread Alfredo Braunstein
Andre Poenitz wrote: > BufferView * InsetTabular::view() const > { > - return buffer_->getUser(); > + Assert(false); > + return 0; > } > > Doesn't that mean that function should be removed altogether? > > Andre' > Yes, but it's virtual from insetbase (returns 0 there) add

Re: [patch] more buffer cleanup

2003-07-09 Thread Andre Poenitz
On Wed, Jul 09, 2003 at 12:10:05PM +0200, Alfredo Braunstein wrote: > It also cleans up the VC code a little IMHO. > > BufferView_pimpl.C| 15 +-- > BufferView_pimpl.h|4 ++ > buffer.C | 67 > +- > buffer.h

[patch] more buffer cleanup

2003-07-09 Thread Alfredo Braunstein
the idea is to get rid of view-related back pointers in buffer, and make it act as a mere backend as it should. I suppose the patch can be syntetized in say: |RCS file: /usr/local/lyx/cvsroot/lyx-devel/src/buffer.C,v |retrieving revision 1.491 |diff -u -p -u -r1.491 buffer.C |--- buffer.C 7 Jul